Teleporter working in creative, but not in survival. (1.10.2)

[Dustpuppy]

Hi,

i have a problem with my teleporter. It's an item, that places a block and if clicked on a  nother block of same type it will bound both together and teleport the player if he collides with one of them.

Easy said: 2 mirrors, that will be bound together and teleport the player between both.

It's working in creative mode, but in survival mode i allways get : Player moved wrongly!

 

This is the item

package thewizardmod.mirror;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.util.text.TextComponentString;
import net.minecraft.world.World;
import thewizardmod.Util.RayTrace;

public class ItemMirror extends Item
{
	
  public ItemMirror()
  {
    final int MAXIMUM_NUMBER_IN_STACK = 1;
    this.setMaxStackSize(MAXIMUM_NUMBER_IN_STACK);

    this.setCreativeTab(CreativeTabs.MISC);   // the item will appear on the Miscellaneous tab in creative
  }

  @Override
	public EnumActionResult onItemUse(ItemStack stack, EntityPlayer playerIn, World worldIn, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {
	    
		RayTraceResult p = RayTrace.rayTraceBlocksAndEntities(worldIn, 5, playerIn);

		BlockPos newpos;
		if(p != null)
		{
		  newpos = p.getBlockPos().offset(facing);
		
		  if(worldIn.getBlockState(p.getBlockPos()).getBlock() != StartupCommon.mirror)
		  {
			  if(facing == EnumFacing.NORTH || facing == EnumFacing.SOUTH || facing == EnumFacing.WEST || facing == EnumFacing.EAST)
			  {
				  worldIn.setBlockState(newpos, StartupCommon.mirror.getDefaultState().withProperty(Mirror.PROPERTYFACING, facing.getOpposite()));
				  NBTTagCompound nbtTagCompound = stack.getTagCompound();
				  if (nbtTagCompound != null && nbtTagCompound.hasKey("Bound") && nbtTagCompound.getBoolean("Bound") == true ) 
				  {
					  TileEntity tileEntity = worldIn.getTileEntity(newpos);
					  if (tileEntity instanceof TileEntityBlockMirror) 
					  {
						  TileEntityBlockMirror te = (TileEntityBlockMirror) tileEntity;
						  double x = nbtTagCompound.getDouble("X");
						  double y = nbtTagCompound.getDouble("Y");
						  double z = nbtTagCompound.getDouble("Z");
						  te.setPosition(x, y, z);

						  double oldX = nbtTagCompound.getDouble("oldTeX");
						  double oldY = nbtTagCompound.getDouble("oldTeY");
						  double oldZ = nbtTagCompound.getDouble("oldTeZ");
						  BlockPos oldTePos = new BlockPos(oldX, oldY, oldZ);
						  TileEntity tileEntityOld = worldIn.getTileEntity(oldTePos);
						  if (tileEntity instanceof TileEntityBlockMirror) 
						  {
							  TileEntityBlockMirror te2 = (TileEntityBlockMirror) tileEntityOld;
							  BlockPos targetPos = newpos.offset(facing);
							  te2.setPosition(targetPos.getX(), targetPos.getY(), targetPos.getZ());
						  }						  
					  }
					  
				  }
				  stack.stackSize--;
			  }
		  }
		  else
		  {
		      NBTTagCompound nbt;
		      if (stack.hasTagCompound())
		      {
		          nbt = stack.getTagCompound();
		      }
		      else
		      {
		          nbt = new NBTTagCompound();
		      }
		      BlockPos targetPos = newpos.offset(facing);
		      nbt.setBoolean("Bound", true);
		      nbt.setDouble("X", targetPos.getX());
		      nbt.setDouble("Y", targetPos.getY());
		      nbt.setDouble("Z", targetPos.getZ());
		      nbt.setDouble("oldTeX", p.getBlockPos().getX());
		      nbt.setDouble("oldTeY", p.getBlockPos().getY());
		      nbt.setDouble("oldTeZ", p.getBlockPos().getZ());
		      stack.setTagCompound(nbt);
		      if (worldIn.isRemote) {  // only on the client side, else you will get two messages..
		          playerIn.addChatComponentMessage(new TextComponentString("Mirror bound!"));
		        }
		  }
		}
	  return super.onItemUse(stack, playerIn, worldIn, pos, hand, facing, hitX, hitY, hitZ);
	}
}

 

The Block

package thewizardmod.mirror;

import java.util.List;

import javax.annotation.Nullable;

import net.minecraft.block.Block;
import net.minecraft.block.BlockPistonBase;
import net.minecraft.block.ITileEntityProvider;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyDirection;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.init.SoundEvents;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.BlockRenderLayer;
import net.minecraft.util.EnumBlockRenderType;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.SoundCategory;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.MathHelper;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class Mirror extends Block implements ITileEntityProvider{
	private static final AxisAlignedBB BOUNCING_BOX_SOUTH = new AxisAlignedBB(0.0625 * 0,  0, 0.0625 * 14, 0.0625 * 16,  0.0625 * 16, 0.0625 * 16);
	private static final AxisAlignedBB BOUNCING_BOX_NORTH = new AxisAlignedBB(0.0625 * 0,  0, 0.0625 * 0,  0.0625 * 16,  0.0625 * 16, 0.0625 * 2);
	private static final AxisAlignedBB BOUNCING_BOX_EAST =  new AxisAlignedBB(0.0625 * 14, 0, 0.0625 * 0,  0.0625 * 16,  0.0625 * 16, 0.0625 * 16);
	private static final AxisAlignedBB BOUNCING_BOX_WEST =  new AxisAlignedBB(0.0625 * 0,  0, 0.0625 * 0,  0.0625 * 2,   0.0625 * 16, 0.0625 * 16);
	public static final PropertyDirection PROPERTYFACING = PropertyDirection.create("facing", EnumFacing.Plane.HORIZONTAL);

	
	public static EnumFacing FACING;
	
	public Mirror() {
		super(Material.GLASS);
		this.setCreativeTab(CreativeTabs.MISC);
		this.setDefaultState(this.blockState.getBaseState().withProperty(PROPERTYFACING, EnumFacing.NORTH));
		setHardness(3.0F);
		setResistance(5.0F);

	}

	@SideOnly(Side.CLIENT)
	public BlockRenderLayer getBlockLayer() {
		return BlockRenderLayer.TRANSLUCENT;
	}

	@Override
	public boolean isOpaqueCube(IBlockState iBlockState) {
		return false;
	}

	@Override
	public boolean isFullCube(IBlockState iBlockState) {
		return false;
	}

	@Override
	public EnumBlockRenderType getRenderType(IBlockState iBlockState) {
		return EnumBlockRenderType.MODEL;
	}
	
	  @Override
	  public TileEntity createNewTileEntity(World worldIn, int meta) {
		return new TileEntityBlockMirror();
	  }

	  @Override
	  @Deprecated
	  public AxisAlignedBB getBoundingBox(IBlockState state, IBlockAccess source, BlockPos pos) {
		  if(state.getValue(PROPERTYFACING) == EnumFacing.NORTH)
		  {
			  return BOUNCING_BOX_NORTH;
		  }
		  if(state.getValue(PROPERTYFACING) == EnumFacing.SOUTH)
		  {
			  return BOUNCING_BOX_SOUTH;
		  }
		  if(state.getValue(PROPERTYFACING) == EnumFacing.EAST)
		  {
			  return BOUNCING_BOX_EAST;
		  }
		  if(state.getValue(PROPERTYFACING) == EnumFacing.WEST)
		  {
			  return BOUNCING_BOX_WEST;
		  }
		  return null;
	  }
		@Override
		public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing blockFaceClickedOn, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer)
		{
			  // find the quadrant the player is facing
			EnumFacing enumfacing = (placer == null) ? EnumFacing.NORTH : EnumFacing.fromAngle(placer.rotationYaw);
			
			FACING = enumfacing;

			TileEntity tileEntity = worldIn.getTileEntity(pos);
			if (tileEntity instanceof TileEntityBlockMirror) {
				int facing = MathHelper.floor_double((double) ((placer.rotationYaw * 4F) / 360F) + 0.5D) & 3;
				((TileEntityBlockMirror) tileEntity).setFacing(facing);
			}
			return this.getDefaultState().withProperty(PROPERTYFACING, enumfacing);
			  
		}		  		
		@Override
		public IBlockState getActualState(IBlockState state, IBlockAccess worldIn, BlockPos pos)
		{
			return state;
		}

		@Override
		public IBlockState getStateFromMeta(int meta)
		{
			return getDefaultState().withProperty(PROPERTYFACING, EnumFacing.getHorizontal(meta));
		}

		@Override
		public int getMetaFromState(IBlockState state)
		{
			return state.getValue(PROPERTYFACING).getHorizontalIndex();
		}

		@Override
		protected BlockStateContainer createBlockState()
		{
			return new BlockStateContainer(this, new IProperty[] {PROPERTYFACING});
		}

		@Override
		public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) 
		{
			TileEntity tileEntity = worldIn.getTileEntity(pos);
			if (tileEntity instanceof TileEntityBlockMirror) 
			{
				TileEntityBlockMirror te = (TileEntityBlockMirror) tileEntity;
				double x = te.getX();
				double y = te.getY();
				double z = te.getZ();
			    if (worldIn.isRemote) {  // client side
			        worldIn.playSound(x, y, z, SoundEvents.ENTITY_ENDERMEN_TELEPORT, SoundCategory.PLAYERS, 1.0F, 1.0F, false);
			      } else {  // server side
			        if (entityIn instanceof EntityPlayerMP) { // should be an EntityPlayerMP; check first just to be sure to avoid crash
			          EntityPlayerMP entityPlayerMP = (EntityPlayerMP)entityIn;
			          entityPlayerMP.connection.setPlayerLocation(x, y, z, entityPlayerMP.rotationYaw, entityPlayerMP.rotationPitch);
			          final EntityPlayerMP dontPlayForThisPlayer = entityPlayerMP;
			          worldIn.playSound(dontPlayForThisPlayer, x, y, z, SoundEvents.ENTITY_ENDERMEN_TELEPORT, SoundCategory.PLAYERS, 1.0F, 1.0F);
			        }
			      }
				
			}
			super.onEntityCollidedWithBlock(worldIn, pos, state, entityIn);
		}
}

 

And the tile entity

package thewizardmod.mirror;

import javax.annotation.Nullable;

import net.minecraft.block.state.IBlockState;
import net.minecraft.client.renderer.texture.ITickable;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.play.server.SPacketUpdateTileEntity;
import net.minecraft.tileentity.TileEntity;
import thewizardmod.items.StartupCommon;

public class TileEntityBlockMirror extends TileEntity{

	public int facing;
	public double posX, posY, posZ;
	
	public int getFacing()
	{
		return facing;
	}
	
	public void setFacing(int facing)
	{
		this.facing = facing;
		markDirty();
	}
	
	public void setPosition(double x, double y, double z)
	{
		this.posX = x;
		this.posY = y;
		this.posZ = z;
		markDirty();
	}
	
	public double getX()
	{
		return posX;
	}
	
	public double getY()
	{
		return posY;
	}
	
	public double getZ()
	{
		return posZ;
	}
	
	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound tag) {
		super.writeToNBT(tag);
		tag.setInteger("facing", facing);
		tag.setDouble("X", posX);
		tag.setDouble("Y", posY);
		tag.setDouble("Z", posZ);
		return tag;
	}

	@Override
	public void readFromNBT(NBTTagCompound tag) {
		super.readFromNBT(tag);
		this.facing = tag.getInteger("facing");
		this.posX = tag.getDouble("X");
		this.posY = tag.getDouble("Y");
		this.posZ = tag.getDouble("Z");
	}
	
	@Override
	public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) {
		NBTTagCompound tag = pkt.getNbtCompound();
		this.facing = tag.getInteger("facing");
		this.posX = tag.getDouble("X");
		this.posY = tag.getDouble("Y");
		this.posZ = tag.getDouble("Z");
	}
	
	@Override
	@Nullable
	public SPacketUpdateTileEntity getUpdatePacket() {
		NBTTagCompound tag = new NBTTagCompound();
		tag.setInteger("facing", facing);
		tag.setDouble("X", posX);
		tag.setDouble("Y", posY);
		tag.setDouble("Z", posZ);
		return new SPacketUpdateTileEntity(pos, getBlockMetadata(), tag);
	}
	
	@Override
	public NBTTagCompound getUpdateTag() {
		NBTTagCompound tag = super.getUpdateTag();
		tag.setInteger("facing", facing);
		tag.setDouble("X", posX);
		tag.setDouble("Y", posY);
		tag.setDouble("Z", posZ);
		return tag;
	}

	
	
}

 

Possible something simple in the teleportation, i can't see.

 

[GiantNuker]

Player moved wrongly means that you mooved too fast, in the air, etc...(I think)

Make sure you call it on the server thread and not just the client.

[Dustpuppy]

I tried every way now. Just on client side, just on server side and on both sides.

 

[GiantNuker]

Can I see the actual teleportation code?

[Dustpuppy]

	        if (entityIn instanceof EntityPlayerMP) { // should be an EntityPlayerMP; check first just to be sure to avoid crash
			          EntityPlayerMP entityPlayerMP = (EntityPlayerMP)entityIn;
			          entityPlayerMP.connection.setPlayerLocation(x, y, z, entityPlayerMP.rotationYaw, entityPlayerMP.rotationPitch);
			          final EntityPlayerMP dontPlayForThisPlayer = entityPlayerMP;

 

[GiantNuker]

2 minutes ago, Dustpuppy said:

	        if (entityIn instanceof EntityPlayerMP) { // should be an EntityPlayerMP; check first just to be sure to avoid crash
			          EntityPlayerMP entityPlayerMP = (EntityPlayerMP)entityIn;
			          entityPlayerMP.connection.setPlayerLocation(x, y, z, entityPlayerMP.rotationYaw, entityPlayerMP.rotationPitch);
			          final EntityPlayerMP dontPlayForThisPlayer = entityPlayerMP;

 

try "setPositionAndUpdate(x,y,z)" or "setPositionAndRotation(x,y,z,yaw,pitch)"

also put "System.out.println("tpmirror - " + entityPlayerMP.getName()")"

and check the log for "tpmirror - Dustpuppy"

[GiantNuker]

Also, I have been having a problem where "SideOnly(Side.SERVER)" does not work, you already have the Server Player check so don't add it if you have it and try again after you try the above solutions.

[Dustpuppy]

Allways the same result.

 

[Dustpuppy]

The exact same code works without any problems with a right click result of an item. Just within block collision it will not work.

 

[GiantNuker]

I know I have collision code somewhere, lemme find it...

[Draco18s]

11 minutes ago, GiantNuker said:

Also, I have been having a problem where "SideOnly(Side.SERVER)" does not work, you already have the Server Player check so don't add it if you have it and try again after you try the above solutions.

That does not do what you think it does.

 

 

[GiantNuker]

2 minutes ago, GiantNuker said:

I know I have collision code somewhere, lemme find it...

found it:

public void onEntityCollidedWithBlock(World w, BlockPos pos, IBlockState state, Entity entityIn) {
	...
}

paste this into your BLOCK, you have the world and blockpos, so you can find the TE.

Get rid of your other teleportation code.

Edited September 9, 2017 by GiantNuker

[Dustpuppy]

Ok,

this will work now. Just if both blocks are to near and player get bounced between them, i am in trouble.

				if(worldIn.isRemote)
			        if (entityIn instanceof EntityPlayer) { // should be an EntityPlayerMP; check first just to be sure to avoid crash
			          EntityPlayer entityPlayer = (EntityPlayer)entityIn;
			          entityPlayer.setPositionAndRotation(x, y, z, entityPlayer.rotationYaw, entityPlayer.rotationPitch);
			        }

 

Have taken out the sounds, because they where confusing me. Will put in later on again.

 

[GiantNuker]

1 minute ago, Dustpuppy said:

Ok,

this will work now. Just if both blocks are to near and player get bounced between them, i am in trouble.

				if(worldIn.isRemote)
			        if (entityIn instanceof EntityPlayer) { // should be an EntityPlayerMP; check first just to be sure to avoid crash
			          EntityPlayer entityPlayer = (EntityPlayer)entityIn;
			          entityPlayer.setPositionAndRotation(x, y, z, entityPlayer.rotationYaw, entityPlayer.rotationPitch);
			        }

 

Have taken out the sounds, because they where confusing me. Will put in later on again.

 

spit the player out about a block infront of the mirror, just outside of the collision box.

[Dustpuppy]

I do. If the second mirror then is near enough to split the player into it, he bounce that fast, that he will hang between both and the console will be flooded with warnings about wrongly moving.

I have to check, that gamers will not place the mirrors without a big enough gap between.

 

[GiantNuker]

1 minute ago, Dustpuppy said:

I do. If the second mirror then is near enough to split the player into it, he bounce that fast, that he will hang between both and the console will be flooded with warnings about wrongly moving.

I have to check, that gamers will not place the mirrors without a big enough gap between.

 

try moving your mirrors farther apart.

[Dustpuppy]

I do it, but you know the playing kids. If they find out, that it is possible to put two mirrors to near to each other, they will do.

So, i make an if statement, to prevent this.

[GiantNuker]

Hmmm...

try, allong with what you have, adding a ~5 second cooldown.

BTW: sounds like a fun mod!

Edited September 9, 2017 by GiantNuker

[Dustpuppy]

They are working now.

8 hours ago, GiantNuker said:

BTW: sounds like a fun mod!

It is a fun mod, i hope.

That's how it look like when crafting a mirror on the magic altar.

[GiantNuker]

5 hours ago, Dustpuppy said:

They are working now.

It is a fun mod, i hope.

That's how it look like when crafting a mirror on the magic altar.

Nice