Updating to 1.12:

I used to have achievements that got triggered when the player fed an item to an animal (custom Animal).

I looked through all builtin advancement triggers - is there no item right click or entity right click trigger?

 

I didn't find anything, so I've though about making the trigger impossible, and triggering it via code.

Is it possible to trigger advancements via code?

 

If that's also not possible, how do I create my own criterion?

You can create your own triggers:

https://github.com/Draco18s/ReasonableRealism/tree/1.12.1/src/main/java/com/draco18s/hardlib/api/advancement

You still need to register them:

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/hardlib/HardLib.java#L46

But it will take reflection:

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/hardlib/EasyRegistry.java#L210

Thanks!

I have a tutorial on custom triggering of advancements here:http://jabelarminecraft.blogspot.com/p/minecraft-modding-custom-triggers-aka.html

8 hours ago, jabelar said:

I have a tutorial on custom triggering of advancements here:http://jabelarminecraft.blogspot.com/p/minecraft-modding-custom-triggers-aka.html

Btw, your try...catch block can be simplified by using a multicatch.

 

Try {...}

catch(IllegalAccessException | IllegalArgumentException | InvocationTargetException e) { ... }

 

I also don't like the "just copy this class" but for what you're doing (single keyword triggers with no subkeys (e.g. "saw_bird" not "saw_n_birds","count: 10") and how complicated and how similar ICriterion triggers are, I suppose it's fine.

 

I would, however, point out the test() and trigger() portions of the code so that readers know what to look for when they want to do something more complicated.

11 hours ago, Draco18s said:

Btw, your try...catch block can be simplified by using a multicatch.

 

Try {...}

catch(IllegalAccessException | IllegalArgumentException | InvocationTargetException e) { ... }

 

I also don't like the "just copy this class" but for what you're doing (single keyword triggers with no subkeys (e.g. "saw_bird" not "saw_n_birds","count: 10") and how complicated and how similar ICriterion triggers are, I suppose it's fine.

 

I would, however, point out the test() and trigger() portions of the code so that readers know what to look for when they want to do something more complicated.

Thanks for the feedback. Yeah, with tutorials there is a balance in terms of telling people to copy code or not.