[1.10.2] Problems picking up carrots

[Dustpuppy]

Hi,

it sounds silly, if i say that i have problems picking up carrots, but it's real.

I have a farming station. Works like i want, but not with carrots.

Problem is only at pickup of items.

It destroys the block if the crop is in the age to get harvested. Then it picks up all items inside a given box. It works for wheat + seeds, for potatoes, for my custom wheat.

If i plant carrots, it will pick them up and place into the seed slot, but in no other slot. All other crops will work right. First i was thinking, it's because carrots have no extra seeds, like wheat, but potatoes are working too and they also have no extra seed.

 

This is the part of the code, where i pickup the items.

Spoiler

	public void handlePickup() {
		BlockPos centerOfField = getCenterOfField();

		double posX = centerOfField.getX();
		double posY = centerOfField.getY();
		double posZ = centerOfField.getZ();
		if (!worldObj.isRemote) {
			for (Object obj : worldObj.getEntitiesWithinAABBExcludingEntity(null, new AxisAlignedBB(posX - 3, posY - 3, posZ - 3, posX + 3, posY + 3, posZ + 3))) {
				if (obj instanceof EntityItem) 
				{
					EntityItem item = (EntityItem) obj;
					ItemStack pickupItemStack = item.getEntityItem();
					Item pickupItem = pickupItemStack.getItem();

					// go over all output slots
					for (int i = seedSlot; i < slotSize; i++) 
					{
						ItemStack stackSlot = getStackInSlot(i);
						if (stackSlot == null) 
						{
							if (i == seedSlot && (pickupItem == Items.WHEAT_SEEDS	|| pickupItem == Items.CARROT || pickupItem == Items.POTATO || pickupItem == thewizardmod.plants.StartupCommon.wheatSeeds)) 
							{
								setInventorySlotContents(i, pickupItemStack);
								item.setDead();
								break;
							}
							if (i > seedSlot) {
								setInventorySlotContents(i, pickupItemStack);
								item.setDead();
								break;
							}
						} 
						else 
						{
							Item slotItem = stackSlot.getItem();
							if (pickupItem == slotItem) 
							{
								if (stackSlot.stackSize < getInventoryStackLimit()) 
								{
									stackSlot.stackSize += pickupItemStack.stackSize;
									setInventorySlotContents(i, stackSlot);
									item.setDead();
									break;
								}
							}
						}
					}
				}
			}
		}
	}

 

 

[Dustpuppy]

Wait!

The problem is bigger, then expected. It happens with every crop.

If the machine plants carrots, it will pick them up only until the seed slot is full.

If it plants potatoes,  just fills up the seed slot.

Same for wheat and custom wheat.

If i throw what ever on the field, it will be picked up.

 

Edited September 14, 2017 by Dustpuppy

[Dustpuppy]

I'm getting mad. Changed the position of some variables. Now it's working, but not for potatos.

Spoiler

	public void handlePickup() {
		BlockPos centerOfField = getCenterOfField();

		double posX = centerOfField.getX();
		double posY = centerOfField.getY();
		double posZ = centerOfField.getZ();
		if (!worldObj.isRemote) {
			for (Object obj : worldObj.getEntitiesWithinAABBExcludingEntity(null, new AxisAlignedBB(posX - 3, posY - 3, posZ - 3, posX + 3, posY + 3, posZ + 3))) {
				if (obj instanceof EntityItem) 
				{

					// go over all output slots
					for (int i = seedSlot; i < slotSize; i++) 
					{
						EntityItem item = (EntityItem) obj;
						ItemStack pickupItemStack = item.getEntityItem();
						Item pickupItem = pickupItemStack.getItem();
						ItemStack stackSlot = getStackInSlot(i);
						if (stackSlot == null) 
						{
							if (i == seedSlot && (pickupItem == Items.WHEAT_SEEDS	|| pickupItem == Items.CARROT || pickupItem == Items.POTATO || pickupItem == thewizardmod.plants.StartupCommon.wheatSeeds)) 
							{
								setInventorySlotContents(i, pickupItemStack);
								item.setDead();
								break;
							}
							if (i > seedSlot) {
								setInventorySlotContents(i, pickupItemStack);
								item.setDead();
								break;
							}
						} 
						else 
						{
							Item slotItem = stackSlot.getItem();
							if (pickupItem == slotItem) 
							{
								if (stackSlot.stackSize < getInventoryStackLimit()) 
								{
									stackSlot.stackSize += pickupItemStack.stackSize;
									setInventorySlotContents(i, stackSlot);
									item.setDead();
									break;
								}
							}
						}
					}
				}
			}
		}
	}

 

 

[Draco18s]

You do know about getEntitiesWithinAABB(EntityItem.class, AABB) don't you?

[Dustpuppy]

Yes, i know.

Pickup every item, that is within a box. getEntitiesWithinAABB(EntityItem.class, AABB) makes no sense then. That's why i am using getEntitiesWithinAABBExcludingEntity(null ...

I just have to say, that i don't want null picked up, but all other.

 

[Draco18s]

Your post made no sense. None.

[jeffryfisher]

On 9/14/2017 at 0:27 PM, Dustpuppy said:

The problem is bigger, then expected. It happens with every crop.

How much time have you spent stepping through your code in the debugger? Invest an hour or two doing that and then come back with your observations (if you even have any remaining bugs).

Edited September 16, 2017 by jeffryfisher