[1.12] Help with Renderer

[MrDj200]

Hey there o/

 

I finally got a Block Model to work in Minecraft (yay).

But now it looks kinda weird.

 

Here a screenshot: 

  Reveal hidden contents

The lightning looks quite a bit off.

Has someone experienced it/knows a fix?

 

-Dj

[Draco18s]

Post your block class.

[MrDj200]

Block class: https://pastebin.com/8skfgwX1

and the Parent class for my Blocks: https://pastebin.com/nBgKEejZ

 

sry for the delay just had breakfast ^^"

 

 

-Dj

[Busti]

You probably want to put all this on your blocks class:

@Override
@SuppressWarnings("deprecation")
public EnumBlockRenderType getRenderType(IBlockState state) {
    return EnumBlockRenderType.MODEL;
}

@Override
@SuppressWarnings("deprecation")
public boolean isOpaqueCube(IBlockState state) {
    return false;
}

@Override
@SuppressWarnings("deprecation")
public boolean isFullCube(IBlockState state) {
    return false;
}

Edited September 15, 2017 by Busti
a typo

[MrDj200]

Nice, that works!

Thank you very much!

 

Do you happen to know the not deprecated methods?

I have a feeling it'll bork the hell out when I update to a new Forge version in the future.  

 

 

-Dj

Edited September 15, 2017 by MrDj200

[Draco18s]

Please do not use@SuppressWarnings("deprecation")

  On 9/15/2017 at 2:43 PM, MrDj200 said:

Do you happen to know the not deprecated methods?

I have a feeling it'll bork the hell out when I update to a new Forge version in the future. 

Expand  

Deprecated means "do not call" not "do not override." It is safe to override these methods, however if you want to know whether or not a given block has these features, you should call IBlockState.<whatever> instead.

[MrDj200]

  On 9/15/2017 at 3:55 PM, Draco18s said:

Deprecated means "do not call"

Expand  

Yeah, I know ^^. I was told that the probability that Deprecated methods will be removed in the near Future is high, thats why I wanted to know the new variants ^^

 

-Dj

[Draco18s]

  On 9/15/2017 at 3:59 PM, MrDj200 said:

Yeah, I know ^^. I was told that the probability that Deprecated methods will be removed in the near Future is high, thats why I wanted to know the new variants ^^

Expand  

There aren't "new variants"

[MrDj200]

So "deprecated" does not mean "it'll be removed soon, please use a new method instead" ?

 

[Draco18s]

Usually it means "will be removed soon" but Mojang has marked it as deprecated because everything should call the same methods in IBlockState instead (this is the "moved" part of things: the method calls need to point to the new thing).

 

Whether or not they will be removed from the Block class entirely is unclear (and if they are, how would the behaviors be handled?).

[Busti]

  On 9/15/2017 at 4:52 AM, Draco18s said:

Post your block class.

Expand  

Its your 10.000th post, congrats!

I should have removed the @SuppressWarnings("deprecation") annotation.

I use it for convenience, but it might confuse other people.

 

I'll leave it in the post though, so that this conversation still makes sense.