Jump to content

Recommended Posts

Posted
Quote

package com.example.examplemod;

import net.minecraft.block.Block;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.registry.GameRegistry;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraftforge.registries.RegistryBuilder;

@Mod(modid = ExampleMod.MODID, version = ExampleMod.VERSION)
public class ExampleMod {
    public static final String MODID = "examplemod";
    public static final String VERSION = "1.0";
    
    @EventHandler
    public void init(FMLInitializationEvent event) {
        
    }
    
    @EventHandler
    public void preinit(FMLInitializationEvent event) {
        
    }
   
    @SubscribeEvent
    public void registerItems (RegistryEvent.Register<Item> event) {
        event.getRegistry().register(new Item ().setRegistryName("grunkle").setUnlocalizedName("Grunk").setCreativeTab(CreativeTabs.MISC).setRegistryName("C:\\Users\\admin\\Desktop\\modding folder\\src\\main\\resources\\Items\\grunk"));
    }
    
}
 

Quote

@SubscribeEvent
    public void registerItems (RegistryEvent.Register<Item> event) {
        event.getRegistry().register(new Item ().setRegistryName("grunkle").setUnlocalizedName("Grunk").setCreativeTab(CreativeTabs.MISC).setRegistryName("C:\\Users\\admin\\Desktop\\modding folder\\src\\main\\resources\\Items\\grunk"));
}

Ok, so I have been spending all day trying to code in an Item and it seems to work but when I check miscellaneous tab, it just doesn't show up. I don't know what I am doing wrong, no crash reports, nothing. What am I doing wrong? Please help. Thank you :)

Posted

Hey,

 

I also had problems with items.

Sorry to not post a direct answer to you question, but I your code is quite messy(sry)(I'm a total beginner aswell, so maybe I just don't get it yet :/).

Take a look at this: https://wiki.mcjty.eu/modding/index.php/Basic_Item-1.12

 

These tutorials helped me a LOT. 

Here is the link to the complete wiki: https://wiki.mcjty.eu/modding/index.php/Main_Page

 

Hope this helps :) 

 

-Dj

Posted
Quote

@Mod.EventBusSubscriber
    
    @SubscribeEvent
    public static void registerItems (RegistryEvent.Register<Item> event) {
        event.getRegistry().register(new Item ().setRegistryName("grunkle").setUnlocalizedName(ExampleMod.MODID + ".grunk").setCreativeTab(CreativeTabs.MISC));
    }


@Mod.EventBusSubscriber needs to be at the top of the class, before declaration and the subscribe event needs to be a static. Other than that, this is the smallest you can get it and it is good because you don't need to create another class for the items. :) Thanks, you helped me get to understand this

Posted (edited)
7 hours ago, Noxxous said:

.setUnlocalizedName(ExampleMod.MODID + ".grunk")

God what's wrong with you people? Stop monkeycoding.
 

setUnlocalizedName(this.getRegistryName())

Of course you need to move it to a class constructor or smthing, but who the hell would do in-line initialization for every item?

Edited by MrBendelScrolls
typo
Posted
4 hours ago, MrBendelScrolls said:

 


setUnlocalizedName(this.getRegistryName)

Of course you need to move it to a class constructor or smthing,

item.setUnlocalizedName(item.getRegistryName()). Magic.

 

There's nothing wrong with in-lining it, although I do agree about keeping things clean.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • logs too big for one pastebin https://pastebin.com/ZjUGHu3u  https://pastebin.com/RqCUZf3X  https://pastebin.com/6ZPS99nD
    • You probably used jd-gui to open it, didn't you? Nothing wrong with that, I also made that mistake, except that Notch was a smart guy and he obfuscated the code. That's why you only see files called "a", "b", "c" and then a file that combines them all. As I said, use RetroMCP to deobfuscate the code so that you will 100% understand it and be able to navigate it.
    • Decompiling minecraft indev, infdev, alpha, beta or whichever legacy version is really easy. I'm not a plug, I just also got interested in modding legacy versions (Infdev to be specific). Use https://github.com/MCPHackers/RetroMCP-Java Once you install their client and the Zulu Architecture that they say they recommend (or use your own Java). I encountered some problems, so I run it with: "java -jar RetroMCP-Java-CLI.jar". You should run it in a seperate folder (not in downloads), otherwise the files and folders will go all over the place. How to use RetroMCP: Type setup (every time you want change version), copy-paste the version number from their list (they support indev), write "decompile" and done! The code will now be deobfuscated and filenames will be normal, instead of "a", "b" and "c"! Hope I helped you, but I don't expect you to reply, as this discussion is 9 years old! What a piece of history!  
    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.