Posted September 17, 20178 yr Hi, i have an Entity, that picks items from ground and places them into tileentities with inventory. Works, but not with universal buckets. It shows up, that it has an filled universal bucket in hand, but in real the bucket is an empty bucket. This is the part, where i pickup the item from ground. Spoiler public void tryToPickup() { if (!worldObj.isRemote) { for (Object obj : worldObj.getEntitiesWithinAABBExcludingEntity(this, new AxisAlignedBB(posX - 1, posY - 1, posZ - 1, posX + 1, posY + 1, posZ + 1))) { if (obj instanceof EntityItem) { EntityItem item = (EntityItem) obj; ItemStack pickupItemStack = item.getEntityItem(); Item pickupItem = pickupItemStack.getItem(); if(this.getHeldItem(EnumHand.MAIN_HAND) == null) { this.setHeldItem(EnumHand.MAIN_HAND, new ItemStack(pickupItem, pickupItemStack.stackSize)); item.setDead(); } } } } }
September 17, 20178 yr Author It's ok, found it my self. Just changed this this.setHeldItem(EnumHand.MAIN_HAND, new ItemStack(pickupItem, pickupItemStack.stackSize)); to this this.setHeldItem(EnumHand.MAIN_HAND, pickupItemStack); Edited September 17, 20178 yr by Dustpuppy
September 17, 20178 yr Author Now i have another problem. If i put a full universial bucket into my crop farm as fuel, it will be put into the tank, if there's enough space. This also works with a hopper. If i put a full bucket this way (see spoiler). But it will not update the tank if the entity put's the bucket into the slot. If i leave the game then and restart the world, it's updated. Spoiler public void handleTank() { ItemStack inputStack = getStackInSlot(bucketInputSlot); if (inputStack != null) { // Empty buckets are allowed if (inputStack.getItem() == Items.BUCKET) { if (tank.getFluidAmount() - 1000 > 0 && getStackInSlot(bucketInputSlot) == null) { tank.drain(1000, true); decrStackSize(bucketInputSlot, 1); ItemStack bucket = UniversalBucket.getFilledBucket(ForgeModContainer.getInstance().universalBucket, StartupCommon.fluidMagic); setInventorySlotContents(bucketOutputSlot, bucket); } } // It's a forge universal bucket if (inputStack.getUnlocalizedName().compareTo("item.forge.bucketFilled") == 0) { // The fluid in bucket is liquid magic if (FluidUtil.getFluidContained(inputStack).containsFluid(new FluidStack(StartupCommon.fluidMagic, 1000))&& (getStackInSlot(bucketOutputSlot) == null || getStackInSlot(bucketOutputSlot).getItem() == Items.BUCKET)) { if (tank.getFluidAmount() + 1000 <= tank.getCapacity()) { tank.fill(new FluidStack(StartupCommon.fluidMagic, 1000),true); decrStackSize(bucketInputSlot, 1); if (itemStacks[bucketOutputSlot] != null) { itemStacks[bucketOutputSlot].stackSize++; } else { itemStacks[bucketOutputSlot] = new ItemStack(Items.BUCKET); } setInventorySlotContents(bucketOutputSlot,itemStacks[bucketOutputSlot]); } } } markDirty(); } } I fill the slot with the bucket this way from the living entity. Spoiler public void checkMachines() { BlockPos pos = new BlockPos(this.posX, this.posY - 1, this.posZ); if(this.inventoryPos.equals(pos)) { if(this.getHeldItemMainhand() != null) { IFluidHandler fluidHandler = getFluidHandler(worldObj, this.inventoryPos); TileEntity tileEntity = worldObj.getTileEntity(inventoryPos); ItemStack heldStack = this.getHeldItemMainhand(); Item heldItem = heldStack.getItem(); if(tileEntity != null) { if(tileEntity instanceof TileEntityFarmCrops) { TileEntityFarmCrops te = (TileEntityFarmCrops) tileEntity; System.out.println(heldStack.getUnlocalizedName()); if (heldStack.getUnlocalizedName().compareTo("item.forge.bucketFilled") == 0) { // The fluid in bucket is liquid magic if (FluidUtil.getFluidContained(heldStack).containsFluid(new FluidStack(thewizardmod.fluids.StartupCommon.fluidMagic, 1000))) { if(te.getStackInSlot(0) == null) { te.setInventorySlotContents(0, heldStack); this.setHeldItem(EnumHand.MAIN_HAND, null); } } } } } } } } Edited September 17, 20178 yr by Dustpuppy
September 17, 20178 yr Author Here you can see, what i mean. Interaction with player or hopper is ok, but no update with the entity putting a bucket into the slot.
September 17, 20178 yr Author Tile Entity for the crop farm. Spoiler package thewizardmod.FarmCrops; import java.util.Random; import javax.annotation.Nullable; import net.minecraft.block.Block; import net.minecraft.block.BlockCrops; import net.minecraft.entity.item.EntityItem; import net.minecraft.entity.player.EntityPlayer; import net.minecraft.init.Blocks; import net.minecraft.init.Items; import net.minecraft.inventory.IInventory; import net.minecraft.inventory.ISidedInventory; import net.minecraft.inventory.ItemStackHelper; import net.minecraft.item.Item; import net.minecraft.item.ItemDye; import net.minecraft.item.ItemStack; import net.minecraft.nbt.NBTTagCompound; import net.minecraft.nbt.NBTTagList; import net.minecraft.network.NetworkManager; import net.minecraft.network.play.server.SPacketUpdateTileEntity; import net.minecraft.util.EnumFacing; import net.minecraft.util.ITickable; import net.minecraft.util.math.AxisAlignedBB; import net.minecraft.util.math.BlockPos; import net.minecraftforge.common.ForgeModContainer; import net.minecraftforge.fluids.Fluid; import net.minecraftforge.fluids.FluidStack; import net.minecraftforge.fluids.FluidUtil; import net.minecraftforge.fluids.UniversalBucket; import net.minecraftforge.fluids.capability.TileFluidHandler; import net.minecraftforge.fml.relauncher.Side; import net.minecraftforge.fml.relauncher.SideOnly; import thewizardmod.fluids.StartupCommon; public class TileEntityFarmCrops extends TileFluidHandler implements ISidedInventory, ITickable { public final String name = "container.twm_cropfarm.name"; public static final int CAPACITY = 6 * Fluid.BUCKET_VOLUME + 1; public IInventory inventory; public int slotSize = 14; private int bucketInputSlot = 0; private int bucketOutputSlot = 1; private int boneMealSlot = 2; private int seedSlot = 3; public ItemStack itemStacks[] = new ItemStack[slotSize + 1]; private static final int[] SLOTS_TOP = new int[] { 0, 2, 3 }; private static final int[] SLOTS_BOTTOM = new int[] { 1, 4, 5, 6, 7, 8, 9, 10, 11, 12 }; private static final int[] SLOTS_SIDES = new int[] {}; public int facing; private int coolDown = 0; public TileEntityFarmCrops() { tank = new FluidTankWithTile(this, CAPACITY); tank.setFluid(new FluidStack( thewizardmod.fluids.StartupCommon.fluidMagic, 1)); } public void setFacing(int facing) { this.facing = facing; markDirty(); } public int getFacing() { return this.facing; } @Override public NBTTagCompound getUpdateTag() { return writeToNBT(new NBTTagCompound()); } @Nullable @Override public SPacketUpdateTileEntity getUpdatePacket() { return new SPacketUpdateTileEntity(getPos(), 0, getUpdateTag()); } @Override public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) { readFromNBT(pkt.getNbtCompound()); } public void readFromNBT(NBTTagCompound compound) { super.readFromNBT(compound); NBTTagList nbttaglist = compound.getTagList("Items", 10); this.itemStacks = new ItemStack[this.getSizeInventory()]; for (int i = 0; i < nbttaglist.tagCount(); ++i) { NBTTagCompound nbttagcompound = nbttaglist.getCompoundTagAt(i); int j = nbttagcompound.getByte("Slot"); if (j >= 0 && j < this.itemStacks.length) { this.itemStacks[j] = ItemStack .loadItemStackFromNBT(nbttagcompound); } } int amount = compound.getInteger("tankAmount"); if (amount == 0) amount = 1; tank.drainInternal(CAPACITY, true); tank.fill(new FluidStack(thewizardmod.fluids.StartupCommon.fluidMagic, amount), true); this.facing = compound.getInteger("facing"); this.coolDown = compound.getInteger("coolDown"); } public NBTTagCompound writeToNBT(NBTTagCompound compound) { super.writeToNBT(compound); NBTTagList nbttaglist = new NBTTagList(); for (int i = 0; i < this.itemStacks.length; ++i) { if (this.itemStacks[i] != null) { NBTTagCompound nbttagcompound = new NBTTagCompound(); nbttagcompound.setByte("Slot", (byte) i); this.itemStacks[i].writeToNBT(nbttagcompound); nbttaglist.appendTag(nbttagcompound); } } compound.setTag("Items", nbttaglist); compound.setInteger("tankAmount", tank.getFluidAmount()); compound.setInteger("facing", facing); compound.setInteger("coolDown", coolDown); return compound; } @Override public int getSizeInventory() { return this.itemStacks.length; } @Override @Nullable public ItemStack getStackInSlot(int index) { return this.itemStacks[index]; } @Override @Nullable public ItemStack decrStackSize(int index, int count) { return ItemStackHelper.getAndSplit(this.itemStacks, index, count); } @Override @Nullable public ItemStack removeStackFromSlot(int index) { return ItemStackHelper.getAndRemove(this.itemStacks, index); } @Override public void setInventorySlotContents(int index, ItemStack stack) { this.itemStacks[index] = stack; if (stack != null && stack.stackSize > this.getInventoryStackLimit()) { stack.stackSize = this.getInventoryStackLimit(); } this.markDirty(); } @Override public int getInventoryStackLimit() { return 64; } @Override public boolean isUseableByPlayer(EntityPlayer player) { return this.worldObj.getTileEntity(this.pos) != this ? false : player .getDistanceSq((double) this.pos.getX() + 0.5D, (double) this.pos.getY() + 0.5D, (double) this.pos.getZ() + 0.5D) <= 64.0D; } @Override public void openInventory(EntityPlayer player) { } @Override public void closeInventory(EntityPlayer player) { } @Override public boolean isItemValidForSlot(int index, ItemStack itemstack) { if (itemstack != null) { if (index == bucketInputSlot) { // Empty buckets are allowed if (itemstack.getItem() == Items.BUCKET) { return true; } } if (index == seedSlot) { if (itemstack.getItem() == Items.WHEAT_SEEDS || itemstack.getItem() == thewizardmod.plants.StartupCommon.wheatSeeds || itemstack.getItem() == Items.CARROT || itemstack.getItem() == Items.POTATO) { return true; } } if (index == boneMealSlot) { if (itemstack.areItemsEqual(itemstack, new ItemStack(Items.DYE, 1, 15))) { return true; } } } return false; } @Override public void setField(int id, int value) { } @Override public int getFieldCount() { return 0; } @Override public int getField(int id) { return 0; } @Override public void clear() { for (int i = 0; i < this.itemStacks.length; ++i) { this.itemStacks[i] = null; } } @Override public String getName() { return this.name; } @Override public boolean hasCustomName() { return false; } @Override public int[] getSlotsForFace(EnumFacing side) { return side == EnumFacing.DOWN ? SLOTS_BOTTOM : (side == EnumFacing.UP ? SLOTS_TOP : SLOTS_SIDES); } @Override public boolean canInsertItem(int index, ItemStack itemStackIn, EnumFacing direction) { return this.isItemValidForSlot(index, itemStackIn); } @Override public boolean canExtractItem(int index, ItemStack stack, EnumFacing direction) { return true; } public void handleTank() { ItemStack inputStack = getStackInSlot(bucketInputSlot); if (inputStack != null) { // Empty buckets are allowed if (inputStack.getItem() == Items.BUCKET) { if (tank.getFluidAmount() - 1000 > 0 && getStackInSlot(bucketInputSlot) == null) { tank.drain(1000, true); decrStackSize(bucketInputSlot, 1); ItemStack bucket = UniversalBucket.getFilledBucket(ForgeModContainer.getInstance().universalBucket, StartupCommon.fluidMagic); setInventorySlotContents(bucketOutputSlot, bucket); } } // It's a forge universal bucket if (inputStack.getUnlocalizedName().compareTo("item.forge.bucketFilled") == 0) { // The fluid in bucket is liquid magic if (FluidUtil.getFluidContained(inputStack).containsFluid(new FluidStack(StartupCommon.fluidMagic, 1000))&& (getStackInSlot(bucketOutputSlot) == null || getStackInSlot(bucketOutputSlot).getItem() == Items.BUCKET)) { if (tank.getFluidAmount() + 1000 <= tank.getCapacity()) { tank.fill(new FluidStack(StartupCommon.fluidMagic, 1000),true); decrStackSize(bucketInputSlot, 1); if (itemStacks[bucketOutputSlot] != null) { itemStacks[bucketOutputSlot].stackSize++; } else { itemStacks[bucketOutputSlot] = new ItemStack(Items.BUCKET); } setInventorySlotContents(bucketOutputSlot,itemStacks[bucketOutputSlot]); } } } markDirty(); } } public BlockPos getCenterOfField() { BlockPos pos = this.pos; BlockPos centerOfField = null; // Find the center of 9x9 blocks in front switch (this.facing) { case 0: // south centerOfField = pos.south(3).down(); break; case 1: // west centerOfField = pos.west(3).down(); break; case 2: // north centerOfField = pos.north(3).down(); break; case 3: // east centerOfField = pos.east(3).down(); break; } return centerOfField; } public void handleGround() { BlockPos centerOfField = getCenterOfField(); // check if the center is a water block if (worldObj.getBlockState(centerOfField).getBlock() == Blocks.WATER) { // check if space around water block is farm land int x = centerOfField.getX() - 2; int y = centerOfField.getY(); int z = centerOfField.getZ() - 2; for (int i = 0; i < 5; i++) { for (int j = 0; j < 5; j++) { // It will cost 10mB magic fluid to convert grass to // farmland if (tank.getFluidAmount() >= 11) { BlockPos newpos = new BlockPos(x + i, y, z + j); Block block = worldObj.getBlockState(newpos).getBlock(); if (block == Blocks.GRASS) { worldObj.setBlockState(newpos, Blocks.FARMLAND.getDefaultState(), 3); tank.drain(10, true); } } } } } } public void handlePlanting() { BlockPos centerOfField = getCenterOfField(); // check if the center is a water block if (worldObj.getBlockState(centerOfField).getBlock() == Blocks.WATER) { // check if space around water block is farm land int x = centerOfField.getX() - 2; int y = centerOfField.getY(); int z = centerOfField.getZ() - 2; for (int i = 0; i < 5; i++) { for (int j = 0; j < 5; j++) { // It will cost 5mB magic fluid to plant a seed if (tank.getFluidAmount() >= 6) { BlockPos newpos = new BlockPos(x + i, y, z + j); Block block = worldObj.getBlockState(newpos).getBlock(); if (block == Blocks.FARMLAND) { BlockPos plantPos = newpos.up(); if (this.worldObj.isAirBlock(plantPos)) { // check what kind of seed is in seed slot ItemStack seedStack = getStackInSlot(seedSlot); if (seedStack != null) { Item seedType = seedStack.getItem(); if (seedType != null) { Block plantBlock = null; if (seedType == Items.WHEAT_SEEDS) { plantBlock = Blocks.WHEAT; } else if (seedType == thewizardmod.plants.StartupCommon.wheatSeeds) { plantBlock = thewizardmod.plants.StartupCommon.wheatCrop; } else if (seedType == Items.CARROT) { plantBlock = Blocks.CARROTS; } else if (seedType == Items.POTATO) { plantBlock = Blocks.POTATOES; } // finaly let's plant it if (plantBlock != null) { worldObj.setBlockState( plantPos, plantBlock .getDefaultState() .withProperty( BlockCrops.AGE, 0), 3); tank.drain(5, true); decrStackSize(seedSlot, 1); } } } } } } } } } } public void handleHarvesting() { BlockPos centerOfField = getCenterOfField(); // check if the center is a water block if (worldObj.getBlockState(centerOfField).getBlock() == Blocks.WATER) { // check if space around water block is farm land int x = centerOfField.getX() - 2; int y = centerOfField.getY() + 1; int z = centerOfField.getZ() - 2; for (int i = 0; i < 5; i++) { for (int j = 0; j < 5; j++) { // It will cost 5mB magic fluid to harvest a plant if (tank.getFluidAmount() >= 6) { BlockPos newpos = new BlockPos(x + i, y, z + j); Block block = worldObj.getBlockState(newpos).getBlock(); if (block != null) { int state = worldObj .getBlockState(newpos) .getBlock() .getMetaFromState( worldObj.getBlockState(newpos)); if ((block == Blocks.WHEAT || block == thewizardmod.plants.StartupCommon.wheatCrop || block == Blocks.CARROTS || block == Blocks.POTATOES) && state == 7) { worldObj.destroyBlock(newpos, true); tank.drain(5, true); } } } } } } } public void handleFertalizing() { BlockPos centerOfField = getCenterOfField(); Random random = new Random(); // check if the center is a water block if (worldObj.getBlockState(centerOfField).getBlock() == Blocks.WATER) { // check if space around water block is farm land int x = centerOfField.getX() - 2; int y = centerOfField.getY() + 1; int z = centerOfField.getZ() - 2; for (int i = 0; i < 5; i++) { for (int j = 0; j < 5; j++) { // It will cost 5mB magic fluid to use bonemeal if (tank.getFluidAmount() >= 6 && getStackInSlot(boneMealSlot) != null) { BlockPos newpos = new BlockPos(x + i, y, z + j); Block block = worldObj.getBlockState(newpos).getBlock(); if (block != null) { int state = worldObj .getBlockState(newpos) .getBlock() .getMetaFromState( worldObj.getBlockState(newpos)); if ((block == Blocks.WHEAT || block == thewizardmod.plants.StartupCommon.wheatCrop || block == Blocks.CARROTS || block == Blocks.POTATOES) ) { int chance = random.nextInt(100); if(chance == 0) { ItemDye.applyBonemeal(new ItemStack(Items.DYE, 15, 0), worldObj, newpos, null); tank.drain(5, true); decrStackSize(boneMealSlot, 1); } } } } } } } } public void handlePickup() { BlockPos centerOfField = getCenterOfField(); double posX = centerOfField.getX(); double posY = centerOfField.getY(); double posZ = centerOfField.getZ(); if (!worldObj.isRemote) { for (Object obj : worldObj.getEntitiesWithinAABBExcludingEntity(null, new AxisAlignedBB(posX - 3, posY - 3, posZ - 3, posX + 3, posY + 3, posZ + 3))) { if (obj instanceof EntityItem) { EntityItem item = (EntityItem) obj; ItemStack pickupItemStack = item.getEntityItem(); Item pickupItem = pickupItemStack.getItem(); // go over all output slots for (int i = seedSlot; i < slotSize; i++) { ItemStack stackSlot = getStackInSlot(i); if(stackSlot != null && !item.isDead) { Item stackItem = stackSlot.getItem(); if(stackItem == pickupItem) { if(stackSlot.stackSize < getInventoryStackLimit()) { int maxPickupSize = getInventoryStackLimit() - stackSlot.stackSize; if(maxPickupSize < pickupItemStack.stackSize) { stackSlot.stackSize += maxPickupSize; pickupItemStack.stackSize -= maxPickupSize; } else { stackSlot.stackSize += pickupItemStack.stackSize; pickupItemStack.stackSize = 0; } setInventorySlotContents(i, stackSlot); if(pickupItemStack.stackSize <= 0) { item.setDead(); } } } } else if(!item.isDead) { ItemStack newStack = new ItemStack(pickupItem, pickupItemStack.stackSize); setInventorySlotContents(i, newStack); item.setDead(); } } } } } } @Override public void update() { handleTank(); coolDown++; // every second we check everything. It's magic, but not high speed :-) if (coolDown >= 20) { coolDown = 0; // a minimum of 5mB is needed to work if (tank.getFluidAmount() >= 6) { handleGround(); handlePlanting(); handleHarvesting(); handlePickup(); handleFertalizing(); } } } // this function indicates whether container texture should be drawn @SideOnly(Side.CLIENT) public static boolean func_174903_a(IInventory parIInventory) { return true; } } I am using the fluidhandler, but the tank has a gui and i need to handle this too. The zombie will just put buckets into the slot and the tile entity will handle them. It works if a player did it, or buckets are put into it with a hopper. Just no update, if the entity moves puts a bucket into the input slot, until i leav the game and reload it.
September 17, 20178 yr Author Just now, diesieben07 said: Again, stop using IInventory. What else to use? And how?
September 17, 20178 yr Author What's wrong with IInventory? Just because it's older? I will never update to a never version of MC.
September 17, 20178 yr Author I've started learning Java and modding, because i had nothing to do and wanted learn something new. When i am finished, i will give it away and someone else can renew it to a newer version.
September 17, 20178 yr Author And the biggest problem is, that you will find usefull tutorials, with examples for older versions, but not for newer ones. All you get is "look into the source", or "learn java faster" and so on. If someone asked, how to make something, the right way would be to show it with an example.
September 17, 20178 yr Author I've made maps for Enemy Territory, coded a port, for things like real aiming and weapon use in C. Then i've made different programs for Opencomputers in LUA. My 2 guis are still the top used ones there. Then i updated MC from 1.7.10 to 1.10.2 and all the good mods where gone. No witchery, no thaumcraft. But why? Ever think about? I think, the modders have no time and no passion to update for every change in new MC versions. I can understand it. And missing the good old mods is a reason, why so much people still playing 1.7.10. I know, that MC is not the best to learn coding and specialy java, but who will sit at home and starts with "hello world" and useless programs, like a movie database? If you want to learn something, you will do it for something usefull. I am living in the middle of nowhere and weeks of raining are a good reason to do something on the computer, that's better then just playing.
September 19, 20178 yr On 9/17/2017 at 2:28 PM, Dustpuppy said: And the biggest problem is, that you will find usefull tutorials, with examples for older versions, but not for newer ones. All you get is "look into the source", or "learn java faster" and so on. If someone asked, how to make something, the right way would be to show it with an example. That isn't a good attitude. How do you think people who write the tutorials figure it out? No one tells them, they just look at the source and use their Java education to figure things out. Also, if someone already has a tutorial to do exactly what you want to do, then what is the fun in making a mod then? You always will need to figure out a lot for your own mod. Anyway, it isn't nice to expect other people to figure out everything for you. Although people on the forum will certainly try to give you some help, you need to also put in some work yourself. Check out my tutorials here: http://jabelarminecraft.blogspot.com/
September 19, 20178 yr Author Yeah, your right. But if someone ask for a solution of a problem, why telling him to have a look in the original sources and not show him what you did? Possible someone has a source, that would help you to understand something, you can't find out, would you not be happy, if he shows you, how he did? I agree, that you will not learn too much, with copy and paste, but without sources, i could have a look into to see how people solve problems or did several things, i would be not able today to make my own codes. Copy and paste is allways the beginning of coding. Never saw someone starting with a blank editor and making a perfekt mod. A lot of things are just copies of other people sources.
September 19, 20178 yr Quote Copy and paste is allways the beginning of coding. No, that's the beginning of cargo cult programming. True understanding comes from looking at what is already available. You say you want to look at what we did, but how about you look at what Mojang did first? Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.