[SOLVED][1.11.2] Making a Double Plant (2 Block High Flower)

[ModMCdl]

So, I'm trying to implement a flower block that is a Double Plant, and after taking a look at the double plant class to try and figure out how this is done, it's left me with my head spinning. I'm usually able to reverse-engineer classes, but with the amount of variants that are used, I just can't figure out where the specific things I need are implemented. The latest info I can find is for 1.7.10 and I have verified that it doesn't translate over well.

 

Would anyone be willing to help simplify the process of going about this?

Edited October 19, 2017 by ModMCdl

[aw_wolfe]

Well the BlockDoublePlant has a property HALF that tells you if the block represents the UPPER or LOWER block of the 2 block group.  This property is stored in the blockstate.  So when you do a IBlockState state= world.getBlockState(BlockPos);  you can get the  value by  state.getValue(BlockDoublePlant.HALF);

 

The BlockDoublePlant then traps events such as getItemDropped, etc to determine which blockstate is present (UPPER or LOWER) and do appropriate action. i.e. upper should turn to air if the bottom block is destroyed/harvested

 

If you create a new class MyBlockDoublePlant and copy all the code over from BlockDoublePlant (extending BlockBush, implements IGrowable, net.minecraftforge.common.IShearable) then get rid of the variants you don't want, create your own EnumPlantTypes and tweak as needed. Should get you were you want to be. The json file for the blockstate would be similar to the double_rose.json, double_fern.json, etc taking note of the variants 'half=lower', 'half=upper'.

 

In your modblocks, create each variant appropriately with the MyBlockDoublePlant (or whatever you call the class).

 

You would also have to deal with generation in the biomes that you want, but that is next step if you were wanting auto generating plant.

 

[ModMCdl]

  On 10/5/2017 at 10:59 PM, aw_wolfe said:

If you create a new class MyBlockDoublePlant and copy all the code over from BlockDoublePlant (extending BlockBush, implements IGrowable, net.minecraftforge.common.IShearable) then get rid of the variants you don't want, create your own EnumPlantTypes and tweak as needed. Should get you were you want to be. The json file for the blockstate would be similar to the double_rose.json, double_fern.json, etc taking note of the variants 'half=lower', 'half=upper'.

 

Expand  

Would it also be possible to get all of these variables directly from BlockDoublePlant and just reference them in my own mod? Or would I actually need to implement everything in the individual class for my own double plant?

ie. 

public class BlockAplant extends BlockDoublePlant

 

Edited October 6, 2017 by ModMCdl

[Draco18s]

You can absolutely use the IProperties already defined in another class. In fact, it increases inter-mod compatibility!  As any mod that looks at a block and wants to fiddle around with the HALF property only needs to know about the vanilla HALF property and it can fiddle with your plant the same way it fiddles with a vanilla plant.

[ModMCdl]

  On 10/6/2017 at 2:22 AM, Draco18s said:

You can absolutely use the IProperties already defined in another class. In fact, it increases inter-mod compatibility!  As any mod that looks at a block and wants to fiddle around with the HALF property only needs to know about the vanilla HALF property and it can fiddle with your plant the same way it fiddles with a vanilla plant.

Expand  

Alright. So, please, bear with me for a minute here...

I've made my class extend BlockDoublePlant, and everything seems to be working fine. I've got everything working except for the actual model itself. I've 99% verified that it isn't a problem in my .json files, so I must be missing something to override in the class itself, I'm thinking something along the lines of the variants. 

 

BlockClass.java

Blockstates.json

 

Let me know if you need something else.

Edited October 6, 2017 by ModMCdl

[Draco18s]

{ "model": "asphodelplant_bottom" }

 

Unable to load model asphodelplant_bottom in domain minecraft.

 

You're missing your mod ID.

[ModMCdl]

  On 10/6/2017 at 3:27 AM, Draco18s said:

{ "model": "asphodelplant_bottom" }

 

Unable to load model asphodelplant_bottom in domain minecraft.

 

You're missing your mod ID.

Expand  

Oh. I did fix that and it still isn't working. I didn't realize that I uploaded the errored .json. (Updated to fix).

Edited October 6, 2017 by ModMCdl

[aw_wolfe]

You'll also need to have the model json files. (not sure if you do or not). So block/asphodelplant_bottom would be located...assets/modmt/models/block/asphodelplant_bottom.json

 

 

 

 

[ModMCdl]

Yes, I have those. I've been digging around for a while in between editing and adding other parts of the code. I've verified that the .json are set up correctly. Everything is working except the model render. Originally, it was because I was calling on BlockDoubleClass and not defining what variant (sunflower, fern, etc). my new plant was. So. I've gone as far as to recreate my own DoubleBlock class named BlockTwoPlant, and calling upon that instead, only defining one variant (my plant), but for some reason, its still registering the variant I added as undefined. Source below:

 

BlockTwoPlant.java (My version of BlockDoublePlant, almost c+p)

BlockAsphodelPlant.java (My 2-high plant)

[aw_wolfe]

Can you explain what exactly isn't working? 

1) plants not showing up in creativeTabs for you to place during creative?

2) plants not being created during biome creation?

3) plants showing up in creativeTabs, but without proper texture? pink/black squares?

etc...

 

[ModMCdl]

  On 10/6/2017 at 10:23 PM, aw_wolfe said:

Can you explain what exactly isn't working? 

Expand  

That's the problem, everything is working, the .json, the class file, but in the console, its trying to implement variants that are (to the best of my, and my comrades' knowledge), defined. 

 

I ended up writing my own class to handle a two-high plant (see BlockTwoPlant.java) above, and that runs fine, but for some reason, Minecraft/Forge are trying to call upon variants that I didn't implement.

 

The Error:

  Reveal hidden contents

[21:05:55] [Client thread/ERROR] [FML]: Exception loading model for variant modmt:blockasphodelplant#facing=north,half=upper,variant=asphodelplant for blockstate "modmt:blockasphodelplant[facing=north,half=upper,variant=asphodelplant]"
net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model modmt:blockasphodelplant#facing=north,half=upper,variant=asphodelplant with loader VariantLoader.INSTANCE, skipping
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:153) ~[ModelLoaderRegistry.class:?]
    at net.minecraftforge.client.model.ModelLoader.registerVariant(ModelLoader.java:264) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelBakery.loadBlock(ModelBakery.java:153) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.loadBlocks(ModelLoader.java:252) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:159) ~[ModelLoader.class:?]
    at net.minecraft.client.renderer.block.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:122) [SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.Minecraft.init(Minecraft.java:541) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:387) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_131]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_131]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_131]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_131]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_131]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_131]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_131]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_131]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: net.minecraft.client.renderer.block.model.ModelBlockDefinition$MissingVariantException
    at net.minecraft.client.renderer.block.model.ModelBlockDefinition.getVariant(ModelBlockDefinition.java:78) ~[ModelBlockDefinition.class:?]
    at net.minecraftforge.client.model.ModelLoader$VariantLoader.loadModel(ModelLoader.java:1257) ~[ModelLoader$VariantLoader.class:?]
    at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:149) ~[ModelLoaderRegistry.class:?]
    ... 21 more
[21:05:55] [Client thread/FA

 

Edited October 7, 2017 by ModMCdl
Posted wrong error message

[Draco18s]

Your block has 3 properties:

Horizontal Facing (4 values)

HALF (2 values)

PlantType (1 value)

All of this is encodable in 4 bits (you have 8 possible variations: 4 * 2 * 1)

 

Looking at your getMetaFromState method, if the top half of the block is set, the metadata is (8 + Facing). Otherwise it's (plant type).

However if we look at your getStateFromMeta method, we check if the metadata is >= 8, if it is, set HALF to true. Otherwise we decompose the other three bits into a Plant Type.

 

These two methods are not inverse of each other. Your getStateFromMeta discards the FACING property entirely.

 

THEN, ON TOP OF THAT, your json file ignores both the plant type and facing value:

{
    "variants": {
        "half=lower": { "model": "modmt:block/asphodelplant_bottom" },
        "half=upper":    { "model": "modmt:block/asphodelplant_top" }
    }
}

Those are not your only two variants! What about "facing=north,half=upper,variant=asphodelplant"?

Edited October 7, 2017 by Draco18s

[ModMCdl]

  On 10/7/2017 at 1:15 AM, Draco18s said:

Those are not your only two variants! What about "facing=north,half=upper,variant=asphodelplant"?

Expand  

Considering that the .json and the BlockTwoPlant.class were most stripped from the minecraft source, and neither included all of the variants, I didn't think they were necessary. 

 

Note: I did try implementing everything the console spat out at one point, but it didn't help, could you possible just example one for me? .json is still relatively new to me. I had just listed all of the respected variants that were listed but it didn't help.

[Draco18s]

  On 10/7/2017 at 1:20 AM, ModMCdl said:

Considering that the .json and the BlockTwoPlant.class were most stripped from the minecraft source, and neither included all of the variants, I didn't think they were necessary. 

Expand  

Vanilla might (and probably does) use a custom IStateMapper object to strip some properties from needing to be present in the json file.

"It throws an error" is a far cry from "its not needed." If it throws an error either its needed or you did something wrong.

  Quote

Note: I did try implementing everything the console spat out at one point, but it didn't help, could you possible just example one for me? .json is still relatively new to me. I had just listed all of the respected variants that were listed but it didn't help.

Expand  

Take a look at

http://mcforge.readthedocs.io/en/latest/blockstates/forgeBlockstates/#forges-blockstates

Edited October 7, 2017 by Draco18s

[ModMCdl]

  On 10/7/2017 at 1:25 AM, Draco18s said:

Take a look at

Expand  

Oh, that's a nifty little page there... thanks! You, draco, are a lifesaver.

 

 

[ModMCdl]

Alright, so now, I've gotten the models to work. But, I've encountered yet another problem: my flower now longer drops itself (when destroyed or clicked with bonemeal).

 

It was working earlier, and I do not know what I changed to make it not work.

 

BlockTwoPlant.java (my doubleblock class)

BlockAsphodelPlant.java (my flower)

[Draco18s]

return blockasphodelplant$enumplanttype == BlockTwoPlant.EnumPlantType.ASPHODELPLANT ? Items.AIR

"If the current block's plant type is Asphodel, then return air."

[ModMCdl]

  On 10/7/2017 at 3:24 AM, Draco18s said:

return blockasphodelplant$enumplanttype == BlockTwoPlant.EnumPlantType.ASPHODELPLANT ? Items.AIR

"If the current block's plant type is Asphodel, then return air."

Expand  

Lol, jeez. Alright. I didn't realize that. Thanks.

 

However, that doesn't fix the bonemeal issue.

Edited October 7, 2017 by ModMCdl

[aw_wolfe]

what are you looking for the bonemeal to do?  If you want growing plants, your have to incorporate an age property.

Your cangrow..

 

 return blockasphodelplant$enumplanttype != BlockTwoPlant.EnumPlantType.ASPHODELPLANT && blockasphodelplant$enumplanttype != BlockTwoPlant.EnumPlantType.ASPHODELPLANT;

 

looks like it would always return false if plant type is ASPHODELPLANT, which in your case it would be, so cangrow always returns false, so grow is never called.

 

I haven't had my coffee yet, but that's how I'm reading it.

[ModMCdl]

  On 10/7/2017 at 12:38 PM, aw_wolfe said:

what are you looking for the bonemeal to do?

Expand  

I just want it to act like a normal DoublePlant, and drop itself when bonemeal is used. It was working properly before, and I cannot figure out what I did to mess it up.

[ModMCdl]

  On 10/7/2017 at 12:38 PM, aw_wolfe said:

looks like it would always return false if plant type is ASPHODELPLANT, which in your case it would be, so cangrow always returns false, so grow is never called.

Expand  

This was it. By removing that line and setting return true;it now works. Thanks!

[TheRPGAdventurer]

  On 10/7/2017 at 5:35 PM, ModMCdl said:

This was it. By removing that line and setting return true;it now works. Thanks!

Expand  

Also as a suggestion, kindly please edit your first post to change the title so you can have a some sort of mark that this has been solved, like (SOLVED) or [SOLVED] so people have this same problem can tell if this is solved THANKS!

[ModMCdl]

  On 10/9/2017 at 2:42 PM, TheRPGAdventurer said:

kindly please edit your first post to change the title so you can have a some sort of mark that this has been solved, like (SOLVED) or [SOLVED]

Expand  

Done