[1.12.2] [Solved] Event for connect to singlerplayer world, server world

[FireController1847 7]

I'm trying to make a mod that requires me to detect when the Client joins a Singleplayer world, and when the Client joins a Multiplayer world. I've used PlayerLoggedInEvent, and have checked if world.isRemote (that being said, I'm not sure I fully understand what isRemote is, as it was false every time I connected to a singleplayer world and was never true even when connecting to a server), and that works fine for singleplayer worlds. When I connect to a server, though, the event doesn't even seem to be called. Here's the code I've been testing:
 

@SubscribeEvent
  public void onLogin(PlayerLoggedInEvent event) {
  MCDRP.logger.info("WORKING");
  World world = event.player.getEntityWorld();
  if (!world.isRemote) {
    MCDRP.logger.info("World loaded.");
    // Do stuff for singleplayer world
	return;
  }
  MCDRP.logger.info("Server loaded.");
  System.out.println(world.getMinecraftServer().getName());
}

@SubscribeEvent
public void onLogout(PlayerLoggedOutEvent event) {
  // Handle leaving the server / exiting the world
}

 

What events do I use to separate the singleplayer load from the multiplayer connect?

Edited December 3, 2017 by FireController1847

[Draco18s 2365]

1 hour ago, FireController1847 said:

(that being said, I'm not sure I fully understand what isRemote is, as it was false every time I connected to a singleplayer world and was never true even when connecting to a server)

isRemote is the difference between the logical client and the logical server. Even single player there is still a server thread (the Integrated Server) with 1 player connected.

PlayerLoggedIn only fires on the logical server.

[FireController1847 7]

Just now, Draco18s said:

isRemote is the difference between the logical client and the logical server. Even single player there is still a server thread (the Integrated Server) with 1 player connected.

PlayerLoggedIn only fires on the logical server.

Ahh, okay, that makes sense. So now my question is what events would I use to be able to seperate the two? I can use PlayerLoggedInEvent for singleplayer, obviously, as it seems to only happen during singleplayer, but what other event will run for first time login on multiplayer? I can't use WorldEvent.Load, as that fires also on changing dimension (as far as I've read & tested), as well as being unable to fetch the player within that event.

[Draco18s 2365]

1 minute ago, FireController1847 said:

as well as being unable to fetch the player within that event.

If you're on the client you can always get access to the client player: Minecraft.getMinecraft().getPlayer()

[FireController1847 7]

There is no .getPlayer() and .player is null when the event gets called.

 

This also doesn't solve my issue of the PlayerLoggedInEvent not being called when I connect to a server.

Edited November 28, 2017 by FireController1847

[FireController1847 7]

Also, if I were to use WorldEvent.Load, how would I detect if it's a singleplayer world vs a multiplayer world, as it seems the event fires multiple times on the client, as well as having world.isRemote true at one point. Another issue with the WorldEvent.Load is how would I be able to filter out changing dimension? Why can't I just use PlayerLoggedInEvent?

[ArmamentHaki 2]

8 hours ago, FireController1847 said:

There is no .getPlayer() and .player is null when the event gets called.

 

This also doesn't solve my issue of the PlayerLoggedInEvent not being called when I connect to a server.

Of Course .player is null, The player entity is only being constructed on this event or later

[diesieben07 7372]

95% of the time when you want to detect a difference between singleplayer and multiplayer you are doing something wrong.

For the legitimate 5% use-case though, you can detect this using the appropriate subclasses of FMLNetworkEvent.

[FireController1847 7]

Thanks so much! (If you want proof of verification on why I needed this I can link you to the first release of the mod when I release it)

Edited November 28, 2017 by FireController1847

[FireController1847 7]

 Is it possible to get the world and player from the ClientConnectedToServerEvent? Both mc.player and mc.world are null. I need to get the UUID and I want to send a chat message on launch (a client side chat message, I'm making a mostly client side mod).

[diesieben07 7372]

No, you'd have to use WorldEvent.Load for that.

Edited November 28, 2017 by diesieben07

[FireController1847 7]

4 minutes ago, diesieben07 said:

No, you'd have to use WorldEvent.Load for that.

Hmm, okay. That would bring me back to my original question then: 

 

15 hours ago, FireController1847 said:

Also, if I were to use WorldEvent.Load, how would I detect if it's a singleplayer world vs a multiplayer world, as it seems the event fires multiple times on the client, as well as having world.isRemote true at one point. Another issue with the WorldEvent.Load is how would I be able to filter out changing dimension? Why can't I just use PlayerLoggedInEvent?

 

I could work up some kind of contraption to set a variable to true on connect and then disable it after world load, but I just want to see if there's an easier way first

^ While doing so, it turns out that mc.player is also null on the first world load event.

Edited November 28, 2017 by FireController1847

[diesieben07 7372]

I think it's time that you actually reveal what you are trying to do here... This sounds more and more strange.

[FireController1847 7]

As you posted that I was writing this reply! Haha. Here's my entire file of what I've tried. I am making a Discord Rich Presence bot, that when connected to Singleplayer it will show that you're playing singleplayer, and disable the "Ask to join" and "Spectate" buttons, and for a server I want to be able to add "Ask to join" and "Spectate" buttons as well as download the server icon for the rich presence box. To do so, though, I need the UUID of the user and the server IP that way when a user hits the "Ask to join" button it works correctly.

 

Spoiler

@SubscribeEvent
@SideOnly(Side.CLIENT)
public void onLogin(PlayerLoggedInEvent event) {
  MCDRP.logger.info("CLIENT LOGIN EVENT");
  World world = event.player.getEntityWorld();
  String worldName = world.getWorldInfo().getWorldName();
  DiscordRichPresence presence = new DiscordRichPresence();
  presence.startTimestamp = System.currentTimeMillis() / 1000;
  presence.state = "Singeplayer";
  presence.largeImageKey = "unknown";
  presence.largeImageText = worldName;
  presence.smallImageKey = "crafting_small";
  presence.smallImageText = Display.getTitle();
  MCDRP.DRPC.setPresence(presence);
  event.player.sendMessage(new TextComponentString(Reference.MOD_PREFIX + "Now broadcasting your world on "
                                                   + TextFormatting.DARK_AQUA + "Discord" + TextFormatting.RESET + " as " + TextFormatting.GOLD + worldName
                                                   + TextFormatting.RESET + "."));
}

@SubscribeEvent
@SideOnly(Side.CLIENT)
public void connectToServerEvent(ClientConnectedToServerEvent event) {
  ServerData data = Minecraft.getMinecraft().getCurrentServerData();
  if (data == null)
    return; // Disable singleplayer load as that's handled above
  Reference.initialConnect = true;
  DiscordRichPresence presence = new DiscordRichPresence();
  presence.startTimestamp = System.currentTimeMillis() / 1000;
  presence.state = "Multiplayer";
  presence.largeImageKey = "unknown";
  presence.largeImageText = (data.serverMOTD != null ? StringUtils.stripControlCodes(data.serverMOTD) : "Unknown Server");
  presence.smallImageKey = "crafting_small";
  presence.smallImageText = Display.getTitle();
  presence.joinSecret = "";
  MCDRP.DRPC.setPresence(presence);
}

@SubscribeEvent
@SideOnly(Side.CLIENT)
public void onWorldLoad(WorldEvent.Load event) {
  if (Reference.initialConnect == true) {
    System.out.println(event.getWorld()); // Returns world client
    System.out.println(Minecraft.getMinecraft().player); // Returns null
    Reference.initialConnect = false;
    return;
  }
}

@SubscribeEvent
@SideOnly(Side.CLIENT)
public void disconnectFromServerEvent(ClientDisconnectionFromServerEvent event) {
  DiscordRichPresence presence = new DiscordRichPresence();
  presence.state = "Main Menu";
  presence.largeImageKey = "crafting_large";
  presence.largeImageText = Display.getTitle();
  MCDRP.DRPC.setPresence(presence);
}

 

 

 

Edited November 28, 2017 by FireController1847

[FireController1847 7]

Hmmm.. status?

[jabelar 593]

Why don't you use the Minecraft#isSinglePlayer() method?

[FireController1847 7]

I could do that, but that still doesn't solve my "getting the Player & World" issue

[Differentiation 28]

6 hours ago, FireController1847 said:

I could do that, but that still doesn't solve my "getting the Player & World" issue

You mean this?

Minecraft mc = Minecraft.getMinecraft();

EntityPlayer playerIn = mc.thePlayer;
World worldIn = playerIn.world;

 

Edited December 1, 2017 by Differentiation

[FireController1847 7]

15 hours ago, Differentiation said:

You mean this?

Minecraft mc = Minecraft.getMinecraft();

EntityPlayer playerIn = mc.thePlayer;
World worldIn = playerIn.world;

 

Yea, so when I do something like this:

@SubscribeEvent
@SideOnly(Side.CLIENT)
public void connectToServerEvent(ClientConnectedToServerEvent event) {
  ServerData data = Minecraft.getMinecraft().getCurrentServerData();
  if (data == null)
    return; // Disable singleplayer load as that's handled above
  // Handle stuff
  Minecraft.getMinecraft().player // This is null
  Minecraft.getMinecraft().world // This is null
}

Both .player and .world are null on this event, and I need to get the data from the player.

[Draco18s 2365]

That's because the player doesn't exist yet, that event fires before the connection is finalized and the server creates the player in the world and sends the world information to the client.

[FireController1847 7]

2 hours ago, Draco18s said:

That's because the player doesn't exist yet, that event fires before the connection is finalized and the server creates the player in the world and sends the world information to the client.

Hence why I would have my issue. I need an event (or some other way way) that does that exact same thing as ClientConnectedToServerEvent, but AFTER the world and player are set.

Edited December 1, 2017 by FireController1847

[jabelar 593]

I don't understand why you try to handle that event for this.

 

Your stated aim is to show something in a GUI right? So just check at the time you draw the GUI. GUI is client side and will have Minecraft.getMinecraft() instance where you can check it it is single player with the isSinglePlayer() and then get the player and world.

 

Why are you checking before you need the information?

[FireController1847 7]

That's not what I'm doing at all, actually, as seen in this video on my YouTube channel, it explains what I am trying to do. (Read this after watching): As you can see, I need to get the player for the "Ask to Join" buttons and "Spectate" buttons. The reason being is the encrypted code I need to set for Discord is "UUID_MODID_SERVERIP", so I need the user for the UUID. I can get the server data, that's easy. I'm not making a GUI whatsoever.

Edited December 2, 2017 by FireController1847

[FireController1847 7]

Whoops, I send the wrong video haha! Here's the actual explanation: 

 

[jabelar 593]

So your video says you want to make a GUI. Any time you're talking about a button, for spectate or join or whatever, that is a GUI. 

 

Maybe I'm crazy but I think you are saying you want to enable different buttons based on whether the game is multiplayer or single player, and maybe other information. Are you not trying to change buttons?