Jump to content

Recommended Posts

Posted

Is there a reason that Forge's item handler doesn't merge incoming stacks with existing stacks first, but inserts into empty slot first instead? Is it performance?

Posted
27 minutes ago, diesieben07 said:

IItemHandler's insert method is slot based, you explicitly specify the slot you want to insert into. If you want this behavior, you have to implement it externally.

...and much of the container code that exists (e.g. the vanilla wrapper, many mod container's Transfer Stack methods) blindly goes "does this go in slot 0? Slot 1? Slot 2?" until it runs out of things to insert or places TO insert them. Why does it do this blindly? Because programming a blind insertion is easier: you don't have to look at any slot twice in order to guarantee that the insert succeeds.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
14 hours ago, diesieben07 said:

IItemHandler's insert method is slot based, you explicitly specify the slot you want to insert into. If you want this behavior, you have to implement it externally.

Well, I implemented that in my custom handler. But I suppose it wouldn't be accepted in a pull request to Forge? I don't like that when, say, there is a stack in slot 12 with size 24, and a hopper inserts a stack with same item into empty slot 3 just because this slot happened to be found first.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.