[Solved][1.12.2] Tile and Block Material

[Terrails]

I have an fluid tank (with tile and everything), but I was wondering if there is an alternative to this, if getMaterial had a World object, it would be perfect, I could get the tile with it and I wouldn't need to override randomTick. I think its just not efficient, maybe there's another way but I couldn't find it.

Edited December 10, 2017 by Terrails

[Draco18s]

This:

https://gist.github.com/Terrails/60cb566ea175bef4ca92ff5bd246bdb5#file-gistfile1-java-L1

Will never work.

 

You want to get the material for the block based on its state, then you need to provide that state information via getActualState

Edited December 9, 2017 by Draco18s

[Terrails]

what do you mean by that? I know I need to avoid class variables, but I couldn't find another way, since blockMaterial is protected and I couldn't access it from my tile because of that.

[Draco18s]

2 minutes ago, Terrails said:

what do you mean by that? I know I need to avoid class variables, but I couldn't find another way, since blockMaterial is protected and I couldn't access it from my tile because of that.

Blocks are singletons, there exists exactly 1 instance of your block class. All of your blocks would share a reference to the singular TE.

You cannot do this.

@diesieben07 candidate for common problem.

4 minutes ago, Draco18s said:

You want to get the material for the block based on its state, then you need to provide that state information via getActualState

 

Edited December 9, 2017 by Draco18s

[Terrails]

Something similar to Flower Pots getActualState? It gets the tile and then sets the property.

This works in F3 menu, but whenever I use IBlockState#getValue it returns false for that property.

Edited December 10, 2017 by Terrails

[Terrails]

But how can I call it manually in getMaterial? I called it in onBlockActivated method and it worked, but I don't have World and BlockPos in getMaterial

Edited December 10, 2017 by Terrails

[Terrails]

the thing with metadata is to if I have this:

    @Override
    public int getMetaFromState(IBlockState state) {
        return (state.getValue(HAS_WATER) ? 1 : 0);
    }

    @Override
    public IBlockState getStateFromMeta(int meta) {
        return this.getDefaultState().withProperty(HAS_WATER, meta == 1);
    }

and if I use getMetaFromState in getMaterial it will always return 0 because the state in there has its property set to false.

I got an idea by using the tile to change the blockstate and it works.

https://gist.github.com/Terrails/1f569b51977fa72525a256b4fdd7a524

Is that good or can I improve it?

Edited December 10, 2017 by Terrails

[Terrails]

I removed getActualState and have these two, will that will work? (I'm sorry if I don't quite understand it but I never fully understood blockstates and metadata)

7 minutes ago, Terrails said:

 

    @Override
    public int getMetaFromState(IBlockState state) {
        return (state.getValue(HAS_WATER) ? 1 : 0);
    }

    @Override
    public IBlockState getStateFromMeta(int meta) {
        return this.getDefaultState().withProperty(HAS_WATER, meta == 1);
    }

 

 

[Terrails]

Thank you for that explanation, I understand it now.

Edited December 10, 2017 by Terrails