[1.12.2] Entities inside of fluids

[Corey]

I have several fluids defined in my mod, that all work perfectly, except for the fact that entities pass through them as if they were air.  I've been looking at code from other mods with fluids, (IC2 applies potion effects, BC uses entity.setInWeb) but this can't be the "correct" way to do it, right?

 

I've searched for tutorials, and none seem to mention anything about having to code this entity interaction manually, which leads me to believe I may have done something wrong.  Can anyone point me in the right direction?

 

My registration code is fairly straight-forward:

  private static void registerFluidForMetal(final IForgeRegistry<Block> registry, final GradientMetals.Metal metal) {
    final Fluid fluid;
    
    if(FluidRegistry.isFluidRegistered(metal.name)) {
      fluid = FluidRegistry.getFluid(metal.name);
    } else {
      fluid = new Fluid(metal.name, GradientMod.resource("blocks/fluid_" + metal.name), GradientMod.resource("blocks/fluid_" + metal.name + "_flowing"))
          .setDensity(3000)
          .setLuminosity(9)
          .setViscosity(5000)
          .setTemperature((int)(metal.meltTemp + 273.15));
      
      FluidRegistry.registerFluid(fluid);
    }
    
    FluidRegistry.addBucketForFluid(fluid);
  
    final Block block = new BlockMetalFluid(fluid);
    
    if(fluid.getBlock() == null) {
      fluid.setBlock(block);
    }
    
    registry.register(block);
    
    metal.fluid = fluid;
  }

 

And the BlockMetalFluid code is as follows:

public class BlockMetalFluid extends BlockFluidClassic {
  public BlockMetalFluid(final Fluid fluid) {
    super(fluid, GradientBlocks.MATERIAL_LIQUID_METAL);
    this.setRegistryName(fluid.getUnlocalizedName());
    this.setUnlocalizedName(fluid.getUnlocalizedName());
    fluid.setBlock(this);
  }
}

 

[Draco18s]

Entities swimming in water is handled by the entity class(es) and checks specifically for Material.WATER

[Corey]

Thanks, I took a look at the Entity class and see exactly what you're talking about...  For the time being, I'll just switch the material to Material.WATER.

[jabelar]

The fact is that the Forge fluid system doesn't enable any of the behaviors of fluid (drowning due to lack of air, pushing entities according to flow, coloring the world according to the fluid color when submerged, and so forth).

 

The reason for this is that many vanilla classes specifically look for Material.WATER. So the easiest thing to do is to make sure your fluid has Material.WATER. This has some side effects though (map color will look like water) and as a modder you might not want all the behaviors -- like whether a sponge can soak it up, or whether it is swimmable.

 

So I have created some tutorials on how to use events to overcome this and selectively add the fluid behaviors you want. Check out my tutorial here: http://jabelarminecraft.blogspot.com/p/minecraft-modding-custom-fluid-blocks.html

 

I've also submitted a PR to implement this functionality in Forge directly, and it works well but I have some merge conflicts to fix but I've been traveling in Asia due to work and have other family obligations so realistically might not get it updated for another few weeks.

[jabelar]

I've updated my PR, since you're actively working with fluids I'd appreciate you checking it out and making comments. https://github.com/MinecraftForge/MinecraftForge/pull/4619