Jump to content

Recommended Posts

Posted (edited)

Sound plays in singleplayer but not on servers, code: 

package *****;

import java.util.UUID;

import *****.proxy.CommonProxy;

import ibxm.Player;
import net.minecraft.client.Minecraft;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.event.ClientChatReceivedEvent;
import net.minecraftforge.client.event.RenderGameOverlayEvent.Chat;
import net.minecraftforge.client.event.sound.SoundEvent;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.ServerChatEvent;
import net.minecraftforge.event.entity.living.LivingDeathEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@Mod(modid = Main.MOD_ID, name = Main.NAME, version = Main.VERSION)
public class Main {
	public static final String MOD_ID = "zillexcm";
	public static final String NAME = "*****";
	public static final String VERSION = "0.1";
	public String msg;
	
	@Instance
	
	public static Main instance;
	
	@SidedProxy(clientSide = Reference.CLIENT_PROXY_CLASS, serverSide = Reference.SERVER_PROXY_CLASS)
	
	public static CommonProxy proxy;
	
    @Mod.EventHandler
	
	public void init(FMLInitializationEvent event) {
    	MinecraftForge.EVENT_BUS.register(this);
	}
    

    
    
    @SubscribeEvent
    
    public void onDeath(LivingDeathEvent event) {
    	
    	if(event.entity instanceof EntityPlayer) {
    		
    		if(!event.entity.isEntityAlive()) {
    			
                //UUID uid = UUID.fromString("74a1dcea-1946-45a9-a373-5f1b211f4d07");
    			
    			//if(!event.entity.getUniqueID().equals(uid)) {
    				Minecraft.getMinecraft().thePlayer.playSound("zillexcm:sounds.jigglypuff", 5.0F, 1.0F);
    			//}
	
    			// MY's UUID: 74a1dcea-1946-45a9-a373-5f1b211f4d07


    }
    }
    }

}

note: Please help with the UUID as well the mod for some reason only works when it doesn't use it, which is why it is commented out. Also: ***** is hidden for a specific person, its their name.

Edited by Zillex_
Posted (edited)
2 hours ago, diesieben07 said:

How are you testing this? Are you building your mod and testing it in the actual game? If not, are you logged in in your development environment?

testing it by exporting/running in eclipse also can you please tell me where I'm doing the reaching across logical sides error, this is my first mod and I'm more familiar with the bukkit api than the forge one, thanks :D edit: no I'm not logged in in my dev environment 

Edited by Zillex_
Posted
29 minutes ago, Zillex_ said:

please tell me where I'm doing the reaching across logical sides error, this is my first mod

.Here:

3 hours ago, Zillex_ said:

public void onDeath(LivingDeathEvent event) {
    if(event.entity instanceof EntityPlayer) {
        if(!event.entity.isEntityAlive()) {
            Minecraft.getMinecraft().thePlayer.playSound("zillexcm:sounds.jigglypuff", 5.0F, 1.0F);

 

 

That event is fired on the server. Minecraft.getMinecraft() is client-side-only.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)
19 minutes ago, Draco18s said:

.Here:

 

That event is fired on the server. Minecraft.getMinecraft() is client-side-only.

I KNEW IT! continues to wonder what the serverside one is, and the uuid problem

 

Edit: I tried this but didn't work :/ 

event.entity.playSound("zillexcm:sounds.jigglypuff", 5.0F, 1.0F);

 

Edited by Zillex_
Posted
7 minutes ago, Zillex_ said:

Edit: I tried this but didn't work :/ 


event.entity.playSound("zillexcm:sounds.jigglypuff", 5.0F, 1.0F);

 

Sound on the other hand, is also a client side effect. Dollars to doughnuts, that playSound method forwards off to somewhere that does nothing.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
Just now, Draco18s said:

Sound on the other hand, is also a client side effect. Dollars to doughnuts, that playSound method forwards off to somewhere that does nothing.

so, how do I play a sound while on a server? is there a separate method?

Posted

How does the server tell the client anything?

 

Parakeets.

Packets.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)
11 minutes ago, Draco18s said:

How does the server tell the client anything?

 

Parakeets.

Packets.

but, I've seen mods that work on servers but use playSound?

Edit: also thanks for not getting mad at my noob questions lol 

Edit 2: I'd like to note that the mod actually did work on one server

Edited by Zillex_
Posted (edited)
2 hours ago, Zillex_ said:

but, I've seen mods that work on servers but use playSound?

Edit: also thanks for not getting mad at my noob questions lol 

Edit 2: I'd like to note that the mod actually did work on one server

As a summary, you are reaching across logical sides

Packets, like aforementioned, will do the work. You must send a packet to tell the client that it needs to play a sound (using EntityPlayerMP).

For more information about packets, click HERE.

 

However, there is a server-side friendly method to play a sound (which I use all the time instead of sending a packet), which I have put for you below for your convenience.

World worldIn = playerIn.world;

worldIn.playSound(null, playerIn.getPosition(), /* your sound name */, /* your sound category */, 5.0F, 1.0F);

 

I hope I helped. Happy modding!

Edited by Differentiation
Posted
11 hours ago, Differentiation said:

As a summary, you are reaching across logical sides

Packets, like aforementioned, will do the work. You must send a packet to tell the client that it needs to play a sound (using EntityPlayerMP).

For more information about packets, click HERE.

 

However, there is a server-side friendly method to play a sound (which I use all the time instead of sending a packet), which I have put for you below for your convenience.

World worldIn = playerIn.world;

worldIn.playSound(null, playerIn.getPosition(), /* your sound name */, /* your sound category */, 5.0F, 1.0F);

 

I hope I helped. Happy modding!

Hi, thanks for the example it worked perfectly except I'm not sure where you got playerIn from I tried this:

Entity playerIn = event.entity;

but then I got this error:The method playSound(double, double, double, String, float, float, boolean) in the type World is not applicable for the arguments (null, World, String, String, float, float)

 

Thanks for all your help :D

Posted
6 minutes ago, Zillex_ said:

Hi, thanks for the example it worked perfectly except I'm not sure where you got playerIn from I tried this:


Entity playerIn = event.entity;

but then I got this error:The method playSound(double, double, double, String, float, float, boolean) in the type World is not applicable for the arguments (null, World, String, String, float, float)

Hi, no problem.

EntityPlayer is the simplest to get, silly :P

Answer:

EntityPlayer playerIn = (EntityPlayer) event.entity;

 

Posted
14 minutes ago, Differentiation said:

Hi, no problem.

EntityPlayer is the simplest to get, silly :P

Answer:


EntityPlayer playerIn = (EntityPlayer) event.entity;

 

 

Oh, thanks lol, just need two more things 1 I'm getting an error still: The method playSound(double, double, double, String, float, float, boolean) in the type World is not applicable for the arguments (null, BlockPos, String, String, float, float)

 

2: still having that uuid issue my thought was to do this?

UUID playerID = EntityPlayer.getOfflineUUID("Nostos");
if(event.entity.getUniqueID().equals(uid)){
// sound code here
}

Thanks

Posted

EntityPlayer playerIn = (EntityPlayer) event.entity;

World worldIn = playerIn.world;

worldIn.playSound(playerIn, playerIn.getPosition(), /* here you have to put a SoundEvent instance, NOT a String */, SoundCategory.PLAYERS, 5.0F, 1.0F);

Posted
19 minutes ago, Differentiation said:

EntityPlayer playerIn = (EntityPlayer) event.entity;

World worldIn = playerIn.world;

worldIn.playSound(playerIn, playerIn.getPosition(), /* here you have to put a SoundEvent instance, NOT a String */, SoundCategory.PLAYERS, 5.0F, 1.0F);

okay, I'm starting to feel bad for asking all these noob questions but when I register the sound event like this:

ResourceLocation location = new ResourceLocation("zillexcm", "jigglypuff");
SoundEvent soundevent = new SoundEvent(location);

it gives this error: The constructor SoundEvent(ResourceLocation) is undefined

 

again, sorry for all the noob questions

Posted
17 minutes ago, Differentiation said:

I can't help, the only suggestion I will give is to update to a newer version such as 1.10.2.

oh rip, I can't update because Im making this mod for someone

Posted
Just now, diesieben07 said:

Tell that someone to update. Seriously, 1.8 is ancient. At least use 1.8.9.

oh it is 1.8.9 lol I just say 1.8 assuming everyone thinks 1.8.9

Posted
On 12/29/2017 at 8:28 AM, Zillex_ said:

The constructor SoundEvent(ResourceLocation) is undefined

Use your IDE to jump into the class to see what constructors are really available.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

  • 2 weeks later...
Posted
On 12/31/2017 at 0:44 PM, jeffryfisher said:

Use your IDE to jump into the class to see what constructors are really available.

Didn't really help, thanks for the suggestion though.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.