Jump to content

New Inventory Manipulation model


Xhamolk_

Recommended Posts

I've been looking through mods that (like Buildcraft) can manipulate the inventories of the TileEntity's marked as IInventory.

 

It occurred to me that IInventory is simply a static (passive) inventory; this theory was then supported with the fact that vanilla uses IInventory for slot-based containers (GUIs).

But how come there is not an inventory variation designed for dynamic (active) TileEntitys? We can't just assume that all the IInventory implementations are basic chests. This feature is not available on vanilla, and neither through Forge.

 

In order to have active inventories, first there needs to be a standard manipulation model. As of now, every inventory-manipulator mod do it they way they want. Downside of this is that there is not even a guarantee that IInventory.onInventoryChanged() will be called.

 

For that matter, I've created a very small framework that offers the following features:

 

  • A unified inventory-manipulation model.
  • An easy way to insert/extract/count items in inventories. Basically does the dirty work for you.
  • Get's rid of the paradigm that all inventories are slot-based, but still maintains backwards compatibility.
  • Introduces the concept of dynamic inventory, which can decide on what types/amounts of items go in or out
  • Opens the possibilities to create any kind of self-handled inventories, through the ICustomInventory interface.

 

This framework will allow mod-makers (inventory-implementations) to be more creative when creating new types of inventories. Some mods (like factorization) have figured a way to restrict what kinds of items can go inside... but that is not the best way to go.

The benefits for inventory manipulators are pretty much that they no longer need to do the heavy lifting.

 

The possibilities, really, are endless.

Unfortunately, even if this framework is accepted into forge, inventory-manipulators would require to take this model into account. (For testing purposes, I've patched Buildcraft and ThermalExpansion. It works like a charm).

 

Please consider the addition of this framework into forge. I'm open to feedback.

I believe the 1.5 update is a very good time to throw this in, as mods will need to update anyway.

 

---

 

The framework can be found at my GitHub repo: https://github.com/Xhamolk/InventoryAPI

 

For this matter, I have opened a Pull Request on Forge's repo. It can be found here: https://github.com/MinecraftForge/MinecraftForge/pull/435

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Update: I managed to make the item not disappear after crafting, but it doesn't remove any durability. import net.minecraft.enchantment.EnchantmentHelper; import net.minecraft.enchantment.Enchantments; import net.minecraft.enchantment.UnbreakingEnchantment; import net.minecraft.item.Item; import net.minecraft.item.ItemStack; public class NuggetHammer extends Item { private boolean damage; public NuggetHammer(Properties p_i48487_1_) { super(p_i48487_1_); } @Override public int getMaxDamage(ItemStack stack) { return 54 - 1; } public boolean isBarVisible(ItemStack stack) { return false; } @Override public ItemStack getContainerItem(ItemStack stack) { ItemStack copy = stack.copy(); copy.setCount(1); if (!this.damage) return copy; int unbreaking = EnchantmentHelper.getItemEnchantmentLevel(Enchantments.UNBREAKING, stack); for (int i = 0; i < unbreaking; i++) { if (UnbreakingEnchantment.shouldIgnoreDurabilityDrop(stack, unbreaking, random)) return copy; } copy.setDamageValue(stack.getDamageValue() + 1); if (copy.getDamageValue() > stack.getMaxDamage()) return ItemStack.EMPTY; return copy; } }  
    • I cannot find the answer anywhere public static void onPlayerConsumeXp(PlayerXpEvent.PickupXp event){ if(event.getEntity().getMainHandItem().getAllEnchantments().get(*value i need*) != null){ int shorthand = event.getEntity().getMainHandItem().getAllEnchantments().get(*value i need*); I am trying to get my custom enchant inside that *value i need*, I have tried using strings and Enchantments. does not show my enchantment. This is my enchantment class package net.test.tutorialmod.enchants; import net.minecraft.world.entity.EquipmentSlot; import net.minecraft.world.item.enchantment.Enchantment; import net.minecraft.world.item.enchantment.EnchantmentCategory; public class clever extends Enchantment { public clever(Rarity pRarity, EnchantmentCategory pCategory, EquipmentSlot... pApplicableSlots) { super(pRarity, pCategory, pApplicableSlots); } @Override public int getMaxLevel() { return 10; } @Override public int getMinLevel() { return 1; } }  What am i doing wrong?  
    • I had this same issue, it was one of the mods I had installed, some mods seem to break with certain versions of forge and cause others to break as well, trial and error different mods till you find the broken one.  
    • Hi, I'm asking for your help because I can't figure out how to make it so that when an item is crafted on the Crafting Table, it returns the item to the player's inventory and makes the item lose durability. I've tried looking everywhere without success. Like for the crafting of the cake which returns the empty bucket to the player, but also makes it lose durability.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.