TextComponentTranslation retunring original string without translating

[Akxe]

The whole class is annotated with @SideOnly(Side.CLIENT) as whole mod is meant to be client only and compatible with vanilla.

 

I have very simple code trying to figure out how translation works:

EntityPlayer player = Minecraft.getMinecraft().player;
TextComponentTranslation message = new TextComponentTranslation("chat.banana.deathInfo.death.location", player.getPosition())
player.sendMessage(message)

translation en_us.lang (extract)

chat.banana.deathInfo.death.location=You have died at (%1)

I am sure that translation file is located correctly as @LangKey annotation translated config correctly.

 

Link to whole codebase (https://github.com/Akxe/Banana)

Edited January 11, 2018 by Akxe
added sideness

[Akxe]

My bad, the class is annotated with @SideOnly(Side.CLIENT). Will add it to the original post. The whole mod is meant to be client only.

Edited January 11, 2018 by Akxe

[Akxe]

  On 1/11/2018 at 4:16 PM, diesieben07 said:

Why are you using the UUID instead of just comparing the player then?

Expand  

Strangely enough I got EntityPlayerMP from the event, but EntityPlayerSP from Minecraft.getMinecraft().player. 

 

  On 1/11/2018 at 4:16 PM, diesieben07 said:

 And why are you not using LivingDeathEvent?

Expand  

I wanted the items doped, therefor this seemed as most appropriate event.

  On 1/11/2018 at 4:19 PM, diesieben07 said:

Also, just found out your issue:
Do not append siblings to a TextComponentTranslation.

Expand  

I was doing that before and it wasn't working either. Tested once more still no avail. (even updated git)

[Akxe]

I have tried doing

System.out.println(message.getFormattedText());

but only got "chat.banana.deathInfo.death.both§r"... 

[Akxe]

I was really trying not to cross the logical sides... what else should have I done? Also any recommendation, on what should I do next? I’ll probably rewrite the code from scratch. 

[Draco18s]

  On 1/11/2018 at 5:00 PM, Akxe said:

I was really trying not to cross the logical sides... what else should have I done? Also any recommendation, on what should I do next? I’ll probably rewrite the code from scratch. 

Expand  

 

  On 1/11/2018 at 4:04 PM, diesieben07 said:

LivingDropsEvent, the event fires on the server side.

Expand  

 

[jabelar]

  On 1/11/2018 at 5:00 PM, Akxe said:

I was really trying not to cross the logical sides... what else should have I done? Also any recommendation, on what should I do next? I’ll probably rewrite the code from scratch. 

Expand  

You need to get the player based on the event (since the code is for the event if fired on the side it is running on so it is side-safe, in this case on the server). So instead of doing your weird UUID comparison, you first take the entity from the event and check if it is instanceof EntityPlayer. If that is true then you know that the entity was a player (in fact should be an EntityPlayerMP) which you can then do the rest of the stuff like send a message to them.

Edited January 11, 2018 by jabelar

[Akxe]

  On 1/11/2018 at 5:46 PM, jabelar said:

You need to get the player based on the event (since the code is for the event if fired on the side it is running on so it is side-safe, in this case on the server). So instead of doing your weird UUID comparison, you first take the entity from the event and check if it is instanceof EntityPlayer. If that is true then you know that the entity was a player (in fact should be an EntityPlayerMP) which you can then do the rest of the stuff like send a message to them.

Expand  

I was actually doing all of this, but I wanted this mode to be client only (working on vanilla servers). What event is client only, or both sides (so I can use @SideOnly on it)? I actually have annotated the class and event, but it obviously haven’t solved logical sideness. 

[Draco18s]

It will only work if the event is actually even fired client side.

Not all events are.

[Akxe]

Is there a list of them? And their sideness? I was able to pinpoint, I guess most of them, using the tree hierarchy tool in eclipse, but I don’t remember seeing any note on side. 

[Draco18s]

  On 1/11/2018 at 6:06 PM, Akxe said:

Is there a list of them? And their sideness? I was able to pinpoint, I guess most of them, using the tree hierarchy tool in eclipse, but I don’t remember seeing any note on side. 

Expand  

Very rarely. You have to subscribe to them, have the console log which side it thinks its on, and run the code in single player. If you get 2 loggings you'll know it runs on both sides. If you get one, it'll tell you which side its on.

[Akxe]

Amazing, thank you. I'll handle it from here, as for TextComponentTranslation not working, I would assume it is due to server side not being able to translate. Case closed.