Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[SOLVED] [1.10.2] Event in between BreakEvent and HarvestDropsEvent?

Daeruin

By Daeruin
in Modder Support

 Share

Recommended Posts

Daeruin Diamond Finder

Daeruin

Posted
Posted (edited)

I have some block physics functionality that needs to be triggered by a block being broken, but it requires the block to actually be gone. BreakEvent fires when the block will be broken, but right before it's actually deleted, so it's too early for me. The blocks above the broken one won't be able to fall if the block isn't gone yet. HarvestDropsEvent fires after the block is broken, but it only fires if the block is being harvested—so it won't fire if you break a block without a tool of the proper harvest level. It seems like I need something in between the two.

 

I've considered using BreakEvent and just deleting the block myself, but this preempts the block from being harvested. That might be OK. You could imagine the block's drops being crushed by the blocks above it falling. It's probably the better of the two choices. Do you have any other clever ideas, or am I overlooking something?

Edited by Daeruin
Marking as solved
Draco18s Reality Controller

Draco18s

Posted
Posted

Wait, what?

Why aren't you just overriding onNeighborChanged and checking to see if the block below has Material.AIR?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
25 minutes ago, Daeruin said:

So, yeah. I can't override onNeighborChanged in a vanilla block...

Very true, instead you should use the NeighborNotifyEvent.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Daeruin Diamond Finder

Daeruin

Posted
  • Author
Posted

I've tried using NeighborNotifyEvent. What I'm doing here is implementing gravity on a wider selection of blocks. But because I'm dealing with vanilla blocks, the functionality I need is in my custom methods. So notifying the block's neighbors does nothing for me on its own. I still have to manually check each neighboring block to see if they should fall. And as soon as one falls (the original block gets deleted and turned into a falling entity), it triggers another NeighborNotifyEvent where I check all its neighbors again, and I get into nasty infinite loops that cause stack overflows. At least, I think that's what's happening. It's why I moved back to messing with BreakEvent or HarvestDropsEvent.

jabelar Reality Controller

jabelar

Posted
Posted (edited)

Maybe your original assumption  about needing the original breaking block to be gone is wrong. All these events are still fired in the same game tick. So why can't you go ahead and turn all the blocks above into falling blocks even if the block in the break event isn't actually converted yet? And if that is really a problem, then in the break event just create a "list" of BlockPos that should be checked later during the tick?

Edited by jabelar
  • Like 2

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Daeruin Diamond Finder

Daeruin

Posted
  • Author
Posted

Jabelar, you prompted me to review my whole system. You're right. I had forgotten that my method for determining whether a block has sufficient support is based on the assumption that the original block is gone. But I've now changed it so I'm passing in a parameter that includes a list of all blocks that have already been identified as unsuitable for support, including the original. This allows me to use BreakEvent, even though the original block isn't broken yet, which is better because HarvestDropsEvent might miss some blocks.

 

So, thanks for the advice and sorry it ended up not being related to Forge.

jabelar Reality Controller

jabelar

Posted
Posted

Cool

21 hours ago, Daeruin said:

So, thanks for the advice and sorry it ended up not being related to Forge.

Actually this is the type of question that the forum is intended for. You had done your research, hit an issue, and needed advice. As long as people have made a credible attempt at doing something, everyone here is happy to help. And it is "related to Forge" since it is regarding how to make use of the events Forge provided. 

 

But yeah, in general if you hit the end of the road with a given approach, it is often best to go back and rethink things a bit. Glad it worked out.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TEMICCLOL
      TEMICCLOL

      By TEMICCLOL · Posted

      круто
    • BananaRebel
      Dependency Issues with Custom Portal API [Forge]

      By BananaRebel · Posted

      Hi,  I'm using Forge 47.3.0 for Minecraft 1.20.1 I apologise if this is obvious I am very new to modding for Minecraft. I sucessfully made a mod that launched without errors or crashes (without it doing anything) but in order to add the features I need, I need to add "Custom Portal API [Forge]" as a dependency. However no matter the way I've tried to acheive this, it crashes. I am pretty sure it's not the way I'm putting it in the repositories, the dependencies or the way I'm refrencing it, as I've a hundred diffrent combinations and multiple Maven methods. And on all those diffrent variations I still get this crash: pastebin.com/UhumzZCZ Any tips would be invaluable as I've been loosing my mind over this!
    • xLorkin
      Forge 54.1.1 Missing Textures please help

      By xLorkin · Posted

      Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Ugdhar
      My CodeChickenLib mod is giving me an error message and i just can't solve it!

      By Ugdhar · Posted

      Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • MinecraftSearch
      New Website for Quick & Easy Minecraft Info

      By MinecraftSearch · Posted

      Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!

  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept