Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.12.2] DimensionManager dimension registration seems insufficient for uniqueness confirmation

jabelar

By jabelar
in Modder Support

 Share

Recommended Posts

jabelar Reality Controller

jabelar

Posted
Posted

I haven't looked at modding dimensions for a while so maybe I'm missing something.

 

But a DimensionType not only takes an ID, but also a name, a filenaming suffix, etc. When registering a new DimensionType, you can find a free id by calling the DimensionManager.isDimensionRegistered() in a loop. However, there is nothing stopping the use of a duplicate name and/or suffix.

 

It seems that duplicate names or suffix could cause problems, as they are used for things like world saves. Or is the modID somehow used to create uniqueness? Like if I create a dimension type with name "mars", and another mod also did so, does that create a conflict or not?

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

jabelar Reality Controller

jabelar

Posted
  • Author
Posted (edited)
  On 1/21/2018 at 12:07 AM, quadraxis said:

DimensionTypes are not required to have unique IDs. The dimension itself has its own ID.

Expand  

Well I don't think that is fully true as you do have to register both. The registration of DimensionType.register() method is really an extension of the enum (goes through EnumHelper). But the ordinal of the enum isn't really the ID rather it is a field. But in any case if you look at the Call Hierarchy of the DimensionType.getID() and getByID() methods you'll see they are are called all over directly (i.e. not the ID from the DimensionManager registration). Check it out but it seems pretty likely that it needs to be unique.

 

Since both have to be unique and since vanilla+Forge uses the same ID for both you might as well use the same (unique one) for both.

 

Nevertheless, my concern is whether the name and suffix fields of your custom DimensionType also need to be unique. I'm suspecting they do because they are used for world saves among other things.

 

 

Edited by jabelar

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Draco18s Reality Controller

Draco18s

Posted
Posted

You can use the same DimensionType more than once.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

jabelar Reality Controller

jabelar

Posted
  • Author
Posted
  On 1/21/2018 at 2:20 AM, Draco18s said:

You can use the same DimensionType more than once.

Expand  

 

Yes, but that is also not what I'm asking. That wouldn't be a problem.

 

I'm saying is what if I register two different DimensionTypes with different IDs but both have the same name or same suffix. I think that would cause trouble, wouldn't it? 

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TileEntity
      mouseclicked event handler

      By TileEntity · Posted

      You are using Create 6 - some addons are not compatible with it Remove all addons and add these one by one littlecontraptions is mentioned - keep this one removed
    • graciegreen123
      HORROR

      By graciegreen123 · Posted

      HEY
    • violetrose334
      i really need help and i dont know why my game is crashing and i dont want my singleplayer to be deleted

      By violetrose334 · Posted

      omg THANKK U yeah these two was the issues thank u
    • Crossback
      mouseclicked event handler

      By Crossback · Posted

      Different problem now. https://paste.ee/p/iDo8lS35
    • NightAnasazi
      LootItemCondition (when mod is loaded) - showing error "Couldn't parse element"

      By NightAnasazi · Posted

      I would like to have a BoP sapling drop from my block if it is also installed. I think I have done everything and I cannot pinpoint the problem, which is the error in the logs that appears when joining a world:   [Worker-Main-11/ERROR] [ne.mi.co.ForgeHooks/]: Couldn't parse element loot_tables:grasses:blocks/leaves_block com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'biomesoplenty:magic_sapling' My code:   LootItemConditions.CONDITIONS.register(modEventBus); public class LootItemConditions { public static final DeferredRegister<LootItemConditionType> CONDITIONS = DeferredRegister.create(Registries.LOOT_CONDITION_TYPE, Grasses.MOD_ID); public static final RegistryObject<LootItemConditionType> IS_MOD_LOADED = CONDITIONS.register("is_mod_loaded", () -> new LootItemConditionType(new IsModLoaded.ConditionSerializer())); } public class IsModLoaded implements LootItemCondition { private final boolean exists; private final String modID; public IsModLoaded(String modID) { this.exists = ModList.get().isLoaded(modID); this.modID = modID; } @Override public LootItemConditionType getType() { return LootItemConditions.IS_MOD_LOADED.get(); } @Override public boolean test(LootContext context) { return this.exists; } public static LootItemCondition.Builder builder(String modid) { return () -> new IsModLoaded(modid); } public static class ConditionSerializer implements Serializer<IsModLoaded> { @Override public void serialize(JsonObject json, IsModLoaded instance, JsonSerializationContext ctx) { json.addProperty("modid", instance.modID); } @Override public IsModLoaded deserialize(JsonObject json, JsonDeserializationContext ctx) { return new IsModLoaded(GsonHelper.getAsString(json, "modid")); } } } protected LootTable.Builder createLeavesDropsWithModIDCheck(Block selfBlock, Item sapling, Property<?>[] properties, String modIDToCheck, float... chances) { CopyBlockState.Builder blockStateCopyBuilder = CopyBlockState.copyState(selfBlock); for(Property<?> property : properties) { blockStateCopyBuilder.copy(property); } return LootTable.lootTable() .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(LootItem.lootTableItem(selfBlock) .when(HAS_SHEARS_OR_SILK_TOUCH) .apply(blockStateCopyBuilder))) .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionCondition(selfBlock, LootItem.lootTableItem(sapling)) .when(IsModLoaded.builder(modIDToCheck))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, chances)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH)) .withPool(LootPool.lootPool().name("sticks").setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionDecay(selfBlock, LootItem.lootTableItem(Items.STICK). apply(SetItemCountFunction.setCount(UniformGenerator.between(1.0F, 2.0F)))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, NORMAL_LEAVES_STICK_CHANCES)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH))); } I don't know. Am I making a mistake somewhere? Am I forgetting something? Should there be something else?

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept