Purplicious_Cow Posted January 24, 2018 Posted January 24, 2018 Hey Team Forge - I have a question, very similar to this thread at the very bottom of this post answered back in July '17. I have seen crashes like the below reported on Animania reported since its launch 9 months ago. It does appear to be "heap pollution", as you suspect, as it only occurs in multi-mod environments (where at least one of the mods adds other custom entities) and in a server environment. There is nothing in my code that would or could even change the stored value from an Integer to a Boolean (that's just weird). Based on all evidence it is externally created, and can happen to any animal and any parameter. Example crash: https://github.com/capnkirok/animania/files/1652984/crash-2018-01-22_12.33.17-client.txt However, I have no idea of identifying which mods are causing the problem. I saw another discussion about this elsewhere where Vazkii chimed in and said the only real way avoid the issue altogether is to move from Data Parameters to Capabilities. Any suggestions here? I would love to be able to error trap it, but I can't even do that (unless you know a way). Or would you recommend moving to Capabilities? Thx, Purp Quote
Purplicious_Cow Posted January 24, 2018 Author Posted January 24, 2018 Thanks, diesieben07, But I'm not going to do that for modpackers with hundreds of mods. So, to be clear... So you don't recommend using capabilities? Also.. based on your response... what if I am extending some vanilla entities (for instance EntityCow) ... could that be a source of conflict if other mods do the same and add their parameters to an extended class? Quote
Draco18s Posted January 24, 2018 Posted January 24, 2018 (edited) On 1/24/2018 at 4:28 PM, Purplicious_Cow said: But I'm not going to do that for modpackers with hundreds of mods Expand Do it by binary halves: PIck half of the mods (alphabetically works). Doesn't need to be an exact half. Just make sure that Animania stays in each time. Remove those mods. If the problem persists, remove half of what remains. If the problem goes away, put half of the most recently removed mods back. Repeat until adding/removing a single mod causes the problem. This should take no more than 7 iterations for ~100 mods. Edited January 24, 2018 by Draco18s 1 Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Purplicious_Cow Posted January 26, 2018 Author Posted January 26, 2018 On 1/24/2018 at 4:44 PM, diesieben07 said: Yes, I do. But they have a completely different purpose than DataParameters. "You should not use a screwdriver to put a nail into the wall." - "So I should never use screwdrivers?". Expand No, no, I meant, do you think it's a bad idea to use Capabilities to do the same thing that DataParameters are doing. On 1/24/2018 at 4:44 PM, diesieben07 said: Yes. You must only add DataParameters for entities that you create. Otherwise you must implement the data synchronization manually. Expand @diesiben07, thanks for the response. Ok, so it sounds like I have to implement the data synchronization manually. For some reason, I though the entity automatically did this (writeToNBT). How would you recommend I sync manually, using network packets? Finally, I'm going to include one of my entity base classes for the Ferret, which has crashed with this error, just in case I'm doing something really dumb with this and I don't know it (distinct possibility). This one extends EntityTameable (which has its own parameters, of course) package com.animania.common.entities.rodents; import java.util.Random; import java.util.Set; import javax.annotation.Nullable; import com.animania.Animania; import com.animania.common.ModSoundEvents; import com.animania.common.capabilities.CapabilityRefs; import com.animania.common.capabilities.ICapabilityPlayer; import com.animania.common.entities.AnimalContainer; import com.animania.common.entities.AnimaniaAnimal; import com.animania.common.entities.EntityGender; import com.animania.common.entities.ISpawnable; import com.animania.common.entities.amphibians.EntityAmphibian; import com.animania.common.entities.amphibians.EntityFrogs; import com.animania.common.entities.amphibians.EntityToad; import com.animania.common.entities.chickens.EntityChickLeghorn; import com.animania.common.entities.chickens.EntityChickOrpington; import com.animania.common.entities.chickens.EntityChickPlymouthRock; import com.animania.common.entities.chickens.EntityChickRhodeIslandRed; import com.animania.common.entities.chickens.EntityChickWyandotte; import com.animania.common.entities.genericAi.EntityAnimaniaAvoidWater; import com.animania.common.entities.rodents.ai.EntityAIFerretFindFood; import com.animania.common.entities.rodents.ai.EntityAIFindWater; import com.animania.common.entities.rodents.ai.EntityAILookIdleRodent; import com.animania.common.entities.rodents.ai.EntityAIRodentEat; import com.animania.common.entities.rodents.ai.EntityAISwimmingRodents; import com.animania.common.entities.rodents.ai.EntityAITemptRodents; import com.animania.common.entities.rodents.ai.EntityAIWatchClosestFromSide; import com.animania.common.handler.ItemHandler; import com.animania.common.helper.AnimaniaHelper; import com.animania.common.items.ItemEntityEgg; import com.animania.compat.top.providers.entity.TOPInfoProviderRodent; import com.animania.config.AnimaniaConfig; import com.animania.network.client.CapSyncPacket; import com.google.common.collect.Sets; import net.minecraft.block.Block; import net.minecraft.entity.Entity; import net.minecraft.entity.EntityAgeable; import net.minecraft.entity.EntityList; import net.minecraft.entity.EntityLivingBase; import net.minecraft.entity.SharedMonsterAttributes; import net.minecraft.entity.ai.EntityAIAttackMelee; import net.minecraft.entity.ai.EntityAIFollowOwner; import net.minecraft.entity.ai.EntityAIHurtByTarget; import net.minecraft.entity.ai.EntityAILeapAtTarget; import net.minecraft.entity.ai.EntityAINearestAttackableTarget; import net.minecraft.entity.ai.EntityAIPanic; import net.minecraft.entity.ai.EntityAISit; import net.minecraft.entity.ai.EntityAIWanderAvoidWater; import net.minecraft.entity.item.EntityItem; import net.minecraft.entity.monster.EntitySilverfish; import net.minecraft.entity.passive.EntityTameable; import net.minecraft.entity.player.EntityPlayer; import net.minecraft.init.Items; import net.minecraft.init.MobEffects; import net.minecraft.init.SoundEvents; import net.minecraft.item.Item; import net.minecraft.item.ItemStack; import net.minecraft.nbt.NBTTagCompound; import net.minecraft.network.datasync.DataParameter; import net.minecraft.network.datasync.DataSerializers; import net.minecraft.network.datasync.EntityDataManager; import net.minecraft.potion.PotionEffect; import net.minecraft.util.DamageSource; import net.minecraft.util.EnumHand; import net.minecraft.util.EnumParticleTypes; import net.minecraft.util.SoundEvent; import net.minecraft.util.math.BlockPos; import net.minecraft.util.math.MathHelper; import net.minecraft.util.math.RayTraceResult; import net.minecraft.world.World; import net.minecraftforge.fml.common.network.NetworkRegistry; import net.minecraftforge.fml.relauncher.Side; import net.minecraftforge.fml.relauncher.SideOnly; public class EntityFerretBase extends EntityTameable implements TOPInfoProviderRodent, ISpawnable, AnimaniaAnimal { protected static final DataParameter<Boolean> FED = EntityDataManager.<Boolean>createKey(EntityFerretBase.class, DataSerializers.BOOLEAN); protected static final DataParameter<Boolean> WATERED = EntityDataManager.<Boolean>createKey(EntityFerretBase.class, DataSerializers.BOOLEAN); protected static final DataParameter<Boolean> TAMED = EntityDataManager.<Boolean>createKey(EntityFerretBase.class, DataSerializers.BOOLEAN); protected static final DataParameter<Boolean> SITTING = EntityDataManager.<Boolean>createKey(EntityFerretBase.class, DataSerializers.BOOLEAN); protected static final DataParameter<Boolean> RIDING = EntityDataManager.<Boolean>createKey(EntityFerretBase.class, DataSerializers.BOOLEAN); protected static final DataParameter<Boolean> AGE = EntityDataManager.<Boolean>createKey(EntityFerretBase.class, DataSerializers.BOOLEAN); protected static final Set<Item> TEMPTATION_ITEMS = Sets.newHashSet(new Item[] { Items.MUTTON, Items.EGG, ItemHandler.brownEgg, Items.CHICKEN, ItemHandler.rawWyandotteChicken, ItemHandler.rawRhodeIslandRedChicken, ItemHandler.rawRhodeIslandRedChicken, ItemHandler.rawOrpingtonChicken, ItemHandler.rawPrimeChicken }); protected int fedTimer; protected int wateredTimer; protected int happyTimer; protected int tamedTimer; public int blinkTimer; public int eatTimer; public EntityAIRodentEat entityAIEatGrass; protected int damageTimer; protected FerretType type; private int delayCount; public EntityFerretBase(World worldIn) { super(worldIn); this.setSize(.75F, .40F); this.stepHeight = 1.1F; this.fedTimer = AnimaniaConfig.careAndFeeding.feedTimer + this.rand.nextInt(100); this.wateredTimer = AnimaniaConfig.careAndFeeding.waterTimer + this.rand.nextInt(100); this.happyTimer = 60; this.tamedTimer = 120; this.blinkTimer = 70 + this.rand.nextInt(70); this.enablePersistence(); this.delayCount = 5; } @Override protected void initEntityAI() { this.aiSit = new EntityAISit(this); this.tasks.addTask(0, new EntityAISwimmingRodents(this)); if (!AnimaniaConfig.gameRules.ambianceMode) { this.tasks.addTask(2, new EntityAIFindWater(this, 1.0D)); this.tasks.addTask(3, new EntityAIFerretFindFood(this, 1.0D)); } this.tasks.addTask(2, this.aiSit); this.entityAIEatGrass = new EntityAIRodentEat(this); this.tasks.addTask(3, new EntityAILeapAtTarget(this, 0.2F)); this.tasks.addTask(4, new EntityAIAttackMelee(this, 1.0D, true)); this.tasks.addTask(6, new EntityAIFollowOwner(this, 1.0D, 10.0F, 2.0F)); this.tasks.addTask(7, new EntityAIPanic(this, 1.5D)); this.tasks.addTask(8, new EntityAIRodentEat(this)); this.tasks.addTask(9, new EntityAITemptRodents(this, 1.2D, false, EntityFerretBase.TEMPTATION_ITEMS)); this.tasks.addTask(10, this.entityAIEatGrass); this.tasks.addTask(11, new EntityAIWanderAvoidWater(this, 1.2D)); this.tasks.addTask(12, new EntityAIWatchClosestFromSide(this, EntityPlayer.class, 6.0F)); this.tasks.addTask(13, new EntityAILookIdleRodent(this)); this.tasks.addTask(14, new EntityAnimaniaAvoidWater(this)); if (AnimaniaConfig.gameRules.animalsCanAttackOthers) { this.targetTasks.addTask(1, new EntityAINearestAttackableTarget(this, EntityChickLeghorn.class, false)); this.targetTasks.addTask(2, new EntityAINearestAttackableTarget(this, EntityChickOrpington.class, false)); this.targetTasks.addTask(3, new EntityAINearestAttackableTarget(this, EntityChickPlymouthRock.class, false)); this.targetTasks.addTask(4, new EntityAINearestAttackableTarget(this, EntityChickRhodeIslandRed.class, false)); this.targetTasks.addTask(5, new EntityAINearestAttackableTarget(this, EntityChickWyandotte.class, false)); this.targetTasks.addTask(6, new EntityAINearestAttackableTarget(this, EntitySilverfish.class, false)); this.targetTasks.addTask(7, new EntityAINearestAttackableTarget(this, EntityFrogs.class, false)); this.targetTasks.addTask(8, new EntityAINearestAttackableTarget(this, EntityToad.class, false)); this.targetTasks.addTask(9, new EntityAIHurtByTarget(this, true, new Class[0])); } } @Override protected void applyEntityAttributes() { super.applyEntityAttributes(); this.getEntityAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue(8.0D); this.getEntityAttribute(SharedMonsterAttributes.MOVEMENT_SPEED).setBaseValue(0.35D); this.getAttributeMap().registerAttribute(SharedMonsterAttributes.ATTACK_DAMAGE).setBaseValue(0.5D); } @Override protected boolean canDespawn() { return false; } @Override public int getVerticalFaceSpeed() { return this.isSitting() ? 20 : super.getVerticalFaceSpeed(); } @Override protected void consumeItemFromStack(EntityPlayer player, ItemStack stack) { this.setFed(true); this.setOwnerId(player.getPersistentID()); this.setIsTamed(true); this.setTamed(true); this.setSitting(false); this.setFerretSitting(false); this.entityAIEatGrass.startExecuting(); if (!player.capabilities.isCreativeMode) if (stack != ItemStack.EMPTY) stack.setCount(stack.getCount() - 1); this.setInLove(player); } @Override public void setInLove(EntityPlayer player) { this.world.setEntityState(this, (byte) 18); } @Override protected void updateAITasks() { this.eatTimer = this.entityAIEatGrass.getEatingGrassTimer(); super.updateAITasks(); } @Override protected void dropFewItems(boolean hit, int lootlevel) { int happyDrops = 0; if (this.getWatered()) happyDrops++; if (this.getFed()) happyDrops++; ItemStack dropItem; if (AnimaniaConfig.drops.customMobDrops) { String drop = AnimaniaConfig.drops.ferretDrop; dropItem = AnimaniaHelper.getItem(drop); } else dropItem = null; ItemStack dropItem2; String drop2 = AnimaniaConfig.drops.ferretDrop2; dropItem2 = AnimaniaHelper.getItem(drop2); if (happyDrops == 2) { if (dropItem != null) { dropItem.setCount(1 + lootlevel); EntityItem entityitem = new EntityItem(this.world, this.posX + 0.5D, this.posY + 0.5D, this.posZ + 0.5D, dropItem); world.spawnEntity(entityitem); } if (dropItem2 != null) { this.dropItem(dropItem2.getItem(), AnimaniaConfig.drops.ferretDrop2Amount + lootlevel); } } else if (happyDrops == 1) { if (dropItem != null) { dropItem.setCount(1 + lootlevel); EntityItem entityitem = new EntityItem(this.world, this.posX + 0.5D, this.posY + 0.5D, this.posZ + 0.5D, dropItem); world.spawnEntity(entityitem); } if (dropItem2 != null) { this.dropItem(dropItem2.getItem(), AnimaniaConfig.drops.ferretDrop2Amount + lootlevel); } } } @Override public boolean processInteract(EntityPlayer player, EnumHand hand) { ItemStack stack = player.getHeldItem(hand); EntityPlayer entityplayer = player; if (stack != ItemStack.EMPTY && stack.getItem() == Items.WATER_BUCKET && delayCount == 0) { delayCount = 5; this.setWatered(true); this.setInLove(player); return true; } else if (stack == ItemStack.EMPTY && this.isTamed() && !this.isFerretSitting() && !player.isSneaking() && delayCount == 0) { delayCount = 5; this.setFerretSitting(true); this.setSitting(true); this.isJumping = false; this.navigator.clearPathEntity(); return true; } else if (stack == ItemStack.EMPTY && this.isTamed() && this.isFerretSitting() && !player.isSneaking() && delayCount == 0) { delayCount = 5; this.setFerretSitting(false); this.setSitting(false); this.isJumping = false; this.navigator.clearPathEntity(); return true; } else if (stack == ItemStack.EMPTY && this.isTamed() && player.isSneaking() && delayCount == 0) { delayCount = 5; ICapabilityPlayer props = CapabilityRefs.getPlayerCaps(player); if (!props.isCarrying()) { props.setAnimal(this.writeToNBT(new NBTTagCompound())); props.setCarrying(true); props.setType(EntityList.getKey(this).getResourcePath()); this.setDead(); player.swingArm(EnumHand.MAIN_HAND); Animania.network.sendToAllAround(new CapSyncPacket(props, player.getEntityId()), new NetworkRegistry.TargetPoint(player.world.provider.getDimension(), player.getPosition().getX(), player.getPosition().getY(), player.getPosition().getZ(), 64)); return true; } } return super.processInteract(player, hand); } @Override public boolean attackEntityAsMob(Entity entityIn) { boolean flag = entityIn.attackEntityFrom(DamageSource.causeMobDamage(this), 1.0F); if (flag) this.applyEnchantments(this, entityIn); if (entityIn instanceof EntityAmphibian) { this.setFed(true); } // Custom Knockback if (entityIn instanceof EntityPlayer) ((EntityLivingBase) entityIn).knockBack(this, 1, this.posX - entityIn.posX, this.posZ - entityIn.posZ); return flag; } @Override protected void entityInit() { super.entityInit(); this.dataManager.register(EntityFerretBase.FED, Boolean.valueOf(true)); this.dataManager.register(EntityFerretBase.WATERED, Boolean.valueOf(true)); this.dataManager.register(EntityFerretBase.TAMED, Boolean.valueOf(false)); this.dataManager.register(EntityFerretBase.SITTING, Boolean.valueOf(false)); this.dataManager.register(EntityFerretBase.RIDING, Boolean.valueOf(false)); this.dataManager.register(EntityFerretBase.AGE, Boolean.valueOf(false)); } @Override public void writeEntityToNBT(NBTTagCompound compound) { super.writeEntityToNBT(compound); compound.setBoolean("Fed", this.getFed()); compound.setBoolean("Watered", this.getWatered()); compound.setBoolean("IsTamed", this.getIsTamed()); compound.setBoolean("IsSitting", this.isFerretSitting()); compound.setBoolean("Riding", this.isFerretRiding()); compound.setBoolean("Age", this.getAge()); } /** * (abstract) Protected helper method to read subclass entity data from NBT. */ @Override public void readEntityFromNBT(NBTTagCompound compound) { super.readEntityFromNBT(compound); this.setFed(compound.getBoolean("Fed")); this.setWatered(compound.getBoolean("Watered")); this.setIsTamed(compound.getBoolean("IsTamed")); this.setFerretSitting(compound.getBoolean("IsSitting")); this.setFerretRiding(compound.getBoolean("Riding")); this.setAge(compound.getBoolean("Age")); } public boolean getAge() { return this.dataManager.get(EntityFerretBase.AGE).booleanValue(); } public void setAge(boolean age) { this.dataManager.set(EntityFerretBase.AGE, Boolean.valueOf(age)); } @Override public boolean canBeLeashedTo(EntityPlayer player) { return true; } @Override protected SoundEvent getAmbientSound() { int happy = 0; int num = 1; if (this.getWatered()) happy++; if (this.getFed()) happy++; if (happy == 2) num = 10; else if (happy == 1) num = 20; else num = 40; Random rand = new Random(); int chooser = rand.nextInt(num); if (chooser == 0) return ModSoundEvents.ferretLiving1; else if (chooser == 1) return ModSoundEvents.ferretLiving2; else if (chooser == 2) return ModSoundEvents.ferretLiving3; else if (chooser == 3) return ModSoundEvents.ferretLiving4; else if (chooser == 4) return ModSoundEvents.ferretLiving5; else if (chooser == 5) return ModSoundEvents.ferretLiving6; else return null; } @Override protected SoundEvent getHurtSound(DamageSource source) { Random rand = new Random(); int chooser = rand.nextInt(3); if (chooser == 0) return ModSoundEvents.ferretHurt1; else if (chooser == 1) return ModSoundEvents.ferretHurt1; else return null; } @Override protected SoundEvent getDeathSound() { return ModSoundEvents.ferretHurt1; } @Override public void playLivingSound() { SoundEvent soundevent = this.getAmbientSound(); if (soundevent != null) this.playSound(soundevent, this.getSoundVolume() - .3F, this.getSoundPitch()); } @Override protected void playStepSound(BlockPos pos, Block blockIn) { this.playSound(SoundEvents.ENTITY_WOLF_STEP, 0.02F, 1.5F); } private boolean interactRide(EntityPlayer entityplayer) { this.isRemoteMountEntity(entityplayer); return true; } private void isRemoteMountEntity(Entity par1Entity) { if (this.isFerretRiding()) { this.setFerretRiding(true); this.startRiding(par1Entity); } else if (!this.isFerretRiding()) this.dismountRidingEntity(); } @Override public void onLivingUpdate() { if (!this.getAge()) { this.setAge(true); } delayCount--; if (delayCount <= 0) { delayCount = 0; } if (this.isFerretSitting() || this.isRiding()) { if (this.getRidingEntity() != null) this.rotationYaw = this.getRidingEntity().rotationYaw; this.navigator.clearPathEntity(); this.navigator.setSpeed(0); } if (this.world.isRemote) this.eatTimer = Math.max(0, this.eatTimer - 1); if (this.blinkTimer > -1) { this.blinkTimer--; if (this.blinkTimer == 0) this.blinkTimer = 100 + this.rand.nextInt(100); } if (this.fedTimer > -1 && !AnimaniaConfig.gameRules.ambianceMode) { this.fedTimer--; if (this.fedTimer == 0) this.setFed(false); } if (this.wateredTimer > -1) { this.wateredTimer--; if (this.wateredTimer == 0 && !AnimaniaConfig.gameRules.ambianceMode) this.setWatered(false); } boolean fed = this.getFed(); boolean watered = this.getWatered(); if (!fed && !watered) { this.addPotionEffect(new PotionEffect(MobEffects.WEAKNESS, 2, 1, false, false)); if (AnimaniaConfig.gameRules.animalsStarve) { if (this.damageTimer >= AnimaniaConfig.careAndFeeding.starvationTimer) { this.attackEntityFrom(DamageSource.STARVE, 4f); this.damageTimer = 0; } this.damageTimer++; } } else if (!fed || !watered) this.addPotionEffect(new PotionEffect(MobEffects.WEAKNESS, 2, 0, false, false)); if (this.happyTimer > -1) { this.happyTimer--; if (this.happyTimer == 0) { this.happyTimer = 60; if (!this.getFed() && !this.getWatered() && AnimaniaConfig.gameRules.showUnhappyParticles) { double d = this.rand.nextGaussian() * 0.001D; double d1 = this.rand.nextGaussian() * 0.001D; double d2 = this.rand.nextGaussian() * 0.001D; this.world.spawnParticle(EnumParticleTypes.SMOKE_NORMAL, this.posX + this.rand.nextFloat() * this.width - this.width, this.posY + 1.5D + this.rand.nextFloat() * this.height, this.posZ + this.rand.nextFloat() * this.width - this.width, d, d1, d2); } } } if (this.tamedTimer > -1) { this.tamedTimer--; if (this.tamedTimer == 0) { this.tamedTimer = 120; if (this.getIsTamed() && AnimaniaConfig.gameRules.showUnhappyParticles) { double d = this.rand.nextGaussian() * 0.02D; double d1 = this.rand.nextGaussian() * 0.02D; double d2 = this.rand.nextGaussian() * 0.02D; this.world.spawnParticle(EnumParticleTypes.HEART, this.posX + this.rand.nextFloat() * this.width - this.width, this.posY + 1D + this.rand.nextFloat() * this.height, this.posZ + this.rand.nextFloat() * this.width - this.width, d, d1, d2); } } } super.onLivingUpdate(); } @Override @SideOnly(Side.CLIENT) public void handleStatusUpdate(byte id) { if (id == 10) this.eatTimer = 80; else super.handleStatusUpdate(id); } public boolean isFerretSitting() { return this.dataManager.get(EntityFerretBase.SITTING).booleanValue(); } public void setFerretSitting(boolean flag) { if (flag) this.dataManager.set(EntityFerretBase.SITTING, Boolean.valueOf(true)); else this.dataManager.set(EntityFerretBase.SITTING, Boolean.valueOf(false)); } public boolean isFerretRiding() { return this.dataManager.get(EntityFerretBase.RIDING).booleanValue(); } public void setFerretRiding(boolean flag) { if (flag) this.dataManager.set(EntityFerretBase.RIDING, Boolean.valueOf(true)); else this.dataManager.set(EntityFerretBase.RIDING, Boolean.valueOf(false)); } public boolean getFed() { return this.dataManager.get(EntityFerretBase.FED).booleanValue(); } public void setFed(boolean fed) { if (fed) { this.dataManager.set(EntityFerretBase.FED, Boolean.valueOf(true)); this.fedTimer = AnimaniaConfig.careAndFeeding.feedTimer + this.rand.nextInt(100); this.setHealth(this.getHealth() + 1.0F); } else this.dataManager.set(EntityFerretBase.FED, Boolean.valueOf(false)); } public boolean getWatered() { return this.dataManager.get(EntityFerretBase.WATERED).booleanValue(); } public void setWatered(boolean watered) { if (watered) { this.dataManager.set(EntityFerretBase.WATERED, Boolean.valueOf(true)); this.wateredTimer = AnimaniaConfig.careAndFeeding.waterTimer + this.rand.nextInt(100); } else this.dataManager.set(EntityFerretBase.WATERED, Boolean.valueOf(false)); } public boolean getIsTamed() { return this.dataManager.get(EntityFerretBase.TAMED).booleanValue(); } public void setIsTamed(boolean fed) { if (fed) this.dataManager.set(EntityFerretBase.TAMED, Boolean.valueOf(true)); else this.dataManager.set(EntityFerretBase.TAMED, Boolean.valueOf(false)); } @SideOnly(Side.CLIENT) public float getHeadRotationPointY(float p_70894_1_) { return this.eatTimer <= 0 ? 0.0F : this.eatTimer >= 4 && this.eatTimer <= 176 ? 1.0F : this.eatTimer < 4 ? (this.eatTimer - p_70894_1_) / 4.0F : -(this.eatTimer - 80 - p_70894_1_) / 4.0F; } @SideOnly(Side.CLIENT) public float getHeadRotationAngleX(float p_70890_1_) { if (this.eatTimer > 4 && this.eatTimer <= 176) { float f = (this.eatTimer - 4 - p_70890_1_) / 24.0F; return (float) Math.PI / 5F + (float) Math.PI * 7F / 150F * MathHelper.sin(f * 28.7F); } else return this.eatTimer > 0 ? (float) Math.PI / 5F : this.rotationPitch * 0.017453292F; } @Override public EntityFerretBase createChild(EntityAgeable ageable) { return null; } @Override public boolean isBreedingItem(@Nullable ItemStack stack) { return stack != ItemStack.EMPTY && EntityFerretBase.TEMPTATION_ITEMS.contains(stack.getItem()); } @Override public Item getSpawnEgg() { return ItemEntityEgg.ANIMAL_EGGS.get(new AnimalContainer(this.type, EntityGender.NONE)); } @Override public ItemStack getPickedResult(RayTraceResult target) { return new ItemStack(getSpawnEgg()); } @Override public int getPrimaryEggColor() { // TODO Auto-generated method stub return 0; } @Override public int getSecondaryEggColor() { // TODO Auto-generated method stub return 0; } @Override public EntityGender getEntityGender() { return EntityGender.NONE; } } Quote
Draco18s Posted January 26, 2018 Posted January 26, 2018 Capabilities are not automatically synced, as there may be capabilities that the client does not need to know about. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Purplicious_Cow Posted March 17, 2018 Author Posted March 17, 2018 FYI, I went with Lycanite's solution, which is to use try/catch on all attempts to access the data. On failure, it reverts to a default state. It's not ideal, but it prevents crashing in the case there is a conflict. Example: public float getFloatFromDataManager(DataParameter<Float> key) { try { return this.getDataManager().get(key); } catch (Exception e) { return 0; } } Quote
VoiceActorPlays Posted May 12, 2019 Posted May 12, 2019 (edited) Edited May 12, 2019 by VoiceActorPlays Quote
Draco18s Posted May 12, 2019 Posted May 12, 2019 You're in the wrong place. We don't fix problems with using mods, we fix problems with making mods. also: On 5/12/2019 at 1:25 PM, VoiceActorPlays said: WARNING: coremods are present: MalisisCorePlugin (malisiscore-1.12.2-6.4.0.jar) LoadingPlugin (Quark-r1.4-120.jar) ObfuscatePlugin (obfuscate-0.2.6-1.12.2.jar) DynamicSurroundingsCore (DynamicSurroundings-core-1.12.2-3.5.4.3.jar) ColorUtilityCorePlugin (ColorUtility-universal-1.0.4.jar)Contact their authors BEFORE contacting forge Expand Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.