Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.12] BlockState rendering not working

grand_gibus

By grand_gibus
in Modder Support

 Share

Recommended Posts

grand_gibus Tree Puncher

grand_gibus

Posted
Posted

Hello, so I have been working on a double  crop block with two properties, HALF and AGE. It all works great, except when I try to load the models and textures through the blockstate json. I have no idea where to look for a solution to my problem. Even with a json blockstate that should always load only a stone model.

The result in-game:
unknown.png?width=400&height=250

 

maize.json 

{
    "forge_marker": 1,
    "defaults": {
        "model": "stone",
        "uvlock": true
    }
}


BlockMaize.java 

package org.millenaire.block.maya;

import org.millenaire.MillenaireConstants.BlocksConstants;
import org.millenaire.block.global.BlockDoubleCrops;
import org.millenaire.init.MillenaireItems;

import net.minecraft.item.Item;

public class BlockMaize extends BlockDoubleCrops{

	public BlockMaize() {
		
		super();
		
		this.setRegistryName(BlocksConstants.MAIZE.getRegistryName());
		this.setUnlocalizedName(BlocksConstants.MAIZE.getUnlocalizedName());
	
	}
	
    protected Item getSeed()
    {
        return MillenaireItems.maize;
    }

    protected Item getCrop()
    {
        return MillenaireItems.maize;
    }
	
	@Override
	protected int getNewBlockCropHeight() {
		return 4;
	}

}

 

BlockDoubleCrops.java

  

package org.millenaire.block.global;

import java.util.Random;

import net.minecraft.block.BlockCrops;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Blocks;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.IStringSerializable;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.Explosion;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

public abstract class BlockDoubleCrops extends BlockCrops{

	public static final PropertyEnum<BlockDoubleCrops.DoubleCropsHalf> HALF = PropertyEnum.create("half", BlockDoubleCrops.DoubleCropsHalf.class);
	
	public BlockDoubleCrops() {
		
		super();
		
		this.setDefaultState(this.getDefaultState().withProperty(HALF, DoubleCropsHalf.BOTTOM));
	}
	
	@Override
    protected void checkAndDropBlock(World worldIn, BlockPos pos, IBlockState state)
    {
        if (!this.canBlockStay(worldIn, pos, state))
        {
            this.dropBlockAsItem(worldIn, pos, state, 0);
            this.destroyPlant(state, pos, worldIn);
        }
    }
	
	
	@Override
    public boolean canBlockStay(World worldIn, BlockPos pos, IBlockState state)
    {
		BlockPos bottomCrop = this.getBottomCrop(worldIn, state, pos);
		
		if(bottomCrop.equals(pos)){
			IBlockState soil = worldIn.getBlockState(pos.down());
			return (worldIn.getLight(pos) >= 8 || worldIn.canSeeSky(pos)) && soil.getBlock().canSustainPlant(soil, worldIn, pos.down(), net.minecraft.util.EnumFacing.UP, this);
		}else{
			if(pos.getY() - bottomCrop.getY() == 1){
				return true;
			}else{
				return false;
			}
		}
		
     }
	
	public void destroyPlant(IBlockState state, BlockPos pos, World world){
		
		BlockPos bottomCrop = this.getBottomCrop(world, state, pos);
		BlockPos topCrop = this.getAllCrop(world, pos, EnumFacing.UP);
		
		while(topCrop.getY() >= bottomCrop.getY()){
	        world.setBlockState(topCrop, Blocks.AIR.getDefaultState(), 3);
	        topCrop = topCrop.down();
		}
	}
	
	@Override
	public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand){
		
        if (worldIn.getLightFromNeighbors(pos.up()) >= 9)
        {
            int i = this.getAge(state);

            if (i < this.getMaxAge())
            {
                float f = getGrowthChance(this, worldIn, pos);

                if(net.minecraftforge.common.ForgeHooks.onCropsGrowPre(worldIn, pos, state, rand.nextInt((int)(25.0F / f) + 1) == 0))
                {
                	this.tryGrow(worldIn, pos, state, i + 1);
                    net.minecraftforge.common.ForgeHooks.onCropsGrowPost(worldIn, pos, state, worldIn.getBlockState(pos));
                }
            }
        }
	}
	
	@Override
    public void grow(World worldIn, BlockPos pos, IBlockState state)
    {
			
        int i = this.getAge(state) + this.getBonemealAgeIncrease(worldIn);
        int j = this.getMaxAge();

        if (i > j)
        {
            i = j;
        }
        
        this.tryGrow(worldIn, pos, state, i);
    }
	
	public boolean tryGrow(World worldIn, BlockPos pos, IBlockState state, int i){
		
		if(this.isBottomCrop(worldIn, state, pos)){
		
			boolean canGrow = true;
	        
	        if(i >= this.getNewBlockCropHeight()){
	        	
	        	canGrow = false;
	        	
	        	BlockPos topPos = pos.up();
	        	IBlockState topCrop = worldIn.getBlockState(topPos);
	        	
	        	if(topCrop.getBlock() == this){
	        		
	        		worldIn.setBlockState(topPos, this.setAge(topCrop.withProperty(HALF, DoubleCropsHalf.TOP), i), 2);
	        		canGrow = true;
	        		
	        	}else if(worldIn.isAirBlock(topPos)){
	        		
	        		worldIn.setBlockState(topPos, this.setAge(this.getDefaultState().withProperty(HALF, DoubleCropsHalf.TOP), i), 2);
	        		canGrow = true;
	        	}
	        	
	        }
	        
	        if(canGrow){
	        	worldIn.setBlockState(pos, this.setAge(state.withProperty(HALF, DoubleCropsHalf.BOTTOM), i), 2);
	        	
	        }
	        
	        return canGrow;
        
		}
		
		return false;
        
	}
	
	@Override
    public AxisAlignedBB getBoundingBox(IBlockState state, IBlockAccess source, BlockPos pos)
    {
		boolean top = state.getValue(HALF) == DoubleCropsHalf.TOP;
		return new AxisAlignedBB(0.0D, top ? -1.0D : 0.0D, 0.0D, 1.0D, getCropHeightAtAge(state.getValue(AGE)) + (top ? -1.0D : 0.0D), 1.0D);
    }
    
	protected double getCropHeightAtAge(int age){
		return (age + 1) * 0.25D;
	}
	
	@Override
    public void onBlockDestroyedByExplosion(World worldIn, BlockPos pos, Explosion explosionIn)
    {
    	this.destroyPlant(worldIn.getBlockState(pos), pos, worldIn);
    }
    
    @Override
    public void onBlockDestroyedByPlayer(World worldIn, BlockPos pos, IBlockState state)
    {
        this.destroyPlant(state, pos, worldIn);
    }
    
    @Override
    public void getDrops(net.minecraft.util.NonNullList<ItemStack> drops, net.minecraft.world.IBlockAccess world, BlockPos pos, IBlockState state, int fortune)
    {
    	if(this.isBottomCrop(world, state, pos) && state.getValue(HALF) == DoubleCropsHalf.BOTTOM){
    		this.getDoubleCropsDrops(drops, world, pos, state, fortune);
    	}
    }
    
    public void getDoubleCropsDrops(net.minecraft.util.NonNullList<ItemStack> drops, net.minecraft.world.IBlockAccess world, BlockPos pos, IBlockState state, int fortune)
    {
    	super.getDrops(drops, world, pos, state, fortune);
    }
    
	private IBlockState setAge(IBlockState state, int age){
		return state.withProperty(AGE, Integer.valueOf(age));
	}
    
	private boolean isBottomCrop(IBlockAccess world, IBlockState state, BlockPos pos){
		return pos.equals(getBottomCrop(world, state, pos));
	}
	
	public BlockPos getBottomCrop(IBlockAccess world, IBlockState state, BlockPos pos){
		return getAllCrop(world, pos, EnumFacing.DOWN);
	}
	
	public BlockPos getAllCrop(IBlockAccess world, BlockPos pos, EnumFacing direction){
		
		BlockPos bottom = pos;
		
		while(world.getBlockState(bottom.offset(direction)).getBlock() == this){
			bottom = bottom.offset(direction);
		}
		
		return bottom;
		
	}
	
	@Override
    public IBlockState getStateFromMeta(int meta)
    {
		
		DoubleCropsHalf half = DoubleCropsHalf.BOTTOM;
		
		if((meta & 1) > 0){
			half = DoubleCropsHalf.TOP;
		}
		
		meta >>= 1;
		
        return this.withAge(meta).withProperty(HALF, half);
    }

	@Override
    public int getMetaFromState(IBlockState state)
    {
		boolean top = state.getValue(HALF) == DoubleCropsHalf.TOP;
		
		int meta = this.getAge(state);
		
		meta <<= 1;
		
		if(top){
			meta = meta | 1;
		}
		
        return meta;
    }
    
	@Override
    protected BlockStateContainer createBlockState()
    {
        return new BlockStateContainer(this, new IProperty[] {AGE, HALF});
    }
    
	protected abstract int getNewBlockCropHeight();
	
	public enum DoubleCropsHalf implements IStringSerializable{
		
	BOTTOM("bottom"),
	TOP("top");

	private String name;
		
	private DoubleCropsHalf(String name){
		this.name = name;
	}
	
	@Override
	public String getName() {
		return this.name;
	}}
	
}

BlockCrops.java (from minecraft) 

package net.minecraft.block;

import java.util.Random;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyInteger;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.MathHelper;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

public class BlockCrops extends BlockBush implements IGrowable
{
    public static final PropertyInteger AGE = PropertyInteger.create("age", 0, 7);
    private static final AxisAlignedBB[] CROPS_AABB = new AxisAlignedBB[] {new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.125D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.25D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.375D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.5D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.625D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.75D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 0.875D, 1.0D), new AxisAlignedBB(0.0D, 0.0D, 0.0D, 1.0D, 1.0D, 1.0D)};

    protected BlockCrops()
    {
        this.setDefaultState(this.blockState.getBaseState().withProperty(this.getAgeProperty(), Integer.valueOf(0)));
        this.setTickRandomly(true);
        this.setCreativeTab((CreativeTabs)null);
        this.setHardness(0.0F);
        this.setSoundType(SoundType.PLANT);
        this.disableStats();
    }

    public AxisAlignedBB getBoundingBox(IBlockState state, IBlockAccess source, BlockPos pos)
    {
        return CROPS_AABB[((Integer)state.getValue(this.getAgeProperty())).intValue()];
    }

    /**
     * Return true if the block can sustain a Bush
     */
    protected boolean canSustainBush(IBlockState state)
    {
        return state.getBlock() == Blocks.FARMLAND;
    }

    protected PropertyInteger getAgeProperty()
    {
        return AGE;
    }

    public int getMaxAge()
    {
        return 7;
    }

    protected int getAge(IBlockState state)
    {
        return ((Integer)state.getValue(this.getAgeProperty())).intValue();
    }

    public IBlockState withAge(int age)
    {
        return this.getDefaultState().withProperty(this.getAgeProperty(), Integer.valueOf(age));
    }

    public boolean isMaxAge(IBlockState state)
    {
        return ((Integer)state.getValue(this.getAgeProperty())).intValue() >= this.getMaxAge();
    }

    public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        super.updateTick(worldIn, pos, state, rand);

        if (worldIn.getLightFromNeighbors(pos.up()) >= 9)
        {
            int i = this.getAge(state);

            if (i < this.getMaxAge())
            {
                float f = getGrowthChance(this, worldIn, pos);

                if(net.minecraftforge.common.ForgeHooks.onCropsGrowPre(worldIn, pos, state, rand.nextInt((int)(25.0F / f) + 1) == 0))
                {
                    worldIn.setBlockState(pos, this.withAge(i + 1), 2);
                    net.minecraftforge.common.ForgeHooks.onCropsGrowPost(worldIn, pos, state, worldIn.getBlockState(pos));
                }
            }
        }
    }

    public void grow(World worldIn, BlockPos pos, IBlockState state)
    {
        int i = this.getAge(state) + this.getBonemealAgeIncrease(worldIn);
        int j = this.getMaxAge();

        if (i > j)
        {
            i = j;
        }

        worldIn.setBlockState(pos, this.withAge(i), 2);
    }

    protected int getBonemealAgeIncrease(World worldIn)
    {
        return MathHelper.getInt(worldIn.rand, 2, 5);
    }

    protected static float getGrowthChance(Block blockIn, World worldIn, BlockPos pos)
    {
        float f = 1.0F;
        BlockPos blockpos = pos.down();

        for (int i = -1; i <= 1; ++i)
        {
            for (int j = -1; j <= 1; ++j)
            {
                float f1 = 0.0F;
                IBlockState iblockstate = worldIn.getBlockState(blockpos.add(i, 0, j));

                if (iblockstate.getBlock().canSustainPlant(iblockstate, worldIn, blockpos.add(i, 0, j), net.minecraft.util.EnumFacing.UP, (net.minecraftforge.common.IPlantable)blockIn))
                {
                    f1 = 1.0F;

                    if (iblockstate.getBlock().isFertile(worldIn, blockpos.add(i, 0, j)))
                    {
                        f1 = 3.0F;
                    }
                }

                if (i != 0 || j != 0)
                {
                    f1 /= 4.0F;
                }

                f += f1;
            }
        }

        BlockPos blockpos1 = pos.north();
        BlockPos blockpos2 = pos.south();
        BlockPos blockpos3 = pos.west();
        BlockPos blockpos4 = pos.east();
        boolean flag = blockIn == worldIn.getBlockState(blockpos3).getBlock() || blockIn == worldIn.getBlockState(blockpos4).getBlock();
        boolean flag1 = blockIn == worldIn.getBlockState(blockpos1).getBlock() || blockIn == worldIn.getBlockState(blockpos2).getBlock();

        if (flag && flag1)
        {
            f /= 2.0F;
        }
        else
        {
            boolean flag2 = blockIn == worldIn.getBlockState(blockpos3.north()).getBlock() || blockIn == worldIn.getBlockState(blockpos4.north()).getBlock() || blockIn == worldIn.getBlockState(blockpos4.south()).getBlock() || blockIn == worldIn.getBlockState(blockpos3.south()).getBlock();

            if (flag2)
            {
                f /= 2.0F;
            }
        }

        return f;
    }

    public boolean canBlockStay(World worldIn, BlockPos pos, IBlockState state)
    {
        IBlockState soil = worldIn.getBlockState(pos.down());
        return (worldIn.getLight(pos) >= 8 || worldIn.canSeeSky(pos)) && soil.getBlock().canSustainPlant(soil, worldIn, pos.down(), net.minecraft.util.EnumFacing.UP, this);
    }

    protected Item getSeed()
    {
        return Items.WHEAT_SEEDS;
    }

    protected Item getCrop()
    {
        return Items.WHEAT;
    }

    @Override
    public void getDrops(net.minecraft.util.NonNullList<ItemStack> drops, net.minecraft.world.IBlockAccess world, BlockPos pos, IBlockState state, int fortune)
    {
        super.getDrops(drops, world, pos, state, fortune);
        int age = getAge(state);
        Random rand = world instanceof World ? ((World)world).rand : new Random();

        if (age >= getMaxAge())
        {
            int k = 3 + fortune;

            for (int i = 0; i < 3 + fortune; ++i)
            {
                if (rand.nextInt(2 * getMaxAge()) <= age)
                {
                    drops.add(new ItemStack(this.getSeed(), 1, 0));
                }
            }
        }
    }

    /**
     * Spawns this Block's drops into the World as EntityItems.
     */
    public void dropBlockAsItemWithChance(World worldIn, BlockPos pos, IBlockState state, float chance, int fortune)
    {
        super.dropBlockAsItemWithChance(worldIn, pos, state, chance, 0);

        if (false && !worldIn.isRemote) // Forge: NOP all this.
        {
            int i = this.getAge(state);

            if (i >= this.getMaxAge())
            {
                int j = 3 + fortune;

                for (int k = 0; k < j; ++k)
                {
                    if (worldIn.rand.nextInt(2 * this.getMaxAge()) <= i)
                    {
                        spawnAsEntity(worldIn, pos, new ItemStack(this.getSeed()));
                    }
                }
            }
        }
    }

    /**
     * Get the Item that this Block should drop when harvested.
     */
    public Item getItemDropped(IBlockState state, Random rand, int fortune)
    {
        return this.isMaxAge(state) ? this.getCrop() : this.getSeed();
    }

    public ItemStack getItem(World worldIn, BlockPos pos, IBlockState state)
    {
        return new ItemStack(this.getSeed());
    }

    /**
     * Whether this IGrowable can grow
     */
    public boolean canGrow(World worldIn, BlockPos pos, IBlockState state, boolean isClient)
    {
        return !this.isMaxAge(state);
    }

    public boolean canUseBonemeal(World worldIn, Random rand, BlockPos pos, IBlockState state)
    {
        return true;
    }

    public void grow(World worldIn, Random rand, BlockPos pos, IBlockState state)
    {
        this.grow(worldIn, pos, state);
    }

    /**
     * Convert the given metadata into a BlockState for this Block
     */
    public IBlockState getStateFromMeta(int meta)
    {
        return this.withAge(meta);
    }

    /**
     * Convert the BlockState into the correct metadata value
     */
    public int getMetaFromState(IBlockState state)
    {
        return this.getAge(state);
    }

    protected BlockStateContainer createBlockState()
    {
        return new BlockStateContainer(this, new IProperty[] {AGE});
    }
}

 

Any help would be reaaally apreciated, I don't have a clue on whats wrong. Thanks in advance!

Draco18s Reality Controller

Draco18s

Posted
Posted

If that is your blockstate json file, it is incomplete, lacking all of the variants it is supposed to be specifying. 

Also, there should be an error for missing models, which you have not included. 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

grand_gibus Tree Puncher

grand_gibus

Posted
  • Author
Posted

Thanks for the quick answer. I forgot to mention it, but there are no errors in the console, which I don't understand. Also, I put this blockstate json to make sure that it was not a simple json error. Maybe I was wrong. Here is the original json blockstate:

maize.json 

{
    "forge_marker": 1,
    "defaults": {
        "model": "millenaire:maize",
        "textures": {
            "crop": "millenaire:blocks/maize_bottom_stage_0"
        },
        "uvlock": true
    },
    "variants": {
        "age=0,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_0"}},
        "age=1,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_1"}},
        "age=2,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_2"}},
        "age=3,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_3"}},
        "age=4,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_4"}},
        "age=5,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_5"}},
        "age=6,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_6"}},
        "age=7,half=bottom": { "textures": { "crop": "millenaire:blocks/maize_bottom_stage_7"}},
        "age=0,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_0"}},
        "age=1,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_1"}},
        "age=2,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_2"}},
        "age=3,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_3"}},
        "age=4,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_4"}},
        "age=5,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_5"}},
        "age=6,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_6"}},
        "age=7,half=top": { "textures": { "crop": "millenaire:blocks/maize_top_stage_7"}}
    }
}

 

Draco18s Reality Controller

Draco18s

Posted
Posted

I'm not seeing anything obvious.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

larsgerrits Reality Controller

larsgerrits

Posted
Posted

Post the FML log (logs/fml-client-latest.log in your run directory) anyway. If there's a missing block model, there should be an error in the logs.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

grand_gibus Tree Puncher

grand_gibus

Posted
  • Author
Posted

Thanks for your answers. I cant send the logs right now (gonna do later) but I've checked them, and oddly enough I couldnt find any error at all. The meta/state getters seem to be working for me. So I tried to make a vanilla blockstate, and it worked somehow. It would be intrusting to know what didnt work though.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept