Jump to content

Recommended Posts

Posted

I'm working on an item that, when right-clicked, pushes back entities in a circle around the player. However, I want the entity to be pushed back following the same line; right now, the entities are pushed back into the closest corner. Additionally, I don't want the item to push entities through walls(so setting entity.posX/entity.posY directly or using entity::moveTo won't work). Here's the code that I have now:

 

@Override
    public ActionResult<ItemStack> onItemRightClick(ItemStack itemStackIn, World worldIn, EntityPlayer playerIn, EnumHand hand) {
        AxisAlignedBB aabb = playerIn.getEntityBoundingBox().expand(playerIn.posX + range, playerIn.posY + range, playerIn.posZ + range);
        List<Entity> entityList = worldIn.getEntitiesWithinAABBExcludingEntity(playerIn, aabb);
        for (Entity entity : entityList){
            if (entity instanceof EntityLiving){
                rebukeEntityFromPlayer((EntityLiving) entity, playerIn);
            }
        }

        return super.onItemRightClick(itemStackIn, worldIn, playerIn, hand);
    }

    private void rebukeEntityFromPlayer(EntityLiving entity, EntityPlayer player){
        //Creates xy plane with player at center by getting the directional distance between the coords of the entity and the player
        double adjX = entity.posX - player.posX;
        double adjZ = entity.posZ - player.posZ;

        //Creates a triangle to describe the distance between the entity and player
        double startSideA = adjX;
        double startSideB = adjZ;
        double startHyp = Math.sqrt((Math.pow(startSideA, 2) + Math.pow(startSideB, 2)));

        //Scales the triangle to get the point the entity should be pushed to
        double scaleFactor = range/startHyp;
        if(scaleFactor <= 1){return;}//stops spell if entity is already out of target area.
        double scaledSideA = startSideA*scaleFactor;
        double scaledSideB = startSideB*scaleFactor;

        double desiredPosX = adjX + (scaledSideA - startSideA);
        double desiredPosZ = adjZ + (scaledSideB - startSideB);

        if(Math.abs(adjX) < Math.abs(desiredPosX)){
            if(desiredPosX >= 0){
                entity.motionX = 3;
            } else if(desiredPosX < 0){
                entity.motionX = -3;
            }
        }
        if(Math.abs(adjZ) < Math.abs(desiredPosZ)){
            if(desiredPosZ >= 0){
                entity.motionZ = 3;
            } else if(desiredPosZ < 0){
                entity.motionZ = -3;
            }
        }

    }

Additionally, here are some images to help convey my problem: Ideal ScenarioCurrent scenario

Posted

The problem is that you apply a flat value to the entity's motion, rather than a value computed from the angle of attack (Math.sin and Math.cos). "Oh, the entity is 0.1 not far enough away on the X axis! Shove him 3 units away!"

 

Also, drop the Math.pow(startSideA,2) nonsense. That's more expensive than startSideA*startSideA.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
21 minutes ago, Draco18s said:

 a value computed from the angle of attack (Math.sin and Math.cos). 

I'm not 100% sure of what you mean. Do you mean doing something like 

entity.motionX = scaledSideB * Math.cos(Math.acos(startSideA/startHyp));

 

Posted

startSideB is already the distance from the player on the Y axis. Why would you arc-cosine the ratio of side A over the hypotenuse, then cosine the result (resulting in the ratio of side A over the hypotenuse again...)?

 

Christ man, use the ratios of similar triangles.

 

You want the enemy to be 3 units away. You know how far away the enemy is. Divide and multiply.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

maybe this can help you

public boolean itemInteractionForEntity(ItemStack itemstack,EntityPlayer playerIn, EntityLivingBase doel, EnumHand hand) {
		if(!doel.world.isRemote){
		doel.motionY = 0.3;
			if (isgeladen(itemstack.getItemDamage())){
				doel.motionX = (doel.posX - playerIn.posX)*2;
				doel.motionZ = (doel.posZ - playerIn.posZ)*2;
				itemstack.setItemDamage(0);
			}else{
				itemstack.setItemDamage(itemstack.getItemDamage()+1);
			}
		}
		return false;
	}

 

Always looking for new challenges, and happy to help the people where ever I can

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Please read the FAQ and post logs as described there.
    • Upon starting the server I get; [main/ERROR] [minecraft/Main]: Failed to start the minecraft server net.minecraftforge.fml.LoadingFailedException: Loading errors encountered: [     Framework (framework) has failed to load correctly §7java.lang.NoClassDefFoundError: net/minecraft/client/gui/components/toasts/Toast ] I suspect there is a (possibly a few) client-only mods installed on my server. Any help would be appreciated! (Yes I know there are a lot of mods...) Here is the crash log:   https://paste.ee/p/pRz5mhMl#s=0
    • That's basically what the failure does, my apologies for failing to specify.  It just tries again on the next tick until it detects the entities for that chunk are loaded, and then tries to load the entity.  From there it gets into different failure states depending on what goes wrong, but in short, if the entity fails to load once the entity list becomes available, the request is cleared and must be resubmitted by the end user.  There should be few cases where that actually happens. Yes, that is my understanding of forceloading.  That's why on a successful summon, it removes the forceload.  Otherwise it does just leave the chunks loaded long term. Thank you for your help, any knowledge is useful!  I don't often mess with forceloading and my prior experience is 1.16 so I'm also a bit out of my depth haha.
    • I will have to do more research about 1.18 chunk loading. You were unclear about how your code manages with the entity load failure. If you simply used a loop, I suggest submitting a tick task to the next tick which does the same thing, checking if the entities are loaded and if so teleporting the right one else submitting another tick task etc. Also I think forceloading permanently force loads the chunk, and it only starts to unload when you make a subsequent call to mark the chunk as not forceloaded. I may be completely wrong, I dont know much about 1.18, most of my experience is 1.20. Good luck I hope you figure it out after all this time 😅
    • i managed to fix it by reinstalling the modpack and re-add all the extra mods I've had previously.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.