Biomes inverted in world gen

[creepersgalore]

For some reason, my biomes (not the actual biomes, the topblock gen) seems to be inverted. My Code:

for (int i = 0; i < 16; i++) {
	
	for (int j = 0; j < 16; j++) {
		
		//Replace top blocks
		
		int i1 = (x * 16 + i) & 15; //Probably unneccesary, same result as before
		int j1 = (z * 16 + j) & 15; //Probably unneccesary, same result as before
		
		int biomeIndex = j + i * 16;
		
		Biome biome = biomesIn[biomeIndex];
		
		int groundY = findGroundY(primer, i1, j1);
		
		if (groundY > 0) {
			
			primer.setBlockState(i1, groundY, j1, biome.topBlock);
			
		}
		
	}
	
}

The calling method:

public Chunk generateChunk(int x, int z) {
	
	this.chunkX = x;
	this.chunkZ = z;
	this.rand.setSeed((long) x * 341873128712L + (long) z * 132897987541L);
	ChunkPrimer chunkprimer = new ChunkPrimer();
	this.setBlocksInChunk(x, z, chunkprimer);
	this.biomesForGeneration = this.worldObj.getBiomeProvider().getBiomes(this.biomesForGeneration, x * 16, z * 16, 16, 16);
	this.replaceBiomeBlocks(x, z, chunkprimer, this.biomesForGeneration);
	
	Chunk chunk = new Chunk(this.worldObj, chunkprimer, x, z);
	byte[] abyte = chunk.getBiomeArray();
	
	for (int i = 0; i < abyte.length; ++i) {
		
		abyte[i] = (byte) Biome.getIdForBiome(this.biomesForGeneration[i]);
		
	}
	
	chunk.generateSkylightMap();
	return chunk;
	
}

Before doing this, I looked at ChunkGeneratorOverworld, and almost-kind-of copied some of the code (the this.worldObj.getBiomeProvider... in generateChunk() and the replaceBiomeBlocks() method). That made it from no top blocks to strange top blocks, my current state.

[jabelar]

I'm not sure exactly what you mean by inverted. But why not just use regular debug methods (either run Eclipse in debugger mode or print out to console) to track what the Y-value and top block value is at the time it is being placed? I'm pretty sure you will be able to track down the problem easily that way.

 

Is the findGroundY() function your own, or is it inherited from a parent class? That is obviously a key function if you feel your Y-values are getting messed up. Otherwise, maybe you just have your top block instance messed up? Where do you assign the top block?

 

 

Edited March 3, 2018 by jabelar

[creepersgalore]

It's not the Y... The X and Z are the problem. The findGroundY() is my own, I know it works from doing this non-biome dependently. The top block is the Biome top block.

 

Some screenshots. The lighter color is the Plains Island top block, darker is Barren top block.

Edited March 3, 2018 by creepersgalore
To add some screenshots to help clarify the problem. #2: To try to make color differences easier to realize.

[Draco18s]

52 minutes ago, creepersgalore said:

Some screenshots. The green is the Plains Island, brown-ish is Barren.

/me looks at the screenshots.

/me sees brown...and a different brown.

[jabelar]

1 minute ago, Draco18s said:

/me looks at the screenshots.

/me sees brown...and a different brown.

 

I see green and brown.

 

Anyway, my point about debugging is the same. Just print out or watch the values and trace back to where the math/logic is going wrong for you. It is usually very obvious once you observe the behavior directly. 

[Draco18s]

33 minutes ago, jabelar said:

I see green and brown.

So, the darker color is #100c01 which is borderline black. But the full-bright color is #ffbf10 which is a golden-brown.

The lighter color is #231c19 which brightens up to #ffccb6, a pale tan.

The only green in the images is from the fog, on the right half of the screen. Which is not what's under query in the other two screenshots.

 

Edited March 3, 2018 by Draco18s

[jabelar]

I'm seeing #31813F in the area where your green arrow points to. Nice green.

 

EDIT: Oh, you're saying the green isn't what he's talking about. You see the green, but that's not the issue. Got it.

 

EDIT 2: Looks like he's changed his post. Now he references lighter and darker.

Edited March 3, 2018 by jabelar

[Draco18s]

25 minutes ago, jabelar said:

EDIT: Oh, you're saying the green isn't what he's talking about. You see the green, but that's not the issue. Got it.

Correct.