Jump to content

Item Drop from Block


xTekBlue

Recommended Posts

I have been working on a glowstone like block but i cant seem to get the block to drop the item i want it to when its broken. Also i cant seem to control the amount of that item to be dropped when its broken. I would like for the block to drop 2-4 of the item when broken randomly.

package xtekblue.mod.objects.blocks;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import xtekblue.mod.init.ItemInit;

public class BlockRGLit extends BlockBase {

	private final int dropAmount = 1;

	public BlockRGLit(String name) {
		super(name, Material.REDSTONE_LIGHT);
		
		setSoundType(SoundType.GLASS);
		setHardness(0.5F);
		setLightLevel(8.0F);
		setResistance(1.5F);
	}

	//No idea if these even works because i haven't seemed to figure out how to get the items to be dropped when the block is broken.
	public int quantityDropped(Random random)
	{
	            return dropAmount;
	}

}

 

Link to comment
Share on other sites

You probably want to override another method. One that says "this is the item that's dropped." Like how Glowstone and Redstone Ore do.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

1 hour ago, Draco18s said:

You probably want to override another method. One that says "this is the item that's dropped." Like how Glowstone and Redstone Ore do.

I've tried that but i've seen in other posts that override does not work and is actually recommended to no do it.

Link to comment
Share on other sites

package xtekblue.mod.objects.blocks;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import xtekblue.mod.init.ItemInit;

public class BlockRGLit extends BlockBase {

	public BlockRGLit(String name) {
		super(name, Material.REDSTONE_LIGHT);
		
		setSoundType(SoundType.GLASS);
		setHardness(0.5F);
		setLightLevel(8.0F);
		setResistance(1.5F);
	}

	/**
	* Returns the quantity of items to drop on block destruction.
	*/
	public int quantityDropped(Random p_149745_1_)
	{
		return 4;
	}

	public Item getItemDropped(int p_149650_1_, Random p_149650_2_, int p_149650_3_)
	{
		return Item.getItemFromBlock(this);
	}
	

}

This is the code i am currently testing but i have noticed that the quantityDropped is working but the getItemDropped is not exactly. I have tried setting the Item.getItemFromBlock() to ItemInit.MIX_REDSTONE_GLOWSTONE but that doesnt seem to change the item being dropped. 

Link to comment
Share on other sites

Put @override on the method you are overriding. If Eclipse says "this isn't overriding anything" then you have the wrong method signature. The fix is not to remove the annotation, but to fix the method signature so it DOES override something.

 

As for Item.getItemFromBlock(this);, that will make the block drop itself. If you want it to drop a different thing, you tell it to drop a different thing. ItemInit.MIX_REDSTONE_GLOWSTONE sounds like your custom drop, so use that.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

That's just it, when i @override on the method i'm using it doesn't say "this isn't overriding anything" it says to add it to my blockbase class. but if i do this, it will drop that item for all the blocks i have created. Correct?

Should i be overriding this?

//This says to override this method you need to implement a supertype
@Override	
public Item getItemDropped(int p_149650_1_, Random p_149650_2_, int p_149650_3_)
	{
		return ItemInit.MIX_REDSTONE_GLOWSTONE;
	}

 

Edited by xTekBlue
Link to comment
Share on other sites

1 hour ago, xTekBlue said:

//This says to override this method you need to implement a supertype

That would be "your method signature is wrong" as I said.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

2 hours ago, Draco18s said:

That would be "your method signature is wrong" as I said.

Okay so i changed a few things and i have no idea what i'm doing so bare with me :P

package xtekblue.mod.objects.blocks;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import xtekblue.mod.Main;
import xtekblue.mod.init.ItemInit;
import xtekblue.mod.util.IHasExtra;
import xtekblue.mod.util.IHasModel;

public class BlockRGLit extends BlockBase implements IHasExtra{


	public BlockRGLit(String name) {
		super(name, Material.REDSTONE_LIGHT);
		
		setSoundType(SoundType.GLASS);
		setHardness(0.5F);
		setLightLevel(8.0F);
		setResistance(1.5F);
	}

	/**
	* Returns the quantity of items to drop on block destruction.
	*/
	public int quantityDropped(Random p_149745_1_)
	{
		return 4;
	}

	@Override
	public Item getItemDropped(int par1, Random rand, int par2) {
		return ItemInit.MIX_REDSTONE_GLOWSTONE;
	}
	

}

So i implemented IHasExtra (Interface) which looks like this to remove the @Override ERROR

package xtekblue.mod.util;

import java.util.Random;

import net.minecraft.item.Item;

public interface IHasExtra {

	Item getItemDropped(int par1, Random rand, int par2);

}

Still does not seem to work. I have tried about 100 different combinations of moving stuff to different places, i'm new with java and used to doing Lua. I am trying to learn java the same way i learned Java (Self taught with help of the internet) Thanks for helping me thus far.

Edited by xTekBlue
Link to comment
Share on other sites

Paris_Tuileries_Garden_Facepalm_statue-6

 

Jesus Christ

 

YOU NEED TO OVERRIDE THE CORRECT METHOD FROM THE BLOCK CLASS.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Would you mind posting your BlockBase class or possibly putting your mod on github and linking it?

Took me too long to boot up my own IDE and notice the signature disparity

Edited by DaemonUmbra

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Link to comment
Share on other sites

I am so bad at this xD. Figured it out and from this i will learn. Thank you so much with struggling to help me do this. Especially without just saying the right code. <3

	@Override
	public Item getItemDropped(IBlockState state, Random rand, int fortune) {
	    return ItemInit.MIX_REDSTONE_GLOWSTONE;
	}

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.