[1.12.2] Adding NBT Data To Item

Posted May 17, 20187 yr

Hello,

So I'm trying to store so information onto an NBTTag however, I'm running into an issue where the item doesn't actually have an NBTTagCompound.

Ex:

stack.hasTagCompound()

returns false; thus I cannot access it as it will return null.

Here is my code:

Spoiler


package com.unassigned.customenchants.items;

import java.util.HashSet;
import java.util.Set;

import com.unassigned.customenchants.CustomEnchants;
import com.unassigned.customenchants.blocks.tile.TileEntityEnchantmentFab;
import com.unassigned.customenchants.items.base.ItemBase;
import com.unassigned.customenchants.util.ModUtil;

import net.minecraft.enchantment.Enchantment;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.nbt.NBTTagString;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.World;
import net.minecraftforge.common.util.Constants;

public class EnchantmentFabCopier extends ItemBase {
	
	public EnchantmentFabCopier(String name) {
		super(name);
		this.maxStackSize = 0;
	}
		
	@Override
	public EnumActionResult onItemUse(EntityPlayer player, World worldIn, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {
		ItemStack stack = player.getHeldItem(hand);
		if(player != null)
		{
			TileEntity tile = worldIn.getTileEntity(pos);
			if(tile != null && stack.hasTagCompound())
			{
				if((tile instanceof TileEntityEnchantmentFab))
				{
					NBTTagCompound itemCompound = stack.getTagCompound();
					if(player.isSneaking()) //sneaking
					{
						Set<Enchantment> getterEnch = ((TileEntityEnchantmentFab) tile).getKnownEnchants();

				    	NBTTagList enchantList = new NBTTagList();
				        for(Enchantment e : getterEnch) {
				        	NBTTagString eString = new NBTTagString(e.getRegistryName().toString());
				        	enchantList.appendTag(eString);
				        }
				        itemCompound.setTag("enchantList", enchantList);
				        player.sendMessage(new TextComponentTranslation("tooltip."+ModUtil.MOD_ID+".enchantCopier.copySuccess"));
				        
				        return EnumActionResult.SUCCESS;
				        
					}else { //NOT sneaking
						Set<Enchantment> setterEnch = new HashSet<Enchantment>();
					    NBTTagList list = itemCompound.getTagList("enchantList", Constants.NBT.TAG_STRING);
						for (int i = 0; i < list.tagCount(); i++) {
							Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
							setterEnch.add(theEnch);
						}
						if(!setterEnch.isEmpty()) {
							((TileEntityEnchantmentFab) tile).setEnchants(setterEnch);
					        player.sendMessage(new TextComponentTranslation("tooltip."+ModUtil.MOD_ID+".enchantCopier.applySuccess"));
					        return EnumActionResult.SUCCESS;
						}
				        player.sendMessage(new TextComponentTranslation("tooltip."+ModUtil.MOD_ID+".enchantCopier.applyFail"));
					}
				}else {
			        player.sendMessage(new TextComponentTranslation("tooltip."+ModUtil.MOD_ID+".enchantCopier.invaildTile"));
				}
			}
		}
		return EnumActionResult.PASS;
	}
}

Thanks.

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Quote

May 17, 20187 yr

No tag?

Create one, set the tag to it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

May 17, 20187 yr

Author

Okay, I got it half-working now.

Is there any way I can cancel the action of the TE opening (or even delay it); so that everything within:

player.isSneaking()

is called?

As currently, trying to right click it to set said store list to the TE results in opening it instead.

Thank you.

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Quote

May 17, 20187 yr

Please post updates code, I think you might want to override doesSneakBypassUse (I think that’s the name of the method) or use Events

About Me

Spoiler

My Discord - Cadiboo#8887

My Website - Cadiboo.github.io

My Mods - Cadiboo.github.io/projects

My Tutorials - Cadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Quote

May 17, 20187 yr

Author

That isn't exactly what I wanted. I need it to be bypassed when unsneaked and the player right clicks. I do believe I need to use an event, I just don't exactly know which one to use.

Here is the reformated and updated code:

Spoiler


package com.unassigned.customenchants.items;

import java.util.HashSet;
import java.util.List;
import java.util.Set;

import com.unassigned.customenchants.CustomEnchants;
import com.unassigned.customenchants.blocks.tile.TileEntityEnchantmentFab;
import com.unassigned.customenchants.items.base.ItemBase;
import com.unassigned.customenchants.util.ModUtil;

import net.minecraft.block.state.IBlockState;
import net.minecraft.client.resources.I18n;
import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.nbt.NBTTagString;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.common.util.Constants;

public class EnchantmentFabCopier extends ItemBase {

	public EnchantmentFabCopier(String name) {
		super(name);
		this.maxStackSize = 1;
	}

	@Override
	public EnumActionResult onItemUse(EntityPlayer player, World worldIn, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {
		ItemStack stack = player.getHeldItem(hand);
		TileEntity tile = worldIn.getTileEntity(pos);

		if(!stack.hasTagCompound())
			stack.setTagCompound(new NBTTagCompound());

		NBTTagCompound compound = stack.getTagCompound();

		if(player != null)
		{
			if(tile != null) {
				if(tile instanceof TileEntityEnchantmentFab)
				{
					if(!player.isSneaking()) //if player uses item - while not sneaking
					{
						Set<Enchantment> storedList = new HashSet<Enchantment>();
						NBTTagList list = compound.getTagList("enchantList", Constants.NBT.TAG_STRING);
						for (int i = 0; i < list.tagCount(); i++) {
							Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
							storedList.add(theEnch);
						}
						((TileEntityEnchantmentFab) tile).setEnchants(storedList);
						player.sendMessage(new TextComponentTranslation("temp: successfully set!"));

						return EnumActionResult.SUCCESS;
					}else { //uses item while sneaking
						NBTTagList enchantList = new NBTTagList();
						for(Enchantment e : ((TileEntityEnchantmentFab) tile).getKnownEnchants()) {
							NBTTagString eString = new NBTTagString(e.getRegistryName().toString());
							enchantList.appendTag(eString);
						}
						compound.setTag("enchantList", enchantList);
						player.sendMessage(new TextComponentTranslation("temp: successfully stored!"));

						return EnumActionResult.SUCCESS;
					}
				}
			}else {
				if(compound.hasKey("enchantList") && player.isSneaking()) //if they shift+right click something that isn't the TE -> clear it.
				{
					compound.removeTag("enchantList");
					player.sendMessage(new TextComponentTranslation("temp: successfully cleared!"));
					return EnumActionResult.SUCCESS;
				}
			}
		}

		return EnumActionResult.PASS;
	}
	
	@Override
	public void addInformation(ItemStack stack, World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
		super.addInformation(stack, worldIn, tooltip, flagIn);
		if(stack.hasTagCompound())
		{
			if(stack.getTagCompound().hasKey("enchantList"))
			{
				tooltip.add("[temp]Currently Storing: ");
				NBTTagList list = stack.getTagCompound().getTagList("enchantList", Constants.NBT.TAG_STRING);
				for (int i = 0; i < list.tagCount(); i++) {
					Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
					tooltip.add("- "+I18n.format(theEnch.getName()));
				}
				
			}else {
				tooltip.add("[temp]No Enchantments stored!");
			}
		}else {
			tooltip.add("[temp]No Enchantments stored!");
		}
	}
	
	@Override
	public boolean doesSneakBypassUse(ItemStack stack, IBlockAccess world, BlockPos pos, EntityPlayer player) {
		return false;
	}
}

Thanks.

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Quote

May 17, 20187 yr

If you use Item#onItemUseFirst instead of Item#onItemUse returning EnumActionResult.SUCCESS will prevent Block#onBlockActivated from firing thus preventing any GUI/Container showing up.

Alternatively you may set the result of PlayerInteractEvent.RightClickBlock to DENY

Quote

May 17, 20187 yr

Author

8 minutes ago, diesieben07 said:

You are returning PASS which means "I don't care about this right click", hence the game continues with the next possible target (the TE). You need to return the correct EnumActionResult.

Even with this change ( EnumActionResult.PASS ) to ( EnumActionResult.SUCCESS or even EnumActionResult.FAIL ) it still does not function. (It just opens the TE)

Am I missing something?

Edited May 17, 20187 yr by Lambda

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Quote

May 17, 20187 yr

Author

7 minutes ago, V0idWa1k3r said:

If you use Item#onItemUseFirst instead of Item#onItemUse returning EnumActionResult.SUCCESS will prevent Block#onBlockActivated from firing thus preventing any GUI/Container showing up.

Alternatively you may set the result of PlayerInteractEvent.RightClickBlock to DENY

Okay, this seemed to fix it.

However, as I've been experiencing this issue, I would like to see if I could fix it:

It seems that my chat messages I send to the player print twice, I don't know if the method is getting called twice, regardless, it is not intended.

Here is my updated code:

Spoiler


package com.unassigned.customenchants.items;

import java.util.HashSet;
import java.util.List;
import java.util.Set;

import com.unassigned.customenchants.CustomEnchants;
import com.unassigned.customenchants.blocks.tile.TileEntityEnchantmentFab;
import com.unassigned.customenchants.items.base.ItemBase;
import com.unassigned.customenchants.util.ModUtil;

import net.minecraft.block.state.IBlockState;
import net.minecraft.client.resources.I18n;
import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.enchantment.Enchantment;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.nbt.NBTTagString;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.common.util.Constants;

public class EnchantmentFabCopier extends ItemBase {

	public EnchantmentFabCopier(String name) {
		super(name);
		this.maxStackSize = 1;
	}

	@Override
	public EnumActionResult onItemUseFirst(EntityPlayer player, World world, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ, EnumHand hand) {
		ItemStack stack = player.getHeldItem(hand);
		TileEntity tile = world.getTileEntity(pos);

		if(!stack.hasTagCompound())
			stack.setTagCompound(new NBTTagCompound());

		NBTTagCompound compound = stack.getTagCompound();

		if(player != null)
		{
			if(tile != null) {
				if(tile instanceof TileEntityEnchantmentFab)
				{
					if(!player.isSneaking()) //if player uses item - while not sneaking
					{
						Set<Enchantment> storedList = new HashSet<Enchantment>();
						NBTTagList list = compound.getTagList("enchantList", Constants.NBT.TAG_STRING);
						for (int i = 0; i < list.tagCount(); i++) {
							Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
							storedList.add(theEnch);
						}
						((TileEntityEnchantmentFab) tile).setEnchants(storedList);
						player.sendMessage(new TextComponentTranslation("temp: successfully set!"));

						return EnumActionResult.SUCCESS;
					}else { //uses item while sneaking
						NBTTagList enchantList = new NBTTagList();
						for(Enchantment e : ((TileEntityEnchantmentFab) tile).getKnownEnchants()) {
							NBTTagString eString = new NBTTagString(e.getRegistryName().toString());
							enchantList.appendTag(eString);
						}
						compound.setTag("enchantList", enchantList);
						player.sendMessage(new TextComponentTranslation("temp: successfully stored!"));

						return EnumActionResult.SUCCESS;
					}
				}
			}else {
				if(compound.hasKey("enchantList") && player.isSneaking()) //if they shift+right click something that isn't the TE -> clear it.
				{
					compound.removeTag("enchantList");
					player.sendMessage(new TextComponentTranslation("temp: successfully cleared!"));
					return EnumActionResult.SUCCESS;
				}
			}
		}

		return EnumActionResult.SUCCESS;
	}
	
	@Override
	public void addInformation(ItemStack stack, World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
		super.addInformation(stack, worldIn, tooltip, flagIn);
		if(stack.hasTagCompound())
		{
			if(stack.getTagCompound().hasKey("enchantList"))
			{
				tooltip.add("[temp]Currently Storing: ");
				NBTTagList list = stack.getTagCompound().getTagList("enchantList", Constants.NBT.TAG_STRING);
				for (int i = 0; i < list.tagCount(); i++) {
					Enchantment theEnch = Enchantment.getEnchantmentByLocation(list.getStringTagAt(i));
					tooltip.add("- "+I18n.format(theEnch.getName()));
				}
				
			}else {
				tooltip.add("[temp]No Enchantments stored!");
			}
		}else {
			tooltip.add("[temp]No Enchantments stored!");
		}
	}
	
	@Override
	public boolean doesSneakBypassUse(ItemStack stack, IBlockAccess world, BlockPos pos, EntityPlayer player) {
		return false;
	}
}

Thank you.

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Quote

May 17, 20187 yr

Item#onItemUseFirst is called on both the client and the server. You lack a !world.isRemote check.

Quote

May 17, 20187 yr

Author

Thanks, that seemed to work!

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Quote

Sign In

[1.12.2] Adding NBT Data To Item

Featured Replies

Join the conversation

Posts

need help assessing crash report and how to fix it

need help assessing crash report and how to fix it

Evolution reset modpack grout issue

need help assessing crash report and how to fix it

need help assessing crash report and how to fix it

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)