Converting Hashmap Capability Data to NBT

[NolValue]

So, say I want to use a HashMap to store capability data.

I'm using the code 

Map<String, String> stat = new HashMap<>();

The first String is the stats/args, whatever you want to call it, and the second is the value.

I have all the add, set, and remove functions setup (albeit really not optimally)

public void addStat(String args, String value, int amount)
{
    int valTemp = Integer.parseInt(value);
    valTemp += amount;
    if (args.equals("str")||equals("cons")||equals("dex")||equals("will")||equals("mind")||equals("spir")){
        value = Integer.toString(valTemp);
        stat.put(args, value);

    }
}
public void removeStat(String args, String value, int amount)
{
    int valTemp = Integer.parseInt(value);
    valTemp -= amount;
    if (args.equals("str")||equals("cons")||equals("dex")||equals("will")||equals("mind")||equals("spir")){
        value = Integer.toString(valTemp);
        stat.put(args, value);}
}
public void setStat(String args, String value)
{
    if (args.equals("str")||equals("cons")||equals("dex")||equals("will")||equals("mind")||equals("spir"){
        stat.put(args, value)}
}
public void getStat(String args)
{
    if (args.equals("str")||equals("cons")||equals("dex")||equals("will")||equals("mind")||equals("spir"){
    stat.get(args);}
}

this is the code used for what each of the functions do.

 

How would I go about writing and reading the data? I've tried NBTTagCompound, which always sent out an error.

 

I'm not really truly experienced with Java, so I may be missing something extremely obvious.

 

Edited May 21, 2018 by NolValue

[NolValue]

The entity that it will be attached to is a player, if that helps any.

[Draco18s]

for each(key in hashmap.keys) {
    nbt.putValue(key, hasmap.get(key))
}

Its almost like this stuff writes itself.

[NolValue]

11 minutes ago, Draco18s said:

for each(key in hashmap.keys) {
    nbt.putValue(key, hasmap.get(key))
}

Its almost like this stuff writes itself.

1

Man, that's extremely simple. I'm an idiot, I swear.

[LexManos]

Oh lord, where to start.

32 minutes ago, NolValue said:

 

Map<String, String> stat = new HashMap<>();

You are using this to store what? A String name, and int value right.. so why is it a <String,String> and not a <String,Integer>

 

32 minutes ago, NolValue said:

 

    int valTemp = Integer.parseInt(value);
    valTemp += amount;
        value = Integer.toString(valTemp);
        stat.put(args, value);

Why are you immediately converting the string to a int, why not just take in a int? It would save you all of these Integer calls...

32 minutes ago, NolValue said:

 

    if (args.equals("str")||equals("cons")||equals("dex")||equals("will")||equals("mind")||equals("spir")){

You do this line 4 times, you should probably move this to a 'isValidKey' function, OR start using a enum.

32 minutes ago, NolValue said:

 

public void getStat(String args)
{
    if (args.equals("str")||equals("cons")||equals("dex")||equals("will")||equals("mind")||equals("spir"){
    stat.get(args);}
}

You do realize this function doesn't actually return anything and thus is completely useless... right... ?

 

Looks to me that you want to do something more like:

public  enum  Stat  { STRENGTH, CONSTITUTION, DEXTERITY, WILLPOWER, MIND, SPIRIT};
HashMap<Stat, Integer> stats = new HashMap<>();
public void add(Stat stat, int value) {
    stats.set(stat, stats.getOrDefault(stat, 0) + value);
}

 

[NolValue]

On 5/20/2018 at 8:33 PM, LexManos said:

Oh lord, where to start.

You are using this to store what? A String name, and int value right.. so why is it a <String,String> and not a <String,Integer>

 

Why are you immediately converting the string to a int, why not just take in a int? It would save you all of these Integer calls...

You do this line 4 times, you should probably move this to a 'isValidKey' function, OR start using a enum.

You do realize this function doesn't actually return anything and thus is completely useless... right... ?

 

Looks to me that you want to do something more like:

public  enum  Stat  { STRENGTH, CONSTITUTION, DEXTERITY, WILLPOWER, MIND, SPIRIT};
HashMap<Stat, Integer> stats = new HashMap<>();
public void add(Stat stat, int value) {
    stats.set(stat, stats.getOrDefault(stat, 0) + value);
}

 

9

I actually tried using an enum at an earlier point, but when I tried to use NBTTagCompound it'd throw up an incompatible types error, I should be using .setInteger right?

[LexManos]

you can save it however you want, enums have two things that are unique, and if you don't screw it up, ordinal() returns a unique integer for each enum value.

Or you could use the name() which is a string.

[jredfox]

On 5/20/2018 at 8:02 PM, NolValue said:

So, say I want to use a HashMap to store capability data.

I'm using the code 

Map<String, String> stat = new HashMap<>();

The first String is the stats/args, whatever you want to call it, and the second is the value.

I have all the add, set, and remove functions setup (albeit really not optimally)

public void addStat(String args, String value, int amount)
{
    int valTemp = Integer.parseInt(value);
    valTemp += amount;
    if (args.equals("str")||equals("cons")||equals("dex")||equals("will")||equals("mind")||equals("spir")){
        value = Integer.toString(valTemp);
        stat.put(args, value);

    }
}
public void removeStat(String args, String value, int amount)
{
    int valTemp = Integer.parseInt(value);
    valTemp -= amount;
    if (args.equals("str")||equals("cons")||equals("dex")||equals("will")||equals("mind")||equals("spir")){
        value = Integer.toString(valTemp);
        stat.put(args, value);}
}
public void setStat(String args, String value)
{
    if (args.equals("str")||equals("cons")||equals("dex")||equals("will")||equals("mind")||equals("spir"){
        stat.put(args, value)}
}
public void getStat(String args)
{
    if (args.equals("str")||equals("cons")||equals("dex")||equals("will")||equals("mind")||equals("spir"){
    stat.get(args);}
}

this is the code used for what each of the functions do.

 

How would I go about writing and reading the data? I've tried NBTTagCompound, which always sent out an error.

 

I'm not really truly experienced with Java, so I may be missing something extremely obvious.

 

Should be stored as HashMap<ResourceLocation,ICapability> if your looking to replace the system for forge and should be a forge pull(ICapability in my opinion should only have read/write to nbt. However if your working with the system forge already gives you it needs to be synced with serialization during read/write to nbt 

Example for players replacing a system(similar to what bukkit does):
https://github.com/jredfox/evilnotchlib/tree/master/src/main/java/com/EvilNotch/lib/minecraft/content/pcapabilites

Edited May 22, 2018 by jredfox