Reflection making items invisible?

[Coder]

Hello,

 

I am using reflection to get an item's display name by replacing its data manager.

the only thing I am changing there is setEntryValues in which I find the itemStack and like this, I get the item display name.

Sometimes when an item spawns it will disappear client side but when I will walk to the item location I will pick it up. Is it possible that forge is removing the visibility of the item for some reason?

[Draco18s]

You're likely doing something wrong. You should stop doing it wrong.

 

Spoiler

Post your code?

 

[Coder]

20 hours ago, Draco18s said:

You're likely doing something wrong. You should stop doing it wrong.

 

  Hide contents

Post your code?

 

Sure

Spoiler

    private static final Field DATA_FIELD;
    static {
        {
            Class<?> clazz = Entity.class;
            Field f = null;
            for (Field field : clazz.getDeclaredFields()) {
                if (field.getType() == EntityDataManager.class) {
                    f = field;
                    break;
                }
            }
            f.setAccessible(true);
            DATA_FIELD = f;
        }
    }
    
    public static void setEntityDataManager (Entity entity, EntityDataManager manager ) {
        try {
            DATA_FIELD.set(entity, manager);
        } catch(Exception e) {
            e.printStackTrace();
        }
    }

 

 

 

 

Edited May 28, 2018 by Coder

[Coder]

1 minute ago, diesieben07 said:

Uhm, what? Why are you doing that?

Please clarify what exactly you want to achieve. You should not have to replace the EntityDataManager.

Just get the custom name of the item.

[larsgerrits]

IIRC, ItemStack#getDisplayName returns the custom name if the stack has one. What else are you trying to do?

Edited May 28, 2018 by larsgerrits

[Coder]

2 hours ago, larsgerrits said:

IIRC, ItemStack#getDisplayName returns the custom name if the stack has one. What else are you trying to do?

I think you need reflection for this

[Coder]

Just now, diesieben07 said:

No, you do not. ItemStack#getDisplayName is public.

Sorry for me acting like a complete noob. How do I get this using entityjoinworldevent?

[Coder]

Just now, diesieben07 said:

EntityJoinWorldEvent fires when an entity joins the world. There are no item stacks involved. Please clarify which ItemStack you want to access.

I would like to get the name of every item that "joins" the world. Meaning the entity item that's on the ground.

[Coder]

9 minutes ago, diesieben07 said:

EntityItem#getItem returns the ItemStack contained in the EntityItem.

 

This is a classic XY problem. In the future please state your desired result, not how you tried to get to that result.

Aha! But for some reason it returns "Air" instead on the item name

[Coder]

Just now, diesieben07 said:

On the client the EntityDataManager will only be updated with a subsequent packet.

What are you trying to do with this name?

I would like to target items with a specific custom name for highlighting etc

[Coder]

1 minute ago, diesieben07 said:

You need to stop being vague. In that specific event handler, what exactly would you do with the name, and why?

I would like to get the item that has joined, get its name, take that name check if it is included inside an array if so, tell me that this item is there and it has the said custom name.

I want to highlight items that spawn when you have many items on the ground it is very helpful. That's all.

[Coder]

1 minute ago, diesieben07 said:

Define "highlight". I assume that means you want to draw some kind of overlay? If so, EntityJoinWorldEvent is the wrong place to do so anyways.

Yeah, or just send a chat message to start of. Is it possible to get the name of the item at all with EntityJoinWorldEvent?

[Coder]

Just now, diesieben07 said:

Not on the client, no.

What would you suggest? I was doing it with reflection as I showed before, but it makes the item invisible at times...

[Coder]

1 minute ago, diesieben07 said:

If you want to draw an overlay, check the name wherever you draw the overlay.

If you want to send a chat message, see above.

Yes, but didn't we say it's not possible to get the name of the item using this method?

[Coder]

On 5/28/2018 at 5:25 PM, diesieben07 said:

 

Hi sorry for writing after some time.

Do I need to iterate tough all entities on the ground and find the items in between them to achieve this?