[MainlySolved]Adding enchanted items to inventory on player spawn

[Blue_Atlas]

so here is my EventHandler

 

package com.atlas.experimentmod.util.handlers;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.item.ItemStack;
import net.minecraftforge.event.entity.EntityJoinWorldEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.PlayerEvent.PlayerLoggedInEvent;

public class EventHandler 
{
	@SubscribeEvent
	public void onPlayerJoin(PlayerLoggedInEvent event)
	{
	if (!event.player.world.isRemote)
	{
		event.player.inventory.addItemStackToInventory(new ItemStack(Items.STICK));
	}
	}
}

it doesnt work.

could you tell me what is wrong?

and how to make it right?

[Draco18s]

You haven't registered your event handler class as an event handler with the event bus.

[Blue_Atlas]

and how would i do that?

[DaemonUmbra]

http://mcforge.readthedocs.io/en/latest/events/intro/#creating-an-event-handler

mentioned at the end of this section.

Edited June 12, 2018 by DaemonUmbra

[Blue_Atlas]

I know but where do I put that code?

[Draco18s]

In....a class...

[Blue_Atlas]

What class? My main class? Or the evenhandler class?

[Draco18s]

  On 6/12/2018 at 10:02 PM, Blue_Atlas said:

Or the evenhandler class?

Expand  

 

Where do you put an event handler? Maybe in an event handler class?

YES

[Blue_Atlas]

Is that picture really necesary?

 

 

 

So I put MincraftForge.EVENT_BUS.register(EventHandler) at the start of my eventhandler?

[Blue_Atlas]

I have read the document several times and I cannot find anything about where the registry code goes

[Draco18s]

  On 6/12/2018 at 10:36 PM, Blue_Atlas said:

I have read the document several times and I cannot find anything about where the registry code goes

Expand  

Apparently you missed this part:

 

Registry events are just another kind of event.

Edited June 12, 2018 by Draco18s

[Blue_Atlas]

No I did not. Look at my code above. It has everything except being registered which is done (from what I was seeing) using MinecraftForge.EVENT_BUS.register()

[Blue_Atlas]

But where do I put that method?

[Draco18s]

Or, slightly farther down the page...

http://mcforge.readthedocs.io/en/latest/events/intro/#automatically-registering-static-event-handlers

[Blue_Atlas]

So let's see if I have this now:

 

I put the method inside my init and inside the () i put EventHandler.class

 

That right?

[Blue_Atlas]

Okay then it i call MinecraftForge.EVENT_BUS.register(EventHandler.class) in my init method?

[Draco18s]

  On 6/12/2018 at 10:59 PM, Blue_Atlas said:

Okay then it i call MinecraftForge.EVENT_BUS.register(EventHandler.class) in my init method?

Expand  

Only if your event handler method is static.

[Blue_Atlas]

It is working now thank you guys for the help

[Blue_Atlas]

Actually I am having a problem. My code adds the items to inventory every time the player enters the world.

How would I did this so players won't be able to exploit it to get unlimited items?

 

P.S.

Will my code work on servers? It's the same as above except it is now static. The servers in question are servers running the mod i make as well as LAN with my friends

[Blue_Atlas]

Would it be possible to make the items instead be given to player when they get an advancement?

If that is possible how would I make an advancement for when the player joins the world and change my code for to give the items to player when they get that advancement?

[Draco18s]

You don't need events to do that. All you have to do is write an advancement JSON that rewards the player with the item.