Problem With Creative Tab

[Merthew]

The item gem_darkshard is not showing up in the mainTab. Please help.

https://github.com/Merthew/MerthewMod

[Draco18s]

Not related to your issue, but this is dumb:

https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/util/handlers/RegistryHandler.java#L31-L41

The whole notion of IHasModel is fucking stupid. ALL ITEMS NEED MODELS.

Secondly, you don't need to ask the item what it's model is, just call ModelLoader.setCustomModelResourceLocation(item, meta, resource_location) directly. There's no reason to ask the item itself to generate that information, as its all public and accessible from outside classes. There is nothing about this that requires that it be inside the item.

This pattern infuriates me as it was created by someone who didn't know what they were doing and has tossed it up as a "tutorial."

 

Then this:

https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/objects/blocks/ModBlock.java#L23

Completely bypasses the whole notion that blocks do not necessarily have item forms (does the extended piston have an item? No it does not. Does cake? Not it does not). There's nothing wrong with giving your blocks items automatically, but by making your base block class's constructor do it, none of your block subclasses can prevent it.

[Merthew]

Hey, thanks. I am still new to modding so just trying to play around with the code. Good to know that i don't have to use the interface.

 

[Draco18s]

15 minutes ago, Merthew said:

Hey, thanks. I am still new to modding so just trying to play around with the code. Good to know that i don't have to use the interface.

Nothing wrong with that either.

I just see that interface literally everywhere and it's pointless.

As a guide, 90% of the tutorials written for modding are written by new modders who haven't figured everything out yet, but they figured out this bit in a way that doesn't explode and so they write a tutorial.

 

Me? I liked the cleanliness of how 1.7's GameRegistry worked (from the perspective of using the class), in that it took 2 to 3 lines to register items and blocks, everything else "happened by magic." I.e. out of my sight and Just Worked. So I went about recreating that in 1.10 (and have since updated for 1.12).

 

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/hardlib/EasyRegistry.java

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/hardlib/client/ClientEasyRegistry.java

 

Acts as common/client proxy in a library mod (^{note 1}). It's a little hard to follow just because there are several wrapper methods that just call another method. Could be refactored, but I was working outwards at the time. 1.12 also messed with things with the registry events, so all those methods end up just shoving data into an object and stuffing that into an array, which later gets referenced by the events.

 

And usage:

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/farming/FarmingBase.java#L102-L128

 

Clean, simple, has all the options.

 

Note 1 _{A common proxy does not make sense 99.99% of the time. Even this could be refactored, but in this context, it makes sense to leave it.}

Edited June 9, 2018 by Draco18s

[Merthew]

Bump?

[Merthew]

Bump?

[DaemonUmbra]

The constructors for your tab items do not add your mod id to the items' Registry Names, I believe the result of this is that Minecraft is trying to find the models and textures for your items within its own resources. (Someone please correct me if I'm mistaken)

[Merthew]

That was intentional, i don't want the tab icons appearing as actual items.

[Draco18s]

1 hour ago, Merthew said:

That was intentional, i don't want the tab icons appearing as actual items.

That's not how that works.

 

[Merthew]

I did not want the TabIcon items appearing in the creative tab, so i set the creative tab in the constructor to null. However, the gem_darkshard, and the ingot_darkiron have the creative tab set to mainTab.

[Draco18s]

So?

Override getCreativeTabs and return null.

[Merthew]

Basically my thought process at the moment. I still have no idea about the other one...

[Draco18s]

5 hours ago, Merthew said:

However, the gem_darkshard, and the ingot_darkiron have the creative tab set to mainTab.

I do not understand this.

[Merthew]

I want the gem_darkshard and the ingot_darkiron to be in the mainTab. In the code i have setCreativeTab(Main.mainTab) which is the same as the blockInit class. However, only the blocks are showing up in the creative tab.

[Draco18s]

You construct your items here:

https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/init/ItemInit.java#L18

This immediate calls this:

https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/objects/items/ModItem.java#L16

Which references this:

https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/Main.java#L27

Which in turn references this:

https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/init/ItemInit.java#L16

 

Your tabs haven't finished being created and assigned to your Main mod class's static fields by the time you construct your items, due to the use of static initializers.

 

In order for the JVM to construct your tab it first needs to construct all four items.

In order for the JVM to construct all four items, it first needs to get your constructed tabs.

[Merthew]

So i need to register the tabs first right? How would one go about doing that? 

[Draco18s]

Don't use static initializers.

[Merthew]

Fixed it, just kind of removed the icon idea.. oh well. Thanks for you help and patience.