Merthew Posted June 9, 2018 Posted June 9, 2018 The item gem_darkshard is not showing up in the mainTab. Please help. https://github.com/Merthew/MerthewMod Quote The seven became one and the one became two.
Draco18s Posted June 9, 2018 Posted June 9, 2018 Not related to your issue, but this is dumb: https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/util/handlers/RegistryHandler.java#L31-L41 The whole notion of IHasModel is fucking stupid. ALL ITEMS NEED MODELS. Secondly, you don't need to ask the item what it's model is, just call ModelLoader.setCustomModelResourceLocation(item, meta, resource_location) directly. There's no reason to ask the item itself to generate that information, as its all public and accessible from outside classes. There is nothing about this that requires that it be inside the item. This pattern infuriates me as it was created by someone who didn't know what they were doing and has tossed it up as a "tutorial." Then this: https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/objects/blocks/ModBlock.java#L23 Completely bypasses the whole notion that blocks do not necessarily have item forms (does the extended piston have an item? No it does not. Does cake? Not it does not). There's nothing wrong with giving your blocks items automatically, but by making your base block class's constructor do it, none of your block subclasses can prevent it. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Merthew Posted June 9, 2018 Author Posted June 9, 2018 Hey, thanks. I am still new to modding so just trying to play around with the code. Good to know that i don't have to use the interface. Quote The seven became one and the one became two.
Draco18s Posted June 9, 2018 Posted June 9, 2018 (edited) On 6/9/2018 at 4:58 PM, Merthew said: Hey, thanks. I am still new to modding so just trying to play around with the code. Good to know that i don't have to use the interface. Expand Nothing wrong with that either. I just see that interface literally everywhere and it's pointless. As a guide, 90% of the tutorials written for modding are written by new modders who haven't figured everything out yet, but they figured out this bit in a way that doesn't explode and so they write a tutorial. Me? I liked the cleanliness of how 1.7's GameRegistry worked (from the perspective of using the class), in that it took 2 to 3 lines to register items and blocks, everything else "happened by magic." I.e. out of my sight and Just Worked. So I went about recreating that in 1.10 (and have since updated for 1.12). https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/hardlib/EasyRegistry.java https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/hardlib/client/ClientEasyRegistry.java Acts as common/client proxy in a library mod (note 1). It's a little hard to follow just because there are several wrapper methods that just call another method. Could be refactored, but I was working outwards at the time. 1.12 also messed with things with the registry events, so all those methods end up just shoving data into an object and stuffing that into an array, which later gets referenced by the events. And usage: https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/farming/FarmingBase.java#L102-L128 Clean, simple, has all the options. Note 1 A common proxy does not make sense 99.99% of the time. Even this could be refactored, but in this context, it makes sense to leave it. Edited June 9, 2018 by Draco18s Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Merthew Posted June 10, 2018 Author Posted June 10, 2018 Bump? Quote The seven became one and the one became two.
Merthew Posted June 12, 2018 Author Posted June 12, 2018 Bump? Quote The seven became one and the one became two.
DaemonUmbra Posted June 12, 2018 Posted June 12, 2018 The constructors for your tab items do not add your mod id to the items' Registry Names, I believe the result of this is that Minecraft is trying to find the models and textures for your items within its own resources. (Someone please correct me if I'm mistaken) Quote This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy. As the most common issue I feel I should put this outside the main bulk: The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge. If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan. For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety. Reveal hidden contents Logs (Most issues require logs to diagnose): Reveal hidden contents Please post logs using one of the following sites (Thank you Lumber Wizard for the list): https://gist.github.com/: 100MB Requires member (Free) https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$) https://hastebin.com/: 400KB Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads. What to provide: ...for Crashes and Runtime issues: Minecraft 1.14.4 and newer: Post debug.log Older versions: Please update... ...for Installer Issues: Post your installer log, found in the same place you ran the installer This log will be called either installer.log or named the same as the installer but with .log on the end Note for Windows users: Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension Where to get it: Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs. Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch: Reveal hidden contents Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge) Make a launcher profile targeting this version of Forge. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it). Now launch the pack through that profile and follow the "Mojang Launcher" instructions above. Video: Reveal hidden contents or alternately, Fallback ("No logs are generated"): If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft Server Not Starting: Reveal hidden contents If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output. Reporting Illegal/Inappropriate Adfocus Ads: Reveal hidden contents Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad. Lex will need the Ad ID contained in that URL to report it to Adfocus' support team. Posting your mod as a GitHub Repo: Reveal hidden contents When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub. When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository. Open a command prompt (CMD, Powershell, Terminal, etc). Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in). Run the following commands: git init git remote add origin [Your Repository's URL] In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git git fetch git checkout --track origin/master git stage * git commit -m "[Your commit message]" git push Navigate to GitHub and you should now see most of the files. note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from) Now you can share your GitHub link with those who you are asking for help. [Workaround line, please ignore]
Merthew Posted June 12, 2018 Author Posted June 12, 2018 That was intentional, i don't want the tab icons appearing as actual items. Quote The seven became one and the one became two.
Draco18s Posted June 12, 2018 Posted June 12, 2018 On 6/12/2018 at 8:42 PM, Merthew said: That was intentional, i don't want the tab icons appearing as actual items. Expand That's not how that works. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Merthew Posted June 13, 2018 Author Posted June 13, 2018 I did not want the TabIcon items appearing in the creative tab, so i set the creative tab in the constructor to null. However, the gem_darkshard, and the ingot_darkiron have the creative tab set to mainTab. Quote The seven became one and the one became two.
Draco18s Posted June 13, 2018 Posted June 13, 2018 So? Override getCreativeTabs and return null. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Merthew Posted June 13, 2018 Author Posted June 13, 2018 Basically my thought process at the moment. I still have no idea about the other one... Quote The seven became one and the one became two.
Draco18s Posted June 13, 2018 Posted June 13, 2018 On 6/13/2018 at 1:44 PM, Merthew said: However, the gem_darkshard, and the ingot_darkiron have the creative tab set to mainTab. Expand I do not understand this. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Merthew Posted June 13, 2018 Author Posted June 13, 2018 I want the gem_darkshard and the ingot_darkiron to be in the mainTab. In the code i have setCreativeTab(Main.mainTab) which is the same as the blockInit class. However, only the blocks are showing up in the creative tab. Quote The seven became one and the one became two.
Draco18s Posted June 13, 2018 Posted June 13, 2018 You construct your items here: https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/init/ItemInit.java#L18 This immediate calls this: https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/objects/items/ModItem.java#L16 Which references this: https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/Main.java#L27 Which in turn references this: https://github.com/Merthew/MerthewMod/blob/master/main/java/merthew/mod/init/ItemInit.java#L16 Your tabs haven't finished being created and assigned to your Main mod class's static fields by the time you construct your items, due to the use of static initializers. In order for the JVM to construct your tab it first needs to construct all four items. In order for the JVM to construct all four items, it first needs to get your constructed tabs. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Merthew Posted June 13, 2018 Author Posted June 13, 2018 So i need to register the tabs first right? How would one go about doing that? Quote The seven became one and the one became two.
Draco18s Posted June 13, 2018 Posted June 13, 2018 Don't use static initializers. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Merthew Posted June 14, 2018 Author Posted June 14, 2018 Fixed it, just kind of removed the icon idea.. oh well. Thanks for you help and patience. Quote The seven became one and the one became two.
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.