Jump to content

Keep Blocks Grass except for Block under player


LittleOne
 Share

Recommended Posts

Hello,

I'm attempting to change the block under the player, which works, from playerUPos. However, I'm trying to get the surrounding positions in relation to the player and set those blocks to grass. This code isn't working. I think I'm not getting the logic yet. Any help is greatly appreciated!

@SubscribeEvent
	public void onPlayerTickEvent(PlayerTickEvent event) {
		if(event.player instanceof EntityPlayer) {
			EntityPlayer player = (EntityPlayer) event.player;
			BlockPos playerUPos = player.getPosition().down();
			IBlockState playerUState = player.world.getBlockState(playerUPos);
			BlockPos playerOBPos = player.getPosition().add(5, 2, 5);
			BlockPos playerTBPos = player.getPosition().subtract(playerOBPos);
			Iterable<BlockPos> playerABPos = player.getPosition().getAllInBox(playerOBPos, playerTBPos);
			if(player.onGround && player.world.getBlockState(playerUPos).getBlock() == Blocks.GRASS) {
				player.world.setBlockState(playerUPos, Blocks.STONE.getDefaultState());
			for (BlockPos item : playerABPos) {
				IBlockState newItem = player.world.getBlockState(item);
				Block newItemBlock = newItem.getBlock();
				if(item == playerUPos) {
					player.world.setBlockState(playerUPos, Blocks.STONE.getDefaultState());
				}else {
					if(newItemBlock == Blocks.STONE.getDefaultState()) {
						player.world.setBlockState(item, Blocks.GRASS.getDefaultState());
						}
				}
				}
			}
		}
	}

Also I did try the method by taking each position individually and that worked. However, I feel it was too tedious and it actually didn't work when a player jumped off a bock.

Edited by LittleOne
Link to comment
Share on other sites

4 minutes ago, diesieben07 said:
25 minutes ago, LittleOne said:

if(item == playerUPos) {

 

This will never be true. == compares object identity. You want equals.

I would also refrain from using the name item for this scope variable, as it looks like it refers to an Item (due to the nearby Block newItemBlock = newItem.getBlock();line) but is in fact a BlockPos. I would use pos, loc, location, or point, or similar.

Edited by Draco18s
  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Alright thank you! I changed a few things including the variable names and == to .equals(). I think there's something else though because the code still isn't doing what I want it to do. I'm wondering if the whole for loop is somehow being negated.

 

public void onPlayerTickEvent(PlayerTickEvent event) {
		if(event.player instanceof EntityPlayer) {
			EntityPlayer player = (EntityPlayer) event.player;
			BlockPos playerUPos = player.getPosition().down();
			IBlockState playerUState = player.world.getBlockState(playerUPos);
			BlockPos playerOBPos = player.getPosition().add(5, 2, 5);
			BlockPos playerTBPos = player.getPosition().add(-5, -2, -5);
			Iterable<BlockPos> playerABPos = player.getPosition().getAllInBox(playerOBPos, playerTBPos);
			if(player.onGround && player.world.getBlockState(playerUPos).getBlock() == Blocks.GRASS) {
				player.world.setBlockState(playerUPos, Blocks.STONE.getDefaultState());
			for (BlockPos pos : playerABPos) {
				IBlockState newPosState = player.world.getBlockState(pos);
				Block newPosBlock = newPosState.getBlock();
				if(pos.equals(playerUPos)) {
					player.world.setBlockState(playerUPos, Blocks.STONE.getDefaultState());
				}else {
					if(newPosBlock == Blocks.STONE.getDefaultState()) {
						player.world.setBlockState(pos, Blocks.GRASS.getDefaultState());
						}
				}
				}
			}
		}
	}

Or the part under else is not going through for some reason.

Edited by LittleOne
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.