[1.12.2] dimension problems

[The_SlayerMC]

The biome code is crashing at trying to set the top block which makes no sense due to prior versions it was working, and basing it off vanilla code it should work too

 

The block code is getting called before the biome which is the way it should be

 

	public class BiomeGenEuca extends Biome {
	    public BiomeGenEuca(String par1) {
        super(new BiomeProperties(par1));
        this.setRegistryName(par1);
        this.topBlock = JourneyBlocks.eucaGrass.getDefaultState();
        this.fillerBlock = JourneyBlocks.eucaStone.getDefaultState();
        this.spawnableCreatureList.clear();
        this.spawnableMonsterList.clear();
        this.spawnableWaterCreatureList.clear();
        this.spawnableCaveCreatureList.clear();
        getSkyColorByTemp(0xffd800);
    }
}
	

 

and also reading a problem at the portal block trying to register the property for the axis of the block in the constructor

 

	public class BlockEucaPortal extends BlockBreakable {
	    public static final PropertyEnum AXIS = PropertyEnum.create("axis", EnumFacing.Axis.class, new EnumFacing.Axis[] {EnumFacing.Axis.X, EnumFacing.Axis.Z});
    protected static final AxisAlignedBB X_AABB = new AxisAlignedBB(0.0D, 0.0D, 0.375D, 1.0D, 1.0D, 0.625D);
    protected static final AxisAlignedBB Z_AABB = new AxisAlignedBB(0.375D, 0.0D, 0.0D, 0.625D, 1.0D, 1.0D);
    protected static final AxisAlignedBB Y_AABB = new AxisAlignedBB(0.375D, 0.0D, 0.375D, 0.625D, 1.0D, 0.625D);
	 
	    public BlockEucaPortal(String name) {
        super(Material.PORTAL, false);
        LangRegistry.addBlock(name, "Euca Portal");
        this.setTickRandomly(true);
        setCreativeTab(JourneyTabs.portalBlocks);
        this.setDefaultState(this.blockState.getBaseState().withProperty(AXIS, EnumFacing.Axis.X)); //THIS LINE HERE
        setUnlocalizedName(name);
        JourneyBlocks.blockName.add(name);
        JourneyBlocks.blocks.add(this);
        setRegistryName(name);
    }
	    @Override
    public Item getItemDropped(IBlockState state, Random rand, int fortune) {
        return null;
    }
	    @Override
    public AxisAlignedBB getCollisionBoundingBox(IBlockState blockState, IBlockAccess worldIn, BlockPos pos) { 
        return null;
    }
	    @Override
    public AxisAlignedBB getBoundingBox(IBlockState state, IBlockAccess source, BlockPos pos) {
        switch ((EnumFacing.Axis)state.getValue(AXIS)) {
        case X:
            return X_AABB;
        case Y:
        default:
            return Y_AABB;
        case Z:
            return Z_AABB;
        }
    }
	    @Override
    public boolean isFullCube(IBlockState state) {
        return false;
    }
	    @Override
    public int quantityDropped(Random p_149745_1_) {
        return 0;
    }
	    @Override
    public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entity) {
        if ((entity.getRidingEntity() == null) && ((entity instanceof EntityPlayerMP))) {
            EntityPlayerMP thePlayer = (EntityPlayerMP)entity;
            WorldServer worldserver = thePlayer.mcServer.getWorld(thePlayer.dimension);
            //thePlayer.triggerAchievement(JourneyAchievements.achievementEuca);
            int dimensionID = Config.euca;
            Block blockFrame = JourneyBlocks.eucaPortalFrame;
            if(thePlayer.timeUntilPortal > 0) 
                thePlayer.timeUntilPortal = 10;
            else if(thePlayer.dimension != dimensionID) {
                thePlayer.timeUntilPortal = 10;
                thePlayer.mcServer.getPlayerList().transferPlayerToDimension(thePlayer, dimensionID, new ModTeleporter(thePlayer.mcServer.getWorld(dimensionID), dimensionID, this, blockFrame));
            } else {
                thePlayer.timeUntilPortal = 10;
                thePlayer.mcServer.getPlayerList().transferPlayerToDimension(thePlayer, 0, new ModTeleporter(thePlayer.mcServer.getWorld(0), 0, this, blockFrame));
            }
        }
    }
	    @Override
    public IBlockState getStateFromMeta(int meta) {
        return this.getDefaultState().withProperty(AXIS, (meta & 3) == 2 ? EnumFacing.Axis.Z : EnumFacing.Axis.X);
    }
	    @Override
    @SideOnly(Side.CLIENT)
    public BlockRenderLayer getBlockLayer() {
        return BlockRenderLayer.TRANSLUCENT;
    }
	    @Override
    @SideOnly(Side.CLIENT)
    public void randomDisplayTick(IBlockState state, World worldIn, BlockPos pos, Random rand) {
        if(rand.nextInt(100) == 0)
            worldIn.playSound((double)pos.getX() + 0.5D, (double)pos.getY() + 0.5D, (double)pos.getZ() + 0.5D, SoundEvents.BLOCK_PORTAL_AMBIENT, SoundCategory.BLOCKS, 0.5F, rand.nextFloat() * 0.4F + 0.8F, false);
	        for(int i = 0; i < 4; ++i) {
            double d0 = (float)pos.getX() + rand.nextFloat();
            double d1 = (float)pos.getY() + rand.nextFloat();
            double d2 = (float)pos.getZ() + rand.nextFloat();
            double d3 = (rand.nextFloat() - 0.5D) * 0.5D;
            double d4 = (rand.nextFloat() - 0.5D) * 0.5D;
            double d5 = (rand.nextFloat() - 0.5D) * 0.5D;
            int j = rand.nextInt(2) * 2 - 1;
            if(worldIn.getBlockState(pos.west()).getBlock() != this && worldIn.getBlockState(pos.east()).getBlock() != this) {
                d0 = (double)pos.getX() + 0.5D + 0.25D * j;
                d3 = rand.nextFloat() * 2.0F * j;
            } else {
                d2 = (double)pos.getZ() + 0.5D + 0.25D * j;
                d5 = rand.nextFloat() * 2.0F * j;
            }
            EntityEucaPotalFX var20 = new EntityEucaPotalFX(worldIn, d0, d1, d2, d3, d4, d5);
            FMLClientHandler.instance().getClient().effectRenderer.addEffect(var20);
        }
    }
	    @Override
    @SideOnly(Side.CLIENT)
    public boolean shouldSideBeRendered(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos, EnumFacing side) {
        pos = pos.offset(side);
        EnumFacing.Axis enumfacing$axis = null;
	        if(blockState.getBlock() == this) {
            enumfacing$axis = (EnumFacing.Axis)blockState.getValue(AXIS);
            if(enumfacing$axis == null) 
                return false;
            if(enumfacing$axis == EnumFacing.Axis.Z && side != EnumFacing.EAST && side != EnumFacing.WEST) 
                return false;
            if(enumfacing$axis == EnumFacing.Axis.X && side != EnumFacing.SOUTH && side != EnumFacing.NORTH) 
                return false;
        }
	        boolean flag = blockAccess.getBlockState(pos.west()).getBlock() == this && blockAccess.getBlockState(pos.west(2)).getBlock() != this;
        boolean flag1 = blockAccess.getBlockState(pos.east()).getBlock() == this && blockAccess.getBlockState(pos.east(2)).getBlock() != this;
        boolean flag2 = blockAccess.getBlockState(pos.north()).getBlock() == this && blockAccess.getBlockState(pos.north(2)).getBlock() != this;
        boolean flag3 = blockAccess.getBlockState(pos.south()).getBlock() == this && blockAccess.getBlockState(pos.south(2)).getBlock() != this;
        boolean flag4 = flag || flag1 || enumfacing$axis == EnumFacing.Axis.X;
        boolean flag5 = flag2 || flag3 || enumfacing$axis == EnumFacing.Axis.Z;
	        if(flag4 && side == EnumFacing.WEST) return true;
        else if(flag4 && side == EnumFacing.EAST)return true;
        else if(flag5 && side == EnumFacing.NORTH) return true;      
        else return flag5 && side == EnumFacing.SOUTH;
    }
	    public boolean makePortal(World worldIn, BlockPos p) {
        BlockEucaPortal.Size size = new BlockEucaPortal.Size(worldIn, p, EnumFacing.Axis.X);
        if(size.isValid() && size.portalBlockCount == 0) {
            size.placePortalBlocks();
            return true;
        } else {
            BlockEucaPortal.Size size1 = new BlockEucaPortal.Size(worldIn, p, EnumFacing.Axis.Z);
            if(size1.isValid() && size1.portalBlockCount == 0) {
                size1.placePortalBlocks();
                return true;
            } else {
                return false;
            }
        }
    }
	    @Override
    public ItemStack getItem(World worldIn, BlockPos pos, IBlockState state) {
        return new ItemStack(this);
    }
	    @Override
    public int getMetaFromState(IBlockState state) {
        return meta((EnumFacing.Axis)state.getValue(AXIS));
    }
	    public static int meta(Axis a) {
        return a == EnumFacing.Axis.X ? 1 : (a == EnumFacing.Axis.Z ? 2 : 0);
    }
	    @Override
    public IBlockState withRotation(IBlockState state, Rotation rot) {
        switch (rot) {
        case COUNTERCLOCKWISE_90:
        case CLOCKWISE_90:
	            switch ((EnumFacing.Axis)state.getValue(AXIS)) {
            case X:
                return state.withProperty(AXIS, EnumFacing.Axis.Z);
            case Z:
                return state.withProperty(AXIS, EnumFacing.Axis.X);
            default:
                return state;
            }
        default:
            return state;
        }
    }
	    @Override
    public BlockFaceShape getBlockFaceShape(IBlockAccess i, IBlockState i2, BlockPos p, EnumFacing f) {
        return BlockFaceShape.UNDEFINED;
    }
	    public static class Size {
        private final World world;
        private final EnumFacing.Axis axis;
        private final EnumFacing rightDir;
        private final EnumFacing leftDir;
        private int portalBlockCount;
        private BlockPos bottomLeft;
        private int height;
        private int width;
	        public Size(World worldIn, BlockPos pos, EnumFacing.Axis axis) {
            this.world = worldIn;
            this.axis = axis;
	            if(axis == EnumFacing.Axis.X) {
                this.leftDir = EnumFacing.EAST;
                this.rightDir = EnumFacing.WEST;
            } else {
                this.leftDir = EnumFacing.NORTH;
                this.rightDir = EnumFacing.SOUTH;
            }
	            for(BlockPos blockpos = pos; pos.getY() > blockpos.getY() - 21 && pos.getY() > 0 && this.isEmptyBlock(worldIn.getBlockState(pos.down()).getBlock()); pos = pos.down()) {
                ;
            }
	            int i = this.getDistanceUntilEdge(pos, this.leftDir) - 1;
	            if(i >= 0) {
                this.bottomLeft = pos.offset(this.leftDir, i);
                this.width = this.getDistanceUntilEdge(this.bottomLeft, this.rightDir);
	                if(this.width < 2 || this.width > 21) {
                    this.bottomLeft = null;
                    this.width = 0;
                }
            }
	            if(this.bottomLeft != null) {
                this.height = this.calculatePortalHeight();
            }
        }
	        protected int getDistanceUntilEdge(BlockPos pos, EnumFacing facing) {
            int i;
	            for(i = 0; i < 22; ++i) {
                BlockPos blockpos = pos.offset(facing, i);
	                if(!this.isEmptyBlock(this.world.getBlockState(blockpos).getBlock()) || this.world.getBlockState(blockpos.down()).getBlock() != JourneyBlocks.eucaPortalFrame) {
                    break;
                }
            }
	            Block block = this.world.getBlockState(pos.offset(facing, i)).getBlock();
            return block == JourneyBlocks.eucaPortalFrame ? i : 0;
        }
	        public int getHeight() {
            return this.height;
        }
	        public int getWidth() {
            return this.width;
        }
	        protected int calculatePortalHeight() {
            label56:
	                for(this.height = 0; this.height < 21; ++this.height) {
                    for(int i = 0; i < this.width; ++i) {
                        BlockPos blockpos = this.bottomLeft.offset(this.rightDir, i).up(this.height);
                        Block block = this.world.getBlockState(blockpos).getBlock();
	                        if(!this.isEmptyBlock(block)) {
                            break label56;
                        }
	                        if(block == JourneyBlocks.eucaPortal) {
                            ++this.portalBlockCount;
                        }
	                        if(i == 0) {
                            block = this.world.getBlockState(blockpos.offset(this.leftDir)).getBlock();
	                            if(block != JourneyBlocks.eucaPortalFrame) {
                                break label56;
                            }
                        }
                        else if(i == this.width - 1) {
                            block = this.world.getBlockState(blockpos.offset(this.rightDir)).getBlock();
	                            if(block != JourneyBlocks.eucaPortalFrame) {
                                break label56;
                            }
                        }
                    }
                }
	        for(int j = 0; j < this.width; ++j) {
            if (this.world.getBlockState(this.bottomLeft.offset(this.rightDir, j).up(this.height)).getBlock() != JourneyBlocks.eucaPortalFrame) {
                this.height = 0;
                break;
            }
        }
	        if (this.height <= 21 && this.height >= 3) {
            return this.height;
        } else {
            this.bottomLeft = null;
            this.width = 0;
            this.height = 0;
            return 0;
        }
        }
	        protected boolean isEmptyBlock(Block blockIn) {
            return blockIn.getMaterial(blockIn.getDefaultState()) == Material.AIR || blockIn == JourneyBlocks.fire || blockIn == JourneyBlocks.eucaPortal;
        }
	        public boolean isValid() {
            return this.bottomLeft != null && this.width >= 2 && this.width <= 21 && this.height >= 3 && this.height <= 21;
        }
	        public void placePortalBlocks() {
            for(int i = 0; i < this.width; ++i) {
                BlockPos blockpos = this.bottomLeft.offset(this.rightDir, i);
	                for(int j = 0; j < this.height; ++j) {
                    this.world.setBlockState(blockpos.up(j), JourneyBlocks.eucaPortal.getDefaultState().withProperty(BlockEucaPortal.AXIS, this.axis), 2);
                }
            }
        }
    }
}
	

 

	net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Journey Into the Light (essence)
Caused by: java.lang.ExceptionInInitializerError
    at net.journey.dimension.euca.BiomeGenEuca.<init>(BiomeGenEuca.java:12)
    at net.journey.dimension.DimensionHelper.<clinit>(DimensionHelper.java:105)
    at net.journey.proxy.CommonProxy.preInit(CommonProxy.java:72)
    at net.journey.JITL.preInit(JITL.java:52)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at net.minecraftforge.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:629)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
    at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
    at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
    at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
    at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
    at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
    at com.google.common.eventbus.EventBus.post(EventBus.java:217)
    at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:218)
    at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:196)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
    at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
    at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
    at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
    at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
    at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
    at com.google.common.eventbus.EventBus.post(EventBus.java:217)
    at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:135)
    at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:627)
    at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:245)
    at net.minecraft.client.Minecraft.init(Minecraft.java:513)
    at net.minecraft.client.Minecraft.run(Minecraft.java:421)
    at net.minecraft.client.main.Main.main(Main.java:118)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
    at GradleStart.main(GradleStart.java:25)
Caused by: java.lang.IllegalArgumentException: Cannot set property PropertyEnum{name=axis, clazz=class net.minecraft.util.EnumFacing$Axis, values=[x, z]} as it does not exist in BlockStateContainer{block=null, properties=[]}
    at net.minecraft.block.state.BlockStateContainer$StateImplementation.withProperty(BlockStateContainer.java:221)
    at net.journey.blocks.portal.BlockEucaPortal.<init>(BlockEucaPortal.java:48)
    at net.journey.JourneyBlocks.<clinit>(JourneyBlocks.java:285)
    ... 51 more
	
A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------
	-- System Details --
Details:
    Minecraft Version: 1.12.2
    Operating System: Windows 10 (amd64) version 10.0
    Java Version: 1.8.0_171, Oracle Corporation
    Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
    Memory: 634148792 bytes (604 MB) / 1037959168 bytes (989 MB) up to 1037959168 bytes (989 MB)
    JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M
    IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
    FML: MCP 9.42 Powered by Forge 14.23.4.2705 5 mods loaded, 5 mods active
    States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
	    | State | ID        | Version      | Source                           | Signature |
    |:----- |:--------- |:------------ |:-------------------------------- |:--------- |
    | UCH   | minecraft | 1.12.2       | minecraft.jar                    | None      |
    | UCH   | mcp       | 9.42         | minecraft.jar                    | None      |
    | UCH   | FML       | 8.0.99.99    | forgeSrc-1.12.2-14.23.4.2705.jar | None      |
    | UCH   | forge     | 14.23.4.2705 | forgeSrc-1.12.2-14.23.4.2705.jar | None      |
    | UCEE  | essence   | 1.2          | bin                              | None      |
	    Loaded coremods (and transformers): 
    GL info: ' Vendor: 'Intel' Version: '4.4.0 - Build 22.20.16.4708' Renderer: 'Intel(R) HD Graphics 630'
[12:34:15] [main/INFO] [STDOUT]: [net.minecraft.init.Bootstrap:printToSYSOUT:629]: #@!@# Game crashed! Crash report saved to: #@!@# D:\Development\Minecraft\Forge\1.12\run\.\crash-reports\crash-2018-06-17_12.34.15-client.txt
	

 

Edited June 17, 2018 by The_SlayerMC

[Draco18s]

You're going to need to supply more code.

I recommend posting your project as a git repository.

[The_SlayerMC]

https://github.com/TheSlayerMC/Journey-1.12

[Draco18s]

Why do you have this:

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/journey/RegistrationHandler.java#L22

AND this?

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/journey/JourneyItems.java#L844

 

In any case, I suspect that your DimensionHelper.init() is being called before your Blocks are created. But as fucking everything is using static initializers, I can't prove it.

See also: 

 

Edited June 17, 2018 by Draco18s

[The_SlayerMC]

On 6/17/2018 at 11:55 PM, Draco18s said:

Why do you have this:

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/journey/RegistrationHandler.java#L22

AND this?

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/journey/JourneyItems.java#L844

 

In any case, I suspect that your DimensionHelper.init() is being called before your Blocks are created. But as fucking everything is using static initializers, I can't prove it.

See also: 

 

as nooby as it sounds, i looked up the new registration tutorials and thats what they had, probably looking at that it doubles up on code.

 

Which would be the better one to run with?

Edited June 19, 2018 by The_SlayerMC

[Draco18s]

4 hours ago, The_SlayerMC said:

Which would be the better one to run with?

They are functionally identical.

Pick a place to put your registration handler functions, where ever sounds good to you.

 

And what tutorial was it? I would like to go tell the author they're being dumb.

[The_SlayerMC]

On 6/19/2018 at 11:54 PM, Draco18s said:

They are functionally identical.

Pick a place to put your registration handler functions, where ever sounds good to you.

 

And what tutorial was it? I would like to go tell the author they're being dumb.

in all honesty i wouldn't be able to find it as it took ages to find to begin with but thats where the idea came from, and me coming from 1.3.2 - 1.8 i would believe anything i read on the new system as ive see the way it has changed, which has been weirder before

[The_SlayerMC]

but how would i set up my Item and Block files to be able to instance them to grab them in ways the biomes need to find them, so it gets called first, how did you register your items?

[Draco18s]

Create everything (calling new) in your PreinitializationEvent method.