Jump to content

Recommended Posts

Posted

Well hello there,
i had a mod in 1.7.10 that had custom armor rendering
and i am now trying to do the same with 1.12.2 .. :I

 

additional info:

  • this is just for tests... i want to do this with a different model that my friend makes for me right now
  • I got confused at the new item registering and i bet i did something wrong at that .. (the last version i did mod in was 1.7.10)
  • I got that working in 1.7.10 .. but i don't even ..know if i did it correctly there
  • not being sure if i do it correctly .. (i mean like with the proxy sided stuff i obviously don't want to send a model to the server side.. >-<)



here is my problem i am trying to do a armor with a custom Model
and encountered these problems:

  • the armor is rendered like a "child" mob so the little version of the model
  • the animation of hitting, pulling a bow, blocking with shield... is NOT shown how do i get them in 1.12.2? ..
  • getting it "double" rendered (it gets rendered 2 times)

 

 

 

 

so here is actual code:


Model class:

package maki325.bnha.models;

import net.minecraft.client.model.ModelBase;
import net.minecraft.client.model.ModelBiped;
import net.minecraft.client.model.ModelRenderer;
import net.minecraft.entity.Entity;

public class ClothModel extends ModelBiped {
    private ModelRenderer RArm;
    private ModelRenderer LLeg;
    private ModelRenderer Head;
    private ModelRenderer Body;
    private ModelRenderer LArm;
    private ModelRenderer RLeg;

    public ClothModel(float f) {
    	super(f, 0, 64,32);
    	
        this.textureWidth = 64;
        this.textureHeight = 32;
        
        this.LArm = new ModelRenderer(this, 40, 16);
        this.LArm.addBox(-1.0F, -2.0F, -2.0F, 4, 12, 4, 0.0F);
        this.LArm.isHidden = true;
        
        this.Body = new ModelRenderer(this, 16, 16);
        this.Body.addBox(-4.0F, 0.0F, -2.0F, 8, 12, 4, 0.0F);
        
        this.RLeg = new ModelRenderer(this, 0, 16);
        this.RLeg.addBox(-2.0F, 0.0F, -2.0F, 4, 12, 4, 0.0F);
        
        this.LLeg = new ModelRenderer(this, 0, 16);
        this.LLeg.addBox(-2.0F, 0.0F, -2.0F, 4, 12, 4, 0.0F);
        
        this.RArm = new ModelRenderer(this, 40, 16);
        this.RArm.addBox(-3.0F, -2.0F, -2.0F, 4, 12, 4, 0.0F);
        
        this.Head = new ModelRenderer(this, 0, 0);
        this.Head.addBox(-4.0F, -8.0F, -4.0F, 8, 8, 8, 0.0F);
        /*
        bipedLeftArm.addChild(LArm);
        bipedBody.addChild(Body);        
        bipedRightLeg.addChild(RLeg);
        bipedLeftLeg.addChild(LLeg);
        bipedRightArm.addChild(RArm);        
        bipedHead.addChild(Head);
        trying stuff 	*/
    }

    @Override
    public void render(Entity entity, float f, float f1, float f2, float f3, float f4, float f5) { 
    	 super.render(entity, f, f1, f2, f3, f4, f5);
    	 setRotationAngles(f, f1, f2, f3, f4, f5, entity);
    }
    
}

Item class:

package maki325.bnha.init.items;

import java.util.HashSet;
import java.util.Set;

import maki325.bnha.util.Reference;
import net.minecraft.init.SoundEvents;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.Item;
import net.minecraft.item.ItemArmor;
import net.minecraftforge.common.util.EnumHelper;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.registry.GameRegistry.ObjectHolder;
import net.minecraftforge.registries.IForgeRegistry;

@ObjectHolder(Reference.MOD_ID)
public class ModItems {

	public static class ArmorMaterials {
		
		
		public static final ItemArmor.ArmorMaterial UA_SPORTS_MAT =
				EnumHelper.addArmorMaterial
				(Reference.MOD_ID +":ua_sports",
						Reference.MOD_ID +":ua_sports",
						15,
						new int[]{1, 4, 5, 2},
						12,
						SoundEvents.ITEM_ARMOR_EQUIP_LEATHER,
						(float) 0);
		
		
	}

	/*                    ITEMS                         */
	/*——————————————————————————————————————————————————*/
	
	
	
	/*——————————————————————————————————————————————————*/
	/*                    ARMOR                         */
	/*——————————————————————————————————————————————————*/
	public static final ClothArmor UA_SPORTS_CHESTPLATE = 
			new ClothArmor("ua_sports_chestplate",
					ArmorMaterials.UA_SPORTS_MAT,
					1,
					EntityEquipmentSlot.CHEST);

	
	
	public static final ClothArmor UA_SPORTS_LEGGINGS = 
			new ClothArmor("ua_sports_leggings",
					ArmorMaterials.UA_SPORTS_MAT,
					2,
					EntityEquipmentSlot.LEGS);

	/*——————————————————————————————————————————————————*/
	
	
	private static void initialiseItems() {
		UA_SPORTS_CHESTPLATE
		.setUnlocalizedName(UA_SPORTS_CHESTPLATE.getRegistryName().toString());
			
		UA_SPORTS_LEGGINGS
		.setUnlocalizedName(UA_SPORTS_LEGGINGS.getRegistryName().toString());
	}

	@Mod.EventBusSubscriber(modid = Reference.MOD_ID)
	public static class RegistrationHandler {
		public static final Set<Item> ITEMS = new HashSet<>();

		@SubscribeEvent
		public static void registerItems(final RegistryEvent.Register<Item> event) {
			final Item[] items = {
					UA_SPORTS_CHESTPLATE,
					UA_SPORTS_LEGGINGS,
			};

			final IForgeRegistry<Item> registry = event.getRegistry();

			for (final Item item : items) {
				registry.register(item);
				ITEMS.add(item);
			}

			initialiseItems();
		}
	}
}

Armor class:

package maki325.bnha.init.items;

import maki325.bnha.BnHA;
import maki325.bnha.models.ClothModel;
import maki325.bnha.util.IHasModel;
import maki325.bnha.util.Reference;
import net.minecraft.client.model.ModelBiped;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.ItemArmor;
import net.minecraft.item.ItemStack;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class ClothArmor extends ItemArmor implements IHasModel{
	

	public ClothArmor(String name,ArmorMaterial material,int renderindex, EntityEquipmentSlot slot) {
		super(material, renderindex, slot);
		this.setRegistryName(Reference.MOD_ID, name);
        this.setCreativeTab(CreativeTabs.COMBAT);
	}
	
	@Override
	@SideOnly(Side.CLIENT)
	public ModelBiped getArmorModel(EntityLivingBase living, ItemStack stack, EntityEquipmentSlot slot, ModelBiped defaultModel)
	{
		if(!stack.isEmpty())
		{
			if(stack.getItem() instanceof ItemArmor)
			{
				ClothModel armorModel = BnHA.proxy.getClothModel();

				armorModel.bipedRightLeg.showModel = slot == EntityEquipmentSlot.FEET;
				armorModel.bipedLeftLeg.showModel = slot == EntityEquipmentSlot.FEET;
				armorModel.bipedBody.showModel = slot == EntityEquipmentSlot.CHEST;
				armorModel.bipedLeftArm.showModel = slot == EntityEquipmentSlot.CHEST;
				armorModel.bipedRightArm.showModel = slot == EntityEquipmentSlot.CHEST;
				armorModel.bipedHead.showModel = slot == EntityEquipmentSlot.HEAD;
				
				armorModel.isSneak = defaultModel.isSneak;
				armorModel.isRiding = defaultModel.isRiding;
				
				armorModel.rightArmPose = defaultModel.rightArmPose.BLOCK;
				armorModel.leftArmPose = defaultModel.leftArmPose.BLOCK;
				
				armorModel.rightArmPose = defaultModel.rightArmPose;
				armorModel.leftArmPose = defaultModel.leftArmPose;

				return armorModel;
			}
		}
		return null;
	}   		
	
	@Override
	public void registerModels() {
		BnHA.proxy.registerItemRenderer(this, 0, "inventory");
	}
	
}

ClientProxy class:

package maki325.bnha.proxy;

import maki325.bnha.models.ClothModel;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;

public class ClientProxy extends CommonProxy {
	
	private static final ClothModel clothmodel = new ClothModel(1F);
	
	public void registerItemRenderer(Item item, int meta, String id) {
		ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(item.getRegistryName(), id));
	}
	
	@Override
	public ClothModel getClothModel() {
		return clothmodel;
		}
	
	public static void registerModel() {
		
	}
	
}

 

thanks for reading this and helping me :)

Posted
16 minutes ago, Oscarita25 said:

Does really nobody know here how to do this?

i can read through the code and see what i can find if thats any help ?

note that my knowledge is limited so i cant promise much

Posted
51 minutes ago, Oscarita25 said:

still searching for a solution .. i am really stuck .. ?

sorry, i read it for ages but found nothing, like i said its been some time since i last read code

Posted
Just now, Ghostkeal said:

sorry, i read it for ages but found nothing, like i said its been some time since i last read code

when you don't find its okay .. but i am hoping for others right now that have expierence on that kind of thing or know what it could be to point it out for me :I
 

because:

54 minutes ago, Oscarita25 said:

still searching for a solution .. i am really stuck .. ?

 

Posted

In the 'render' method, you call "super.render()" and nothing else. That means that only the superclass model will be rendered. You need to get rid of the 'super' call and render your model's parts:

 

Head.renderWithRotation(scale);

Body.renderWithRotation(scale);

 

and so on. 'scale' is the 'f5' parameter.

But that's not all. Before going further, I'll ask - is this model intended for players only?

 

Posted (edited)
6 hours ago, Alexiy said:

But that's not all. Before going further, I'll ask - is this model intended for players only?

@Alexiy
yes right now its only intentended for players

Edited by Oscarita25
Posted

okay i just used a work around that is way easier
child the parts to the biped model - what would be the player
and then rendering then the super method (what would be Modelbiped)
and just using
 

LArm.isHidden = true;
Body.isHidden = true;
RLeg.isHidden = true;
LLeg.isHidden = true;
RArm.isHidden = true;
Head.isHidden = true;

 

to hide the models that are getting rendered 2 times

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • dynamictrees and dtneapolitan are the last mentioned mod - remove these
    • https://mclo.gs/9y5ciD2 anyone ever had this issue?  Internal exception illegal argument exception: unable to fit 3194354 into 3
    • Hi! I'm trying to add my custom models/textures renderer like this: public class PonyPlayerWrapperRenderer extends EntityRenderer<Player> { // wrapper class under my LivingEntityRenderer class implementation private final PonyPlayerRenderer innerRenderer; private final PonyPlayerRenderer innerSlimRenderer; public PonyPlayerWrapperRenderer(final EntityRendererProvider.Context context) { super(context); System.out.println("creating new PonyPlayerWrapperRenderer"); this.innerRenderer = new PonyPlayerRenderer(context, false); this.innerSlimRenderer = new PonyPlayerRenderer(context, true); } @Override public void render(final Player entity, final float yaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource bufferSource, final int packedLight) { System.out.println("PonyPlayerWrapperRenderer render: " + entity.toString()); if (entity instanceof AbstractClientPlayer clientPlayer) { if (clientPlayer.getModelName().contains("slim")) { innerSlimRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } else { innerRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } } } @Override public ResourceLocation getTextureLocation(final Player player) { System.out.println("PonyPlayerWrapperRenderer getTextureLocation"); if (player instanceof AbstractClientPlayer clientPlayer) { return clientPlayer.getSkinTextureLocation(); } System.out.println("player instanceof AbstractClientPlayer is false"); return getDefaultSkin(player.getUUID()); } } public class PonyPlayerRenderer extends LivingEntityRenderer<AbstractClientPlayer, PlayerModel<AbstractClientPlayer>> { private final PlayerModel<AbstractClientPlayer> earthModel; private final PlayerModel<AbstractClientPlayer> pegasusModel; private final PlayerModel<AbstractClientPlayer> unicornModel; public PonyPlayerRenderer(final EntityRendererProvider.Context context, final boolean slim) { super( context, slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)), 0.5f ); System.out.println("creating new PonyPlayerRenderer"); this.earthModel = slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); this.pegasusModel = new PegasusModel(context.bakeLayer(PegasusModel.LAYER_LOCATION)); this.unicornModel = new UnicornModel(context.bakeLayer(UnicornModel.LAYER_LOCATION)); } @Override public void render(final AbstractClientPlayer player, final float entityYaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource buffer, final int packedLight) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); this.model = switch (race) { case PEGASUS -> pegasusModel; case UNICORN -> unicornModel; case EARTH -> earthModel; }; super.render(player, entityYaw, partialTicks, poseStack, buffer, packedLight); } @Override public ResourceLocation getTextureLocation(final AbstractClientPlayer player) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); return switch (race) { case EARTH -> fromNamespaceAndPath(MODID, "textures/entity/earth_pony.png"); case PEGASUS -> fromNamespaceAndPath(MODID, "textures/entity/pegasus.png"); case UNICORN -> fromNamespaceAndPath(MODID, "textures/entity/unicorn.png"); }; } } @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { // mod bus render registration config @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onRegisterRenderers(final EntityRenderersEvent.RegisterRenderers event) { event.registerEntityRenderer(EntityType.PLAYER, PonyPlayerWrapperRenderer::new); System.out.println("onRegisterRenderers end"); } } Method onRegisterRenderers() is called and I can see it being logged. But when I enter the world, my PonyWrapperRenderer render() method doesn't ever seem to be called. I also tried to put my renderer to EntityRenderDispatcher's playerRenderers via reflection: @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onClientSetup(final FMLClientSetupEvent event) { event.enqueueWork(() -> { try { final EntityRenderDispatcher dispatcher = Minecraft.getInstance().getEntityRenderDispatcher(); final Field renderersField = getEntityRenderDispatcherField("playerRenderers"); final Field itemInHandRenderer = getEntityRenderDispatcherField("itemInHandRenderer"); @SuppressWarnings("unchecked") final Map<String, EntityRenderer<? extends Player>> playerRenderers = (Map<String, EntityRenderer<? extends Player>>)renderersField.get(dispatcher); final PonyPlayerWrapperRenderer renderer = new PonyPlayerWrapperRenderer( new EntityRendererProvider.Context( dispatcher, Minecraft.getInstance().getItemRenderer(), Minecraft.getInstance().getBlockRenderer(), (ItemInHandRenderer)itemInHandRenderer.get(dispatcher), Minecraft.getInstance().getResourceManager(), Minecraft.getInstance().getEntityModels(), Minecraft.getInstance().font ) ); playerRenderers.put("default", renderer); playerRenderers.put("slim", renderer); System.out.println("Player renderers replaced"); } catch (final Exception e) { throw new RuntimeException("Failed to replace player renderers", e); } }); } private static Field getEntityRenderDispatcherField(final String fieldName) throws NoSuchFieldException { final Field field = EntityRenderDispatcher.class.getDeclaredField(fieldName); field.setAccessible(true); return field; } } But I receive the error before Minecraft Client appears (RuntimeException: Failed to replace player renderers - from ClientRenderers onClientSetup() method - and its cause below): java.lang.IllegalArgumentException: No model for layer anotherlittlepony:earth_pony#main at net.minecraft.client.model.geom.EntityModelSet.bakeLayer(EntityModelSet.java:18) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.EntityRendererProvider$Context.bakeLayer(EntityRendererProvider.java:69) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerRenderer.<init>(PonyPlayerRenderer.java:32) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerWrapperRenderer.<init>(PonyPlayerWrapperRenderer.java:24) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.ClientRenderers.lambda$onClientSetup$0(ClientRenderers.java:79) ~[main/:?] {re:classloading} ... 33 more Problem appears when EntityRendererProvider context tries to bakeLayer with my model layer location: new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); // PonyPlayerRenderer.java:32 public class PonyModel extends PlayerModel<AbstractClientPlayer> { // the model class itself public static final ModelLayerLocation LAYER_LOCATION = new ModelLayerLocation( ResourceLocation.fromNamespaceAndPath(MODID, "earth_pony"), "main" ); public PonyModel(final ModelPart root) { super(root, false); } public static LayerDefinition createBodyLayer() { // some CubeListBuilder stuff for model appearance } } Textures PNGs are placed at: resources/assets/[my mod id]/textures/entity. My forge version is 1.20.1. Would appreciate any help.
    • Well, a bit more information about what you're trying to do would be helpful. e.g. why you're trying to use "INVOKE_ASSIGN" instead of "INVOKE". "INVOKE_ASSIGN" calls your code after the "target" is called and its value is stored, if applicable. "INVOKE" calls your code before the target is called. "target" expects a fully qualified name, as per the SpongePowered docs, if that name is going to be remapped (which it will be if your injecting into Minecraft itself and not another mod). For more information on fully qualified names versus canonical names, see the Java specifications. Here's an example of a working "@At" from my own code that targets the "getClosestsVulnerablePlayerToEntity" call inside a mob's logic: @At(value = "INVOKE_ASSIGN", target = "net.minecraft.world.World.getClosestVulnerablePlayerToEntity(Lnet/minecraft/entity/Entity;D)Lnet/minecraft/entity/player/EntityPlayer;") Hope this helps!
    • Ran it one more time just to check, and there's no errors this time on the log??? Log : https://mclo.gs/LnuaAiu I tried allocating more memory to the modpack, around 8000MB and it's still the same; stopping at "LOAD_REGISTRIES". Are some of the mods clashing, maybe? I have no clue what to do LOL
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.