Two different versions of my item [1.12]

[Severed_Infinity]

Getting back into modding using the new guidelines. I've created a single item (so far), added it's texture, json, and registered. In game (in creative) opening inventory and adding my idea works no problem, the issue is with the /give command. When using the /give command I get a different untextured item that is not considered the same as the one from inventory.

[Animefan8888]

  On 6/30/2018 at 10:36 AM, Severed_Infinity said:

Getting back into modding using the new guidelines. I've created a single item (so far), added it's texture, json, and registered. In game (in creative) opening inventory and adding my idea works no problem, the issue is with the /give command. When using the /give command I get a different untextured item that is not considered the same as the one from inventory.

Expand  

It's hard to answer your question without seeing the code also post the text you used as the command.

[Severed_Infinity]

My apologies I was having trouble doing basic input to text field for some reason.

 

A gist to the list of class I believe are important to the issue.

[Animefan8888]

  On 6/30/2018 at 10:50 AM, Severed_Infinity said:

My apologies I was having trouble doing basic input to text field for some reason.

 

A gist to the list of class I believe are important to the issue.

Expand  

I would like to see the command you entered and the ItemIngotCopper class.

[Severed_Infinity]

I added the ingot class as I had forgotten to include it but its there now.

and the command "/give @p tn:ingot_copper 1 2"

[Animefan8888]

  On 6/30/2018 at 10:58 AM, Severed_Infinity said:

and the command "/give @p tn:ingot_copper 1 2"

Expand  

I believe you are giving it with a metadata value, which in turn you did not register a model/texture to.

[Severed_Infinity]

Yeah, I am thinking that it is the case myself but I can't figure it out, changing the 2 to any other number or removing it still gives me a blank textured alternative version of my item. Very strange.

[Animefan8888]

  On 6/30/2018 at 11:06 AM, Severed_Infinity said:

Yeah, I am thinking that it is the case myself but I can't figure it out, changing the 2 to any other number or removing it still gives me a blank textured alternative version of my item. Very strange.

Expand  

Could you put all of your code on github? And that is strange you should try looking through it with you're IDE's debugger.

[Severed_Infinity]

I can do, give us a few minutes to upload it

 

[Severed_Infinity]

Sorry it took so long but I've uploaded it now https://github.com/Severed-Infinity/Technium

[Draco18s]

Also:

• IHasModel is stupid. All items need models. ALL ITEMS.
• ModelRegistryEvent is client side only. This will crash the dedicated server.
• This can be done externally (i.e. not inside the class) just fine: Technium.proxy.registerItemRender(item, 0, "inventory");
• If your item classes look like this, you don't need them at all.
• The fuck? You used the IProxy interface (good) method and a common proxy (bad)?

[Severed_Infinity]

  On 6/30/2018 at 3:22 PM, Draco18s said:

Also:

• IHasModel is stupid. All items need models. ALL ITEMS.
• ModelRegistryEvent is client side only. This will crash the dedicated server.
• This can be done externally (i.e. not inside the class) just fine: Technium.proxy.registerItemRender(item, 0, "inventory");
• If your item classes look like this, you don't need them at all.
• The fuck? You used the IProxy interface (good) method and a common proxy (bad)?

Expand  

Based a lot of that off of the most recent mod tutorials I could find.

[Severed_Infinity]

  On 6/30/2018 at 12:06 PM, diesieben07 said:

FMLLog is deprecated. Use your own log as described in the class' Javadoc. Also, don't spam the log like that. Nobody cares that your pre init completed. FML already logs this. If you want to log it, don't do it at info level.

Expand  

this is more for me, which I can remove at a later date.

  On 6/30/2018 at 12:06 PM, diesieben07 said:

"tn" is a terrible mod id. Make it longer.

Expand  

just going by what I've seen in the past, present, and documentation that I've found.

[Draco18s]

  On 6/30/2018 at 9:52 PM, Severed_Infinity said:

Based a lot of that off of the most recent mod tutorials I could find

Expand  

Just because it's a tutorial doesn't mean it's "right" or "best." In fact, most Minecraft modding tutorials are written by people who don't actually know what they're doing, but they managed to cobble something together that appears to work, so they did a video about it...as evidenced by comments like this one:

  On 6/30/2018 at 9:53 PM, Severed_Infinity said:

just going by what I've seen in the past, present, and documentation that I've found.

Expand  

1) See prior comments

2) Mod IDs can be pretty long. Not super long, but certainly long enough for "technium" (it's eight characters, if that was too long we'd have run out of possible mod IDs already!) Edit: the limit is 64 characters.

3) What D7 said.

Edited June 30, 2018 by Draco18s

[Severed_Infinity]

  On 6/30/2018 at 9:57 PM, diesieben07 said:

I seriously hope there are no tutorials that tell people to use a two-letter mod ID. A mod ID is meant to be unique. "tn" is not very unique, it could be the abbreviation for tons of things.

Expand  

 

  On 6/30/2018 at 9:58 PM, Draco18s said:

1) See prior comments

2) Mod IDs can be pretty long. Not super long, but certainly long enough for "technium" (it's eight characters, if that was too long we'd have run out of possible mod IDs already!) Edit: the limit is 64 characters.

3) What D7 said.

Expand  

I did not know that, thanks for letting me know.
I've been watching lore's videos recently but i see what you mean

[Severed_Infinity]

UPDATE: after making some of the suggested changes you guys mention I found when loading up I got an error screen to say my item could not be found (due to obvious reasons like changing modid) but I found that my item was listed as "minecraft:item:tn:ingot_copper" instead of "tn:ingot_copper" (or rather should be now "technium:ingot_copper").

[Draco18s]

  On 7/1/2018 at 8:22 AM, Severed_Infinity said:

I've been watching lore's videos recently but i see what you mean

Expand  

Mhm. I gathered.

[Severed_Infinity]

  On 7/1/2018 at 1:43 PM, diesieben07 said:

Please update your Git repository.

Expand  

I've done so, was out for most of the day only got around to it now. the duplicate item issue is gone now but now the texture doesn't render.

I took your advice and I believe I rewrote most the code in a better way but again I could be entirely wrong.

[Severed_Infinity]

So it is, such a small thing I overlooked. I'm an idiot! thanks.