Need to get block Data Value

[TastyCake]

So in an event, I need to get the block that gets left-clicked and then drop it and make it disappear from the world. This works but when I left-click, on, for example, a log of a type other than oak, it just drops oak. This happens with stone and andesite too. So what I need is to get the Data Value that determines the block sub-type. Here is my code

Thanks for any help you can provide!

[Animefan8888]

Just now, TastyCake said:

So in an event, I need to get the block that gets left-clicked and then drop it and make it disappear from the world. This works but when I left-click, on, for example, a log of a type other than oak, it just drops oak. This happens with stone and andesite too. So what I need is to get the Data Value that determines the block sub-type. Here is my code

Thanks for any help you can provide!

Block#getPickBlock(IBlockState, RayTraceResult, World, BlockPos, EntityPlayer)

[TastyCake]

Sorry for my ignorance but how am I supposed to use this? And where do I get the RayTraceResult? Thanks!

[jabelar]

The easier fix is just to use the right constructor.  In your code you have

 

ItemStack(event.getBlockState().getBlock)

 

But instead you should replace it with something like:

 

ItemStack(event.getBlockState().getBlock(), 1, event.getBlockState().getBlock().getMetaFromBlockState(event.getBlockState()))

 

[Animefan8888]

1 minute ago, TastyCake said:

Sorry for my ignorance but how am I supposed to use this?

First off, are you trying to get the full drops of the block, or just the block itself?

If the later Block#getPickBlock will return the block as an itemstack as it's respective type, IE oak to oak, spruce to spruce. You can get the raytrace result by creating a new instance from the data passed into the event.

 

If it is the former then you should call Block#getDrops(NonNullList<ItemStack>, IBlockAccess, BlockPos, int) which will add the blocks drops to the NonNullList you pass in.

[Animefan8888]

1 minute ago, jabelar said:

ItemStack(event.getBlockState().getBlock(), 1, event.getBlockState().getBlock().getMetaFromBlockState(event.getBlockState()))

This is not true, this will not work in all cases, blocks and items may have different metadata, and there are blocks that have more metadata than items, IE logs.

[jabelar]

7 minutes ago, Animefan8888 said:

This is not true, this will not work in all cases, blocks and items may have different metadata, and there are blocks that have more metadata than items, IE logs.

Okay, then it should be:

 

        ItemStack(Item.getItemFromBlock(event.getBlockState().getBlock()), 1, this.damageDropped(event.getBlockState()));
 

I guess you're right the damageDropped can be different than the blocks meta. 

Edited July 22, 2018 by jabelar

[TastyCake]

Jabelar's method seems to work with logs and stone types but leaves have no texture when broken and have incorrect data values. Also, everything seems to drop twice, but only one instance can be picked up and the other instance is removed on re-login

 

Edit: I missed Jabelar's new reply. Will try it and report back

Edited July 22, 2018 by TastyCake

[TastyCake]

So I tried Jabelar's new method and it fixed the leaf issue. The problem with the block dropping twice is still there and still, only one instance of the drop can be picked up.

[Draco18s]

18 minutes ago, jabelar said:

But instead you should replace it with something like:

 

ItemStack(event.getBlockState().getBlock(), 1, event.getBlockState().getBlock().getMetaFromBlockState(event.getBlockState()))

No. Use this:

 

ItemStack stack = event.getBlockState().getPickBlock(state, null, world, pos, player)

Pass a raytraceresult if you can, but no vanilla blocks use it and its highly unlikely that any mod block will either.

8 minutes ago, TastyCake said:

but leaves have no texture

That's because you should never be calling getMetaFromState() yourself. Leaves have data values that are for decay that are not relevant to the resulting item. Similarly wool blocks have metadata values that are backwards from their item form.

Edited July 22, 2018 by Draco18s

[jabelar]

getPickBlock() uses the same code I posted in my corrected suggestion. That is the function that sorts out which metadata should be passed to item. For some blocks like flowers it might be the same for both damage dropped and metadata, but for others like logs the orientation doesn't need to pass into the item.

[Animefan8888]

4 minutes ago, TastyCake said:

The problem with the block dropping twice is still there and still, only one instance of the drop can be picked up.

Only spawn the entity on the server, !world.isRemote

Also,

4 minutes ago, Draco18s said:

ItemStack stack = event.getBlockState().getPickBlock(state, null, world, pos, player)

Pass a raytraceresult if you can, but no vanilla blocks use it and its highly unlikely that any mod block will either. 

Or,

35 minutes ago, Animefan8888 said:

Block#getPickBlock(IBlockState, RayTraceResult, World, BlockPos, EntityPlayer)

 

22 minutes ago, Animefan8888 said:

If the later Block#getPickBlock will return the block as an itemstack as it's respective type, IE oak to oak, spruce to spruce. You can get the raytrace result by creating a new instance from the data passed into the event.

 

[Animefan8888]

1 minute ago, jabelar said:

getPickBlock() uses the same code I posted in my corrected suggestion. That is the function that sorts out which metadata should be passed to item. For some blocks like flowers it might be the same for both damage dropped and metadata, but for others like logs the orientation doesn't need to pass into the item.

But there are also modded blocks.

[TastyCake]

Ok. All the issues are fixed. Thanks for all your help!

[jabelar]

1 minute ago, Animefan8888 said:

But there are also modded blocks.

Modded blocks should always override the damaged block return value. If your modded blocks have properties but don't do that then they won't work right as item blocks.

[jabelar]

17 minutes ago, diesieben07 said:

This is BS.

The only way to obtain the drops of a block is to call getDrops. Do not call any other method.

The only way to obtain a "exact representation" of a block as an item is getPickBlock. Do not call any other method.

Do not interact with other people's metadata. Do not pass go, do not collect $200.

It is not BS at all. 

 

The getPickBlock() relies on damage dropped method. The code I posted is from that actual method. I didn't make it up. If you don't override the damage dropped method in your modded block, getPickBlock() will not work for you.

 

Here's the code calls directly from source:

    public ItemStack getPickBlock(IBlockState state, RayTraceResult target, World world, BlockPos pos, EntityPlayer player)
    {
        return getItem(world, pos, state);
    }

    public ItemStack getItem(World worldIn, BlockPos pos, IBlockState state)
    {
        return new ItemStack(Item.getItemFromBlock(this), 1, this.damageDropped(state));
    }

 

Edited July 22, 2018 by jabelar

[jabelar]

1 minute ago, diesieben07 said:

getPickBlock is a forge-added method. The default implementation is suitable for vanilla blocks, so that not all vanilla blocks need to implement it. Mods can override this method to do whatever they want. Completely independent of any other methods. damageDropped is a vanilla-legacy crap thing.

 

The reality is a lot of modders are going to copy vanilla blocks or extend them. They will see that the getDrops() methods call the damageDropped() method. I feel that people will continue to use damageDropped() because the same logic (of converting select properties to metadata) is needed in two places - for getDrops() and for getPickBlock(). If you have code/logic needed in two places isn't it good practice to have a common method to contain it?

 

You're right though that the recommended way should be to use getDrops() and getPickBlock(). But I don't think damage dropped is legacy crap -- it is a legitimate place to put the state conversion.

 

 

[jabelar]

8 minutes ago, diesieben07 said:

It is legacy crap because it is a public method. Methods like this should be private implementation details of a particular block.

 

Yep, there's a lot of that in Minecraft modding...

[Draco18s]

1 hour ago, diesieben07 said:

You as a caller should not care about this.

This. Always this.

You, as a caller, should not care what the implementation is, only that it does what it says it does. You cannot, and should not ever, "take shortcuts" because of what the implementation does.