Jump to content

Recommended Posts

Posted
  On 8/7/2018 at 10:06 AM, diesieben07 said:

Show what you tried.

Expand  
package com.mairwunnx.mnxemeralds.blocks;

import net.minecraft.block.Block;
import net.minecraft.block.BlockWall;

public class emeraldwall extends BlockWall
{
    public emeraldwall(String name, float resistance, float hardness, Block modelBlock)
    {
        super(modelBlock);
        setUnlocalizedName(name);
        setRegistryName(name);
        setResistance(resistance);
        setHardness(hardness);
        this.useNeighborBrightness = true;
        setLightLevel(20.0F);
    }
}

 

it's Emerald Wall class.

 

But, i don't know as call emeraldwall method.

 

public static Block KEY4 = new emeraldwall("emerald_wall", 13.5F, 20.0F, ??? ).setCreativeTab(defaultModTab);

 

 ? ? ? - I do not know what argument to put, i try other blocks, e.g KEY1 (is emerald_hardness_block), But then in the tab with the mod, I have two blocks.

Posted
  On 8/7/2018 at 10:18 AM, diesieben07 said:
  • Problematic code, issue 10 and 14.
  • modelBlock tells BlockWall it's properties (like hardness, resistance, etc.), that's all.
  • Show more of your code.

Expand  

yes, but what put to modelBlock? BlockWall not work, and other blocks not work. 

 

in BlockWall class i find it:image.png.77cf6bf1af75b65139d340247d0c9d98.png

 

But, what is it blockMaterial? It's don't work.

 

More code:

 

emeraldwall class:

 

package com.mairwunnx.mnxemeralds.blocks;

import net.minecraft.block.Block;
import net.minecraft.block.BlockWall;

public class emeraldwall extends BlockWall
{
    public emeraldwall(String name, float resistance, float hardness, Block modelBlock)
    {
        super(modelBlock);
        setUnlocalizedName(name);
        setRegistryName(name);
        setResistance(resistance);
        setHardness(hardness);
        this.useNeighborBrightness = true;
        setLightLevel(20.0F);
    }
}

 

blockregister class:

 

package com.mairwunnx.mnxemeralds.registers;

import com.mairwunnx.mnxemeralds.blocks.*;
import net.minecraft.block.Block;
import net.minecraft.block.BlockStairs;
import net.minecraft.block.BlockWall;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraftforge.fml.common.registry.ForgeRegistries;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

import static com.mairwunnx.mnxemeralds.mnxemeralds.defaultModTab;

public class blockregister
{
    public static Block KEY = new emeraldhardblock("emerald_hard_block").setCreativeTab(defaultModTab);
    public static Block KEY1 = new emeraldfence("emerald_fence", 13.5F, 20.0F).setCreativeTab(defaultModTab);
    public static Block KEY2 = new emeraldhalfslab("emerald_slab", 13.5F, 20.0F).setCreativeTab(defaultModTab);
    public static Block KEY3 = new emeraldstairs("emerald_stairs", 13.5F, 20.0F, KEY.getDefaultState()).setCreativeTab(defaultModTab);
    public static Block KEY4 = new emeraldwall("emerald_wall", 13.5F, 20.0F, ???).setCreativeTab(defaultModTab);

    public static void register()
    {
        setRegister(KEY);
        setRegister(KEY1);
        setRegister(KEY2);
        setRegister(KEY3);
        setRegister(KEY4);
    }

    @SideOnly(Side.CLIENT)
    public static void registerRender()
    {
        setRender(KEY);
        setRender(KEY1);
        setRender(KEY2);
        setRender(KEY3);
        setRender(KEY4);
    }

    private static void setRegister(Block block)
    {
        ForgeRegistries.BLOCKS.register(block);
        ForgeRegistries.ITEMS.register(new ItemBlock(block).setRegistryName(block.getRegistryName()));
    }

    @SideOnly(Side.CLIENT)
    private static void setRender(Block block)
    {
        Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(Item.getItemFromBlock(block), 0, new ModelResourceLocation(block.getRegistryName(), "inventory"));
    }
}

 

 

Posted (edited)

UPD: i fixed naming, i make, all norm, but ... tow block still is..... 

 

left - normal, right also normal, but with out texture and still is.

 

two block caused:  100%

Block modelBlock

 

image.thumb.png.a1ac88a809440455d97530e830d3e66d.png

 

Logs: debug.log

 

Edited by MairwunNx
Posted
  On 8/7/2018 at 2:57 PM, diesieben07 said:

I have no idea what your question is.

Expand  

Sorry, i use google translate. Then how do I make a wall with what I have?

It is fully working and visible, but I interfere with the extra block.

 

I also try replace code: 

 

    public void getSubBlocks(CreativeTabs itemIn, NonNullList<ItemStack> items)
    {
        for (BlockWall.EnumType blockwall$enumtype : BlockWall.EnumType.values())
        {
            items.add(new ItemStack(this, 1, blockwall$enumtype.getMetadata()));
        }
    }

 

on:

 

    public void getSubBlocks(CreativeTabs itemIn, NonNullList<ItemStack> items)
    {
        for (BlockWall.EnumType blockwall$enumtype : BlockWall.EnumType.values())
        {
            items.add(new ItemStack(this, 0, blockwall$enumtype.getMetadata()));
        }
    }

 

But it remove all my wall blocks of tab. But walls available on game with help recipes or command give.

Posted
  On 8/7/2018 at 3:03 PM, MairwunNx said:

items.add(new ItemStack(this, 0, blockwall$enumtype.getMetadata()));

Expand  

You told the game that your subblocks are stack size 0 (and thus, air). I don't think that's what you wanted.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

You shouldn't have even needed to try.

For on, the method parameters are well labled and for two, the third parameter already being passed has a getMetadata() call. GOSH I WONDER WHAT THAT IS FOR.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
  On 8/7/2018 at 3:47 PM, Draco18s said:

You shouldn't have even needed to try.

For on, the method parameters are well labled and for two, the third parameter already being passed has a getMetadata() call. GOSH I WONDER WHAT THAT IS FOR.

Expand  

Ok, sorry i don't understand it's ?

 

For on, the method parameters are well labled and for two, the third parameter already being passed has a getMetadata() call.

Posted
  On 8/7/2018 at 4:59 PM, MairwunNx said:

I need help please :( 

Expand  

Do you know what metadata is? I assume that google translate is mangling it so.

Metadata = https://minecraft.gamepedia.com/Java_Edition_data_values

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
  On 8/8/2018 at 4:46 AM, Cadiboo said:

Do you know what metadata is? I assume that google translate is mangling it so.

Metadata = https://minecraft.gamepedia.com/Java_Edition_data_values

Expand  

setMetadata(<value>) sets the data

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
  On 8/8/2018 at 9:07 AM, MairwunNx said:

How it use? please

Expand  

 

  On 8/7/2018 at 3:47 PM, Draco18s said:

You shouldn't have even needed to try.

For on, the method parameters are well labled and for two, the third parameter already being passed has a getMetadata() call. GOSH I WONDER WHAT THAT IS FOR.

Expand  

 

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
  On 8/8/2018 at 9:27 AM, MairwunNx said:

 

I try call getMetadata() and return null or 0 or 1, it's not work or i stupid? 

Expand  

did you read the article and/or anything you were told? As a general rule, if your item doesn't have subtypes its metadata is 0. Not 1 and definitely not null (Are integers even allowed to be null?)

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
  On 8/8/2018 at 9:30 AM, Cadiboo said:

did you read the article and/or anything you were told? As a general rule, if your item doesn't have subtypes its metadata is 0. Not 1 and definitely not null (Are integers even allowed to be null?)

Expand  

I feel a little stupid. :), If it doesn't have subtypes and I return 0, then I shouldn't have the second block?

 

 image.png.5d372567fb34d1e0cb4d4e35fd355712.png

Posted (edited)
  On 8/8/2018 at 9:35 AM, MairwunNx said:

I feel a little stupid. :), If it doesn't have subtypes and I return 0, then I shouldn't have the second block?

 

 image.png.5d372567fb34d1e0cb4d4e35fd355712.png

Expand  

this code has me screaming for at least 7 reasons

1) naming conventions

2) someone said not to extend block wall

3) I assume resistance doesn't change? and that your not creating multiple instances of the block? then hardcode it

4) same as resistance but for hardness

5) why is unlocalised name before registry name,

6) not that it matters, they should be in a different class (your base mod block class)

7) why are you calling getMetadata?

8) why are you overriding getMetadata?

9) assuming getMetadata actually did something useful, why aren't you doing anything with the returned value?

10) wheres your @Override annotation? its important

Edited by Cadiboo

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • does anyone know how to incorporate custom noise settings into a custom dimension through the use of datagen, I have created a custon json file for the noise settings that I want but I just don't know how to get it to register with the generated json file of the custom dimension.   here is the code for the dimension class package net.hurst.lustria.worldgen.dimension; import com.mojang.datafixers.util.Pair; import net.hurst.lustria.Lustria; import net.hurst.lustria.worldgen.biome.ModBiomes; import net.hurst.lustria.worldgen.registries.LustriaNoiseSettings; import net.minecraft.core.HolderGetter; import net.minecraft.core.registries.Registries; import net.minecraft.data.worldgen.BootstapContext; import net.minecraft.resources.ResourceKey; import net.minecraft.resources.ResourceLocation; import net.minecraft.tags.BlockTags; import net.minecraft.util.valueproviders.ConstantInt; import net.minecraft.world.level.Level; import net.minecraft.world.level.biome.*; import net.minecraft.world.level.dimension.BuiltinDimensionTypes; import net.minecraft.world.level.dimension.DimensionType; import net.minecraft.world.level.dimension.LevelStem; import net.minecraft.world.level.levelgen.NoiseBasedChunkGenerator; import net.minecraft.world.level.levelgen.NoiseGeneratorSettings; import java.util.List; import java.util.OptionalLong; public class ModDimensions { public static final ResourceKey<LevelStem> LUSTRIA_KEY = ResourceKey.create(Registries.LEVEL_STEM, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim")); public static final ResourceKey<Level> LUSTRIA_LEVEL_KEY = ResourceKey.create(Registries.DIMENSION, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim")); public static final ResourceKey<DimensionType> LUSTRIA_DIM_TYPE = ResourceKey.create(Registries.DIMENSION_TYPE, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim_type")); public static void bootstrapType(BootstapContext<DimensionType> context) { context.register(LUSTRIA_DIM_TYPE, new DimensionType( OptionalLong.of(12000), // fixedTime false, // hasSkylight true, // hasCeiling false, // ultraWarm false, // natural 1.0, // coordinateScale true, // bedWorks false, // respawnAnchorWorks -64, // minY 256, // height 256, // logicalHeight BlockTags.INFINIBURN_OVERWORLD, // infiniburn BuiltinDimensionTypes.OVERWORLD_EFFECTS, // effectsLocation 0.0f, // ambientLight new DimensionType.MonsterSettings(false, false, ConstantInt.of(0), 0))); } public static void bootstrapStem(BootstapContext<LevelStem> context) { HolderGetter<Biome> biomeRegistry = context.lookup(Registries.BIOME); HolderGetter<DimensionType> dimTypes = context.lookup(Registries.DIMENSION_TYPE); HolderGetter<NoiseGeneratorSettings> noiseGenSettings = context.lookup(Registries.NOISE_SETTINGS); NoiseBasedChunkGenerator wrappedChunkGenerator = new NoiseBasedChunkGenerator( new FixedBiomeSource(biomeRegistry.getOrThrow(Biomes.BEACH)), noiseGenSettings.getOrThrow(NoiseGeneratorSettings.CAVES)); NoiseBasedChunkGenerator noiseBasedChunkGenerator = new NoiseBasedChunkGenerator( MultiNoiseBiomeSource.createFromList( new Climate.ParameterList<>(List.of(Pair.of( Climate.parameters(0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.BEACH)), Pair.of( Climate.parameters(0.1F, 0.2F, 0.0F, 0.2F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.BIRCH_FOREST)), Pair.of( Climate.parameters(0.3F, 0.6F, 0.1F, 0.1F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.OCEAN)), Pair.of( Climate.parameters(0.4F, 0.3F, 0.2F, 0.1F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.DARK_FOREST)) ))), noiseGenSettings.getOrThrow(NoiseGeneratorSettings.CAVES)); LevelStem stem = new LevelStem(dimTypes.getOrThrow(ModDimensions.LUSTRIA_DIM_TYPE), noiseBasedChunkGenerator); context.register(LUSTRIA_KEY, stem); } } minecraft version is 1.20.1
    • Please read the FAQ (https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/) and post logs as described there using a site like https://mclo.gs and post the link to it here. It may have the information required to solve your problem.  
    • the error code comes up when i trry to run it and ive tried to fix it but i cant  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.