slow loading.... ore gen efficiency needed

reapersremorse · August 13, 2018

hello, can anyone help me make my ore gen more efficient?
i am using some mods for ease and comparisons for values and such.
mods list
jei_1.12.2-4.11.0.206
jepb-1.12-1.12.1
journeymap-1.12.2-5.5.2
justenoughbuttons-1.12.2-1.2.2-5
mantle-1.12-1.3.2.24

moartinkers-0.6.0

projecte-1.12-pe1.3.0

tconstruct-1.12.2-2.10.1.87
veinminer-1.12-0.38.2+b31535a
my mod (UTO-Mod-0.5.3)

reason for posting, it takes quite a bit for my world to load, ive played with many mods with a great deal of mods and usually modpacks that add a lot of ores, and i never had to load a world for this long
my ore gen code, loading an instance is no problem, with this invironment it only takes me 30 seconds to load from hitting play, till it gets to the title screen. so thats not a problem

but when i clock create world, it takes 2:48 in order to get to the menu screen,(i was tabbed out so it went to menu screen)
noticable chunk gen lag aswell, ive played with many mods adding way more ored than this and had no where near as much loading lag as this.
anyone have any suggenstions??

package com.reapersremorse.uto.prefabs.worldgen;

import com.reapersremorse.uto.init.blocks.InitiateBlocks.BasicBlockRegistry;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.IChunkGenerator;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.fml.common.IWorldGenerator;

import java.util.Random;

public class OreGen implements IWorldGenerator {


    private static WorldGenerator T0;
    private static WorldGenerator T1;
    private static WorldGenerator T2;
    private static WorldGenerator T3;
    private static WorldGenerator T4;
    private static WorldGenerator T5;
    private static WorldGenerator T6;
    private static WorldGenerator T7;
    private static WorldGenerator T8;
    private static WorldGenerator T9;
    private static WorldGenerator T10;
    private static WorldGenerator T11;
    private static WorldGenerator T12;
    private static WorldGenerator T13;
    private static WorldGenerator T14;
    public static WorldGenerator T15;


    public OreGen() {

        T0 = new WorldGenMinable(BasicBlockRegistry.T0ORE.getDefaultState(),3);
        T1 = new WorldGenMinable(BasicBlockRegistry.T1ORE.getDefaultState(),3);
        T2 = new WorldGenMinable(BasicBlockRegistry.T2ORE.getDefaultState(),3);
        T3 = new WorldGenMinable(BasicBlockRegistry.T3ORE.getDefaultState(),3);
        T4 = new WorldGenMinable(BasicBlockRegistry.T4ORE.getDefaultState(),3);
        T5 = new WorldGenMinable(BasicBlockRegistry.T5ORE.getDefaultState(),3);
        T6 = new WorldGenMinable(BasicBlockRegistry.T6ORE.getDefaultState(),3);
        T7 = new WorldGenMinable(BasicBlockRegistry.T7ORE.getDefaultState(),3);
        T8 = new WorldGenMinable(BasicBlockRegistry.T8ORE.getDefaultState(),3);
        T9 = new WorldGenMinable(BasicBlockRegistry.T9ORE.getDefaultState(),3);
        T10 = new WorldGenMinable(BasicBlockRegistry.T10ORE.getDefaultState(),3);
        T11 = new WorldGenMinable(BasicBlockRegistry.T11ORE.getDefaultState(),3);
        T12 = new WorldGenMinable(BasicBlockRegistry.T12ORE.getDefaultState(),3);
        T13 = new WorldGenMinable(BasicBlockRegistry.T13ORE.getDefaultState(),3);
        T14 = new WorldGenMinable(BasicBlockRegistry.T14ORE.getDefaultState(),3);
        T15 = new WorldGenMinable(BasicBlockRegistry.T15ORE.getDefaultState(),3);

    }

    public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

        switch(world.provider.getDimension()) {
            //overworld
            case 0:

                runGenerator(T0, world, random, chunkX, chunkZ, 100, 60, 64);
                runGenerator(T1, world, random, chunkX, chunkZ, 80, 56, 60);
                runGenerator(T2, world, random, chunkX, chunkZ, 75, 52, 56);
                runGenerator(T3, world, random, chunkX, chunkZ, 70, 48, 52);
                runGenerator(T4, world, random, chunkX, chunkZ, 65, 44, 48);
                runGenerator(T5, world, random, chunkX, chunkZ, 60, 40, 44);
                runGenerator(T6, world, random, chunkX, chunkZ, 55, 36, 40);
                runGenerator(T7, world, random, chunkX, chunkZ, 50, 32, 36);
                runGenerator(T8, world, random, chunkX, chunkZ, 45, 28, 32);
                runGenerator(T9, world, random, chunkX, chunkZ, 40, 24, 28);
                break;
            //end
            case 1:
                runGenerator(T14, world, random, chunkX, chunkZ, 100, 6, 128);
                runGenerator(T15, world, random, chunkX, chunkZ, 100, 6, 128);
                break;
            //Nether
            case -1:
                runGenerator(T10, world, random, chunkX, chunkZ, 50, 65, 69);
                runGenerator(T11, world, random, chunkX, chunkZ, 45, 70, 74);
                runGenerator(T12, world, random, chunkX, chunkZ, 40, 75, 79);
                runGenerator(T13, world, random, chunkX, chunkZ, 35, 80, 84);
                runGenerator(T14, world, random, chunkX, chunkZ, 30, 85, 89);
                runGenerator(T15, world, random, chunkX, chunkZ, 25, 90, 94);
                break;
        }

    }


    private void runGenerator(WorldGenerator gen, World world, Random rand, int chunkX, int chunkZ, int chance, int minHeight, int maxHeight) {

        if(minHeight > maxHeight || minHeight < 0 || maxHeight > 256) throw new IllegalArgumentException("Ore Generated Out of Bounds");
        int heighDiff = maxHeight - minHeight + 1;

        for(int i = 0; i < chance; i++) {
            int x = chunkX * 16 + rand.nextInt(16);
            int y = minHeight + rand.nextInt(heighDiff);
            int z = chunkZ * 16 + rand.nextInt(16);

            gen.generate(world, rand, new BlockPos(x, y, z));
        }
    }
}

Animefan8888 · August 13, 2018

14 minutes ago, reapersremorse said:

runGenerator(T0, world, random, chunkX, chunkZ, 100, 60, 64);

14 minutes ago, reapersremorse said:

for(int i = 0; i < chance; i++) {

I wonder what these two lines are doing?

reapersremorse · August 13, 2018

first line, its running the random generation at a 100%chance to spawn at least once between y level 60 and 64

second line, it should be setting an int, then saying if that int is for which ever world, then spawn in that world at the y levels specified in the first line

-1,0,1 for worlds

Edited August 13, 2018 by reapersremorse
i mispelled and forgot something

Animefan8888 · August 13, 2018

9 minutes ago, reapersremorse said:

first line, its running the random generation at a 100%chance to spawn at least once between y level 60 and 64

Did you write the code for runGenerator? Did you read it? Because if you did you need to learn java or read it again. Your actually telling it to generate a batch of 3 or 100 times per chunk. Between y 69 and 64.

reapersremorse · August 13, 2018

T0 = new WorldGenMinable(BasicBlockRegistry.T0ORE.getDefaultState(),3);

in this line, im setting the block to spawn, and how many blocks per vein. this is 3 blocks per vein

runGenerator(T0, world, random, chunkX, chunkZ, 100, 60, 64);

int 100 = chance to spawn, int 60 is min height, int 64 is max height.
the case statement uses the code in WorldProvider.java in minecraft

for(int i = 0; i < chance; i++) {

are you referring to the portion of code that has the i++
if so, i couldnt get the game to run without doing that, i do not see the 100x spawn you are talking about. and this i++ is the only mention of 3x in any of the math.

for(int i = 0; i < chance; i++) {
    int x = chunkX * 16 + rand.nextInt(16);
    int y = minHeight + rand.nextInt(heighDiff);
    int z = chunkZ * 16 + rand.nextInt(16);

    gen.generate(world, rand, new BlockPos(x, y, z));
}

this whole portion of code should be making the ore generate in the chunk at a random interval with a chance of atleast 1 spawn and 3 blocks per vein with a random built into the vein size. and it sets the chunk size and uses the function built above this portion of code in order to tell what y level to spawn between.

Animefan8888 · August 13, 2018

7 minutes ago, reapersremorse said:
for(int i = 0; i < chance; i++) {

This line of code will run the code inside of the {} until i >= to chance. And i++ while add one to i every time it is ran. So this will call

7 minutes ago, reapersremorse said:

int x = chunkX * 16 + rand.nextInt(16); int y = minHeight + rand.nextInt(heighDiff); int z = chunkZ * 16 + rand.nextInt(16); gen.generate(world, rand, new BlockPos(x, y, z));

chance amount of times.

For loop

Edited August 13, 2018 by Animefan8888

reapersremorse · August 13, 2018

oh my, i misunderstood completely, i was under the impression the random function from java was looking to see what chance to spawn once was. i didnt realize i was telling it to spawn 100x i should have looked at that random function in java a bit closer. thank you

Animefan8888 · August 13, 2018

7 minutes ago, reapersremorse said:

oh my, i misunderstood completely, i was under the impression the random function from java was looking to see what chance to spawn once was.

This has nothing to do with the random function from java.

7 minutes ago, reapersremorse said:

i didnt realize i was telling it to spawn 100x

12 minutes ago, Animefan8888 said:

For loop

Edited August 13, 2018 by Animefan8888

reapersremorse · August 13, 2018

yeah i just figured that out when i saw your explanation.

reapersremorse · August 13, 2018

ive changed my chance on all 16 ores, now it loads from world creation in 26.5 seconds.

switch(world.provider.getDimension()) {
    //overworld
    case 0:

        runGenerator(T0, world, random, chunkX, chunkZ, 15, 60, 64);
        runGenerator(T1, world, random, chunkX, chunkZ, 12, 56, 60);
        runGenerator(T2, world, random, chunkX, chunkZ, 11, 52, 56);
        runGenerator(T3, world, random, chunkX, chunkZ, 10, 48, 52);
        runGenerator(T4, world, random, chunkX, chunkZ, 9, 44, 48);
        runGenerator(T5, world, random, chunkX, chunkZ, 8, 40, 44);
        runGenerator(T6, world, random, chunkX, chunkZ, 7, 36, 40);
        runGenerator(T7, world, random, chunkX, chunkZ, 6, 32, 36);
        runGenerator(T8, world, random, chunkX, chunkZ, 5, 28, 32);
        runGenerator(T9, world, random, chunkX, chunkZ, 4, 24, 28);
        break;
    //end
    case 1:
        runGenerator(T14, world, random, chunkX, chunkZ, 10, 6, 128);
        runGenerator(T15, world, random, chunkX, chunkZ, 10, 6, 128);
        break;
    //Nether
    case -1:
        runGenerator(T10, world, random, chunkX, chunkZ, 8, 65, 69);
        runGenerator(T11, world, random, chunkX, chunkZ, 7, 70, 74);
        runGenerator(T12, world, random, chunkX, chunkZ, 6, 75, 79);
        runGenerator(T13, world, random, chunkX, chunkZ, 5, 80, 84);
        runGenerator(T14, world, random, chunkX, chunkZ, 4, 85, 89);
        runGenerator(T15, world, random, chunkX, chunkZ, 3, 90, 94);
        break;
}

Animefan8888 · August 13, 2018

20 minutes ago, reapersremorse said:

runGenerator(T0, world, random, chunkX, chunkZ, 15, 60, 64);

This would still be too much. This would be 15 veins of approximately 3 blocks between y values 60-64.

20 minutes ago, reapersremorse said:

runGenerator(T1, world, random, chunkX, chunkZ, 12, 56, 60);

This would still be too much. This would be 12 veins of approximately 3 blocks between y values 56-60.

All per chunk.

Edited August 13, 2018 by Animefan8888

reapersremorse · August 13, 2018

i used a catalyst from projecte and i mined out a 67x67x9 area and i have
231 iron ore
109 tier0 ore(my mod)

27 tier 1
in my mod, iron is technically tier 2 ore. ill lower the values a bit, ut i would like t0 to have the highest count of all my ores and i do not want them to be impossible to find

y level at the top is 64
y level at the bottom is 58

my aim is to make it so no matter what biome you start in, you do not need wood and you do not need iron to start. my t0 is basically a throwaway ore, it only mines at hand level (0) but its much faster and has infinate durability. it will have ok armor that will protect against knockback hopefully but it will be basic, im also making it so you need the previous tier to make the next one so you will need a lot of this ore in the future. especially when i get into making machines.

if you believe this is still too op i can change it to be lower, im not good at judging these values yet. i also do not want to impeed on other ore generation from other mods...

Animefan8888 · August 13, 2018

6 minutes ago, reapersremorse said:

i also do not want to impeed on other ore generation from other mods...

It will most likely do this.

reapersremorse · August 13, 2018

ill lower the chance and up the vein count.

Cadiboo · August 13, 2018

2 hours ago, reapersremorse said:

ill lower the chance and up the vein count.

Can I suggest upping the chance (a lot) and lowering the vein count and vein size?

Animefan8888 · August 13, 2018

1 minute ago, Cadiboo said:

Can I suggest upping the chance (a lot)

The chance variable means how many possible chances the vein has to spawn in a chunk, not a percent chance.

reapersremorse · August 13, 2018

i initally thaught it was a % chance built into random, butanimefan8888 made me realize it a spawning random loop, the higher the number, the more times it passes to spawn more veins

reapersremorse · August 13, 2018

i do not know what values i want to add but i have it where the world loads in about 25 seconds

Animefan8888 · August 13, 2018

1 minute ago, reapersremorse said:

i do not know what values i want to add but i have it where the world loads in about 25 seconds

If you want to decrease this you could increase the vein size, and decrease the chances to spawn in a chunk.

Cadiboo · August 13, 2018

3 minutes ago, Animefan8888 said:

The chance variable means how many possible chances the vein has to spawn in a chunk, not a percent chance.

I meant upping the percentage chance, sorry.

This can be done by upping the chance variable, but you should do this by having a low chance variable (between 5-15 for all ores I recommend) and a low vein count & vein size (this also lessens the chance of cascading world-get from large veins going into neighbouring chunks). Thats personal preference though, I like to have rare, small deposits of high value ores. If you want something else, have a look at granite generation, iron generation & lapis generation. They're in the class

net.minecraft.world.biome.BiomeDecorator [lines: 106 - 118] - decorate(World, Random, Biome, BlockPos)

reapersremorse · August 13, 2018

6 minutes ago, Animefan8888 said:

The chance variable means how many possible chances the vein has to spawn in a chunk, not a percent chance.

my inital post was loading the oregen in 2:48
my system is as follows
amd Ryzen 7 2700x eight core
32gigs (7271mb allocated to minecraft)

gforce gtx 1060 6gb gpu

the fact that it took that long is insane
this is what i changed it to and i havent looked in world yet, ill need to tweak it till its right.

package com.reapersremorse.uto.prefabs.worldgen;

import com.reapersremorse.uto.init.blocks.InitiateBlocks.BasicBlockRegistry;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.IChunkGenerator;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.fml.common.IWorldGenerator;

import java.util.Random;

public class OreGen implements IWorldGenerator {


    private static WorldGenerator T0;
    private static WorldGenerator T1;
    private static WorldGenerator T2;
    private static WorldGenerator T3;
    private static WorldGenerator T4;
    private static WorldGenerator T5;
    private static WorldGenerator T6;
    private static WorldGenerator T7;
    private static WorldGenerator T8;
    private static WorldGenerator T9;
    private static WorldGenerator T10;
    private static WorldGenerator T11;
    private static WorldGenerator T12;
    private static WorldGenerator T13;
    private static WorldGenerator T14;
    public static WorldGenerator T15;


    public OreGen() {

        T0 = new WorldGenMinable(BasicBlockRegistry.T0ORE.getDefaultState(),7);
        T1 = new WorldGenMinable(BasicBlockRegistry.T1ORE.getDefaultState(),6);
        T2 = new WorldGenMinable(BasicBlockRegistry.T2ORE.getDefaultState(),5);
        T3 = new WorldGenMinable(BasicBlockRegistry.T3ORE.getDefaultState(),4);
        T4 = new WorldGenMinable(BasicBlockRegistry.T4ORE.getDefaultState(),3);
        T5 = new WorldGenMinable(BasicBlockRegistry.T5ORE.getDefaultState(),3);
        T6 = new WorldGenMinable(BasicBlockRegistry.T6ORE.getDefaultState(),3);
        T7 = new WorldGenMinable(BasicBlockRegistry.T7ORE.getDefaultState(),3);
        T8 = new WorldGenMinable(BasicBlockRegistry.T8ORE.getDefaultState(),3);
        T9 = new WorldGenMinable(BasicBlockRegistry.T9ORE.getDefaultState(),3);
        T10 = new WorldGenMinable(BasicBlockRegistry.T10ORE.getDefaultState(),3);
        T11 = new WorldGenMinable(BasicBlockRegistry.T11ORE.getDefaultState(),3);
        T12 = new WorldGenMinable(BasicBlockRegistry.T12ORE.getDefaultState(),3);
        T13 = new WorldGenMinable(BasicBlockRegistry.T13ORE.getDefaultState(),3);
        T14 = new WorldGenMinable(BasicBlockRegistry.T14ORE.getDefaultState(),3);
        T15 = new WorldGenMinable(BasicBlockRegistry.T15ORE.getDefaultState(),3);

    }

    public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

        switch(world.provider.getDimension()) {
            //overworld
            case 0:

                runGenerator(T0, world, random, chunkX, chunkZ, 1, 60, 64);
                runGenerator(T1, world, random, chunkX, chunkZ, 1, 56, 60);
                runGenerator(T2, world, random, chunkX, chunkZ, 1, 52, 56);
                runGenerator(T3, world, random, chunkX, chunkZ, 1, 48, 52);
                runGenerator(T4, world, random, chunkX, chunkZ, 1, 44, 48);
                runGenerator(T5, world, random, chunkX, chunkZ, 1, 40, 44);
                runGenerator(T6, world, random, chunkX, chunkZ, 1, 36, 40);
                runGenerator(T7, world, random, chunkX, chunkZ, 1, 32, 36);
                runGenerator(T8, world, random, chunkX, chunkZ, 1, 28, 32);
                runGenerator(T9, world, random, chunkX, chunkZ, 1, 24, 28);
                break;
            //end
            case 1:
                runGenerator(T14, world, random, chunkX, chunkZ, 5, 6, 128);
                runGenerator(T15, world, random, chunkX, chunkZ, 5, 6, 128);
                break;
            //Nether
            case -1:
                runGenerator(T10, world, random, chunkX, chunkZ, 1, 65, 69);
                runGenerator(T11, world, random, chunkX, chunkZ, 1, 70, 74);
                runGenerator(T12, world, random, chunkX, chunkZ, 1, 75, 79);
                runGenerator(T13, world, random, chunkX, chunkZ, 1, 80, 84);
                runGenerator(T14, world, random, chunkX, chunkZ, 1, 85, 89);
                runGenerator(T15, world, random, chunkX, chunkZ, 1, 90, 94);
                break;
        }

    }


    private void runGenerator(WorldGenerator gen, World world, Random rand, int chunkX, int chunkZ, int chance, int minHeight, int maxHeight) {

        if(minHeight > maxHeight || minHeight < 0 || maxHeight > 256) throw new IllegalArgumentException("Ore Generated Out of Bounds");
        int heighDiff = maxHeight - minHeight + 1;

        for(int i = 0; i < chance; i++) {
            int x = chunkX * 16 + rand.nextInt(16);
            int y = minHeight + rand.nextInt(heighDiff);
            int z = chunkZ * 16 + rand.nextInt(16);

            gen.generate(world, rand, new BlockPos(x, y, z));
        }
    }
}

i basically did as animefan8888 said, i changed the spawn chance and upped the vein count, its at 25 seconds load time now, but it takes 24 seconds without any mods

Cadiboo · August 13, 2018

1 minute ago, reapersremorse said:

my inital post was loading the oregen in 2:48
my system is as follows
amd Ryzen 7 2700x eight core
32gigs (7271mb allocated to minecraft)

gforce gtx 1060 6gb gpu

the fact that it took that long is insane
this is what i changed it to and i havent looked in world yet, ill need to tweak it till its right.


package com.reapersremorse.uto.prefabs.worldgen;

import com.reapersremorse.uto.init.blocks.InitiateBlocks.BasicBlockRegistry;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.IChunkGenerator;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.fml.common.IWorldGenerator;

import java.util.Random;

public class OreGen implements IWorldGenerator {


    private static WorldGenerator T0;
    private static WorldGenerator T1;
    private static WorldGenerator T2;
    private static WorldGenerator T3;
    private static WorldGenerator T4;
    private static WorldGenerator T5;
    private static WorldGenerator T6;
    private static WorldGenerator T7;
    private static WorldGenerator T8;
    private static WorldGenerator T9;
    private static WorldGenerator T10;
    private static WorldGenerator T11;
    private static WorldGenerator T12;
    private static WorldGenerator T13;
    private static WorldGenerator T14;
    public static WorldGenerator T15;


    public OreGen() {

        T0 = new WorldGenMinable(BasicBlockRegistry.T0ORE.getDefaultState(),7);
        T1 = new WorldGenMinable(BasicBlockRegistry.T1ORE.getDefaultState(),6);
        T2 = new WorldGenMinable(BasicBlockRegistry.T2ORE.getDefaultState(),5);
        T3 = new WorldGenMinable(BasicBlockRegistry.T3ORE.getDefaultState(),4);
        T4 = new WorldGenMinable(BasicBlockRegistry.T4ORE.getDefaultState(),3);
        T5 = new WorldGenMinable(BasicBlockRegistry.T5ORE.getDefaultState(),3);
        T6 = new WorldGenMinable(BasicBlockRegistry.T6ORE.getDefaultState(),3);
        T7 = new WorldGenMinable(BasicBlockRegistry.T7ORE.getDefaultState(),3);
        T8 = new WorldGenMinable(BasicBlockRegistry.T8ORE.getDefaultState(),3);
        T9 = new WorldGenMinable(BasicBlockRegistry.T9ORE.getDefaultState(),3);
        T10 = new WorldGenMinable(BasicBlockRegistry.T10ORE.getDefaultState(),3);
        T11 = new WorldGenMinable(BasicBlockRegistry.T11ORE.getDefaultState(),3);
        T12 = new WorldGenMinable(BasicBlockRegistry.T12ORE.getDefaultState(),3);
        T13 = new WorldGenMinable(BasicBlockRegistry.T13ORE.getDefaultState(),3);
        T14 = new WorldGenMinable(BasicBlockRegistry.T14ORE.getDefaultState(),3);
        T15 = new WorldGenMinable(BasicBlockRegistry.T15ORE.getDefaultState(),3);

    }

    public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {

        switch(world.provider.getDimension()) {
            //overworld
            case 0:

                runGenerator(T0, world, random, chunkX, chunkZ, 1, 60, 64);
                runGenerator(T1, world, random, chunkX, chunkZ, 1, 56, 60);
                runGenerator(T2, world, random, chunkX, chunkZ, 1, 52, 56);
                runGenerator(T3, world, random, chunkX, chunkZ, 1, 48, 52);
                runGenerator(T4, world, random, chunkX, chunkZ, 1, 44, 48);
                runGenerator(T5, world, random, chunkX, chunkZ, 1, 40, 44);
                runGenerator(T6, world, random, chunkX, chunkZ, 1, 36, 40);
                runGenerator(T7, world, random, chunkX, chunkZ, 1, 32, 36);
                runGenerator(T8, world, random, chunkX, chunkZ, 1, 28, 32);
                runGenerator(T9, world, random, chunkX, chunkZ, 1, 24, 28);
                break;
            //end
            case 1:
                runGenerator(T14, world, random, chunkX, chunkZ, 5, 6, 128);
                runGenerator(T15, world, random, chunkX, chunkZ, 5, 6, 128);
                break;
            //Nether
            case -1:
                runGenerator(T10, world, random, chunkX, chunkZ, 1, 65, 69);
                runGenerator(T11, world, random, chunkX, chunkZ, 1, 70, 74);
                runGenerator(T12, world, random, chunkX, chunkZ, 1, 75, 79);
                runGenerator(T13, world, random, chunkX, chunkZ, 1, 80, 84);
                runGenerator(T14, world, random, chunkX, chunkZ, 1, 85, 89);
                runGenerator(T15, world, random, chunkX, chunkZ, 1, 90, 94);
                break;
        }

    }


    private void runGenerator(WorldGenerator gen, World world, Random rand, int chunkX, int chunkZ, int chance, int minHeight, int maxHeight) {

        if(minHeight > maxHeight || minHeight < 0 || maxHeight > 256) throw new IllegalArgumentException("Ore Generated Out of Bounds");
        int heighDiff = maxHeight - minHeight + 1;

        for(int i = 0; i < chance; i++) {
            int x = chunkX * 16 + rand.nextInt(16);
            int y = minHeight + rand.nextInt(heighDiff);
            int z = chunkZ * 16 + rand.nextInt(16);

            gen.generate(world, rand, new BlockPos(x, y, z));
        }
    }
}

i basically did as animefan8888 said, i changed the spawn chance and upped the vein count, its at 25 seconds load time now, but it takes 24 seconds without any mods

please post your code in a spoiler, or even better as a GitHub repository

reapersremorse · August 13, 2018

i had a github setup and i have way to many files, when i tried adding the rest of my files, it put them in the wrong place, i need to learn github a bit better

reapersremorse · August 13, 2018

i need to rewrite my mod in order to make things make since XD
i have a very different invironment than most people would like, but if you care to take a look, this is my fixed github repo
https://github.com/reapersremorse/UTO-Mod

reapersremorse · August 13, 2018

please excuse the odd placed classes, when i want to test something i kind of just make a class... i really do need to rewrite the mod in order for other people to easily understand what im doing, my mind is always a jumble so its easy for me.

Sign In

slow loading.... ore gen efficiency needed

Recommended Posts

reapersremorse

Animefan8888

reapersremorse

Animefan8888

reapersremorse

Animefan8888

reapersremorse

Animefan8888

reapersremorse

reapersremorse

Animefan8888

reapersremorse

Animefan8888

reapersremorse

Cadiboo

Animefan8888

reapersremorse

reapersremorse

Animefan8888

Cadiboo

reapersremorse

Cadiboo

reapersremorse

reapersremorse

reapersremorse

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Browse

Activity

Important Information