Jump to content

Capabilities not saving.


Oen44

Recommended Posts

Hi,

I've tried to implement Capabilities to save player data (XP points etc.). Everything is working except saving data. After leaving game (not closing client) and reentering, data is not preserved.

What I did notice is that writeNBT instance is always returning 0 when getting XP points.

Code: https://github.com/Oen44/RPG-Mod-MC

 

 

 

 

 

 

 

 

 

 

Link to comment
Share on other sites

1 minute ago, diesieben07 said:

Forgot to delete that. That's from tutorial or something but didn't work anyway.

 

2 minutes ago, diesieben07 said:

This is absolutely broken. You cannot just alter the capability data on the client and expect it to magically show up on the server. Moreover you cannot send packets to anything else but the server from the client. The fact that this does not crash is surprising to me.
You need to instead send a packet on the server telling it that the player has pressed a button. The server then decides what to do with that information: Can the player actually do this right now? If so, then do the capability changes. Then you will send the updated data back to the client (you already have this packet).

How do I handle button press on server-side then?

4 minutes ago, diesieben07 said:

This will crash a server. You cannot reference client-only classes from common code.

I need to use that somehow, what do you suggest?

Link to comment
Share on other sites

It works now and I get how to deal with networking, thank you.

But before that I wanted to print data on player login and what I have encountered is that EventPlayer class wasn't registering @SubscribeEvent so I had to add @Mod.EventBusSubscriber and now it works :)

 

Do I understand this correctly?

If I send packet that adds XP points to server and there add that to EntityPlayerMP capabilities, then if someone hack client code and add to EntityPlayer capabilies some XP then server will have different values because EntityPlayerMP is a different instance and that's where I should check if play has XYZ amount of XP if needed?

 

Updated code if you want to check and see if there is something wrong anyway.

Link to comment
Share on other sites

  • 2 weeks later...
2 minutes ago, Oen44 said:

Why should I prevent client from using capabilities? No need for that.

I think what he means is that why is it only registered on the client.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

4 minutes ago, Oen44 said:

Why should I prevent client from using capabilities? No need for that.

Common is called this way because it's code is common for client and server side while client proxy is being used only for client-side actions.

So your CapabilityManager will exist only for client-side operations. This fact confused me so I've asked you, why so?

Link to comment
Share on other sites

1 minute ago, Oen44 said:

Should I register that on client AND server proxy?

You should register it in Common Code.

1 minute ago, Oen44 said:

Does it matter?

Yes, if you want the data on the server.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

3 minutes ago, Oen44 said:

So I should extend Client and Sever proxy with Common and register capabilities inside Common?

No, just do it in your Main mod class(the one with the @Mod annotation).

  • Like 1

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Sorry, missed the part where you have "ServerProxy" insted of "CommonProxy" but in fact it's still the same.

You declare your ServerProxy as proxy in the Main mod class and initialize it's stages (preInit, init and postInit). Perhaps there's no difference for now but later you should either have some only-server-side operations (which are rare I guess) and use Main mod class as you common proxy or use your ServerProxy as CommonProxy with it's purpose and then you won't need to use Main mod class for it.

Edited by Asmodesu
Link to comment
Share on other sites

2 minutes ago, Asmodesu said:

or use your ServerProxy as CommonProxy

Don't do this, while this does work it doesn't make sense to do so.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • hola thanks for answering  i set some system outs to test and see whats going on      @Override     protected void saveAdditional( CompoundTag nbt ){                  nbt.put("itemhandler", itemhandler.serializeNBT() );         nbt.putInt("progress", this.progress );         System.out.println("saveAdditional(nbt)");                 System.out.println(NbtUtils.prettyPrint(nbt)); //<-- this is whats getting saved         super.saveAdditional( nbt );     }     @Override     public void load( CompoundTag nbt ){         itemhandler.deserializeNBT( nbt.getCompound("itemhandler") );         this.progress = nbt.getInt("progress" );         System.out.println(NbtUtils.prettyPrint(nbt)); //<-- this is whats minecraft is giving back to the entity          System.out.println("load(nbt)");         super.load( nbt );     }   This dead adventurer body  has two parts a block and a block Item  both has their own item-handlers and their own menus all of that seems fine  Testing remarks : *when i change some element inside the gui  it triggers the saveAdditional(nbt) system out and shows a pretty print of the data being saved  *when the world map loads it triggers the load(nbt) system out and shows a pretty print of the data minecraft is giving to this Block Entity For the testing i gonna set mi BlockEntityBodyBlock, save something in it, close minecraft, fireup the game again and check if the items remain      ################ first try set the block entity (dead adventurer body like shaped) and left only a weath seed  in the slot 10 the console says its all right    close minecraft, launch it again i see the system out whit the data returned to the entity and its look good theres is only a weed seed  ################ Second try, now i gonna change the seed for two arrows  the console says its all right the two arrows are being saved    ######### Now close and run again bam Error  minecraft returns the original data whit only a wheat seed the two arrows has been loss   ########## try again now i gonna put 3 wheat seeds Console system out says it gets it and is saving the data   ############## but after close fire again  wheat seed,  data losed once more time  and it just throw the original   ####################################################################################### sorry for the long post and the crappy video  this is the reason why i say its saving the Block Entity data only when it feels like  coze its saves data when it feels like  ¿ its something wrong whit mi BlockEntity.saveAdditional()  if  i keep trying eventually it updates and the data chages      i alredy try to  level.removeBlockEntity(pos); level.setBlockEntity(pos, bebb);     BlockEntityBodyBlock.class   BlockEntityInit.class     body_blockitem.class                  
    • Yesterday I buy a minecraft server to play with my friends you know... One of my friends send me the list of mods to add and then i start to dowload them, when i add them to the server it start crashing but i don't know about this things because it's my first time buying a minecraft server This is the error: https://paste.ee/p/sJf7B
    • Discovering that a trusted colleague had accessed my Bitcoin account and transferred $30,000 worth of bitcoins was a devastating blow. It shattered the trust I had placed in them and left me feeling vulnerable and betrayed. However, in the face of adversity, I turned to MUYERN TRUST HACKER for assistance in reclaiming control over my finances and holding the perpetrators accountable for their actions. One of the standout features of MUYERN TRUST HACKER was its ability to provide real-time alerts and notifications, keeping me informed every step of the way. With the support of MUYERN TRUST HACKER, I was able to gather irrefutable evidence of the perpetrator's actions and hold them accountable for their crimes. Armed with the information provided by the platform, I pursued legal recourse and ensured that justice was served. The perpetrator faced severe consequences for their actions, including legal penalties and financial restitution. Beyond its role in facilitating the recovery process, MUYERN TRUST HACKER provided me with a sense of empowerment and resilience in the face of adversity. While the experience was undoubtedly challenging, it ultimately served as a testament to the importance of vigilance and the power of technology in safeguarding our digital assets. Thanks to MUYERN TRUST HACKER, I emerged stronger and more resilient, ready to face whatever challenges the future may hold. Mail; muyerntrusted[At] mail-me .c o m
    • Discovering that a trusted colleague had accessed my Bitcoin account and transferred $30,000 worth of bitcoins was a devastating blow. It shattered the trust I had placed in them and left me feeling vulnerable and betrayed. However, in the face of adversity, I turned to MUYERN TRUST HACKER web [ ht tps:// muyerntrusthack.solutions/ ] for assistance in reclaiming control over my finances and holding the perpetrators accountable for their actions. One of the standout features of MUYERN TRUST HACKER was its ability to provide real-time alerts and notifications, keeping me informed every step of the way. With the support of MUYERN TRUST HACKER, I was able to gather irrefutable evidence of the perpetrator's actions and hold them accountable for their crimes. Armed with the information provided by the platform, I pursued legal recourse and ensured that justice was served. The perpetrator faced severe consequences for their actions, including legal penalties and financial restitution. Beyond its role in facilitating the recovery process, MUYERN TRUST HACKER provided me with a sense of empowerment and resilience in the face of adversity. While the experience was undoubtedly challenging, it ultimately served as a testament to the importance of vigilance and the power of technology in safeguarding our digital assets. Thanks to MUYERN TRUST HACKER, I emerged stronger and more resilient, ready to face whatever challenges the future may hold. Mail; muyerntrusted[At] mail-me .c o m  
    • Do you have still this problem? (I have it too so I want to know if you did something with it)  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.