[1.12] lang isnt reading

[The_SlayerMC]

Is there any reason that a mod wont read a lang file? path is correct and file is formatted properly

 

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/resources/assets/journey/lang/en_us.lang

 

it comes up ingame like a lang file doesn't exist and no items or anything are named which doesnt make any sense at all, so i dare say it will be something so simple to fix because it shouldnt be this hard. I just cant figure it out

[Animefan8888]

2 minutes ago, The_SlayerMC said:

it comes up ingame like a lang file doesn't exist and no items or anything are named which doesnt make any sense at all, so i dare say it will be something so simple to fix because it shouldnt be this hard. I just cant figure it out

You also need a pack.mcmeta file, you can read on the minecraft forums about it, it's really simple.

[The_SlayerMC]

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/resources/pack.mcmeta

 

still hasnt fixed the problem

[Animefan8888]

10 minutes ago, The_SlayerMC said:

still hasnt fixed the problem

Post your log, preferably in a spoiler.

[The_SlayerMC]

latest.zip

[jabelar]

You've got a lot of "Potentially Dangerous alternative prefix" warnings. That usually happens when you aren't registering things properly, although in rare cases it could be possible to ignore it (I think if you try to replace vanilla recipes it can happen). In any case you should probably fix that because it looks like your things are being registered to the minecraft "mod" and not to your mod so then that would also explain why your lang file would not be used.

[The_SlayerMC]

Well what would be the cause of something like that

[Animefan8888]

Just now, The_SlayerMC said:

Well what would be the cause of something like that

Why on earth are you registering your Items and Blocks twice?

 

And it is caused by your registry name not being assigned the right modid. Can you give us an example of the name that is appearing in your game.

[The_SlayerMC]

Dont ask me how, but i just removed the item and block repetitive registry and now the lang file is working. 

 

And also to answer

5 minutes ago, Animefan8888 said:

Why on earth are you registering your Items and Blocks twice?

I didnt register the blocks and items, that part wasnt my code it was the other dev so couldnt even begin to tell you why haha

[The_SlayerMC]

Next question, i cant use a block as a custom tab icon, items no worries but blocks dont register as a tab icon but show up fine in the tab?

[The_SlayerMC]

 

1 minute ago, diesieben07 said:

Blocks only exist when placed in the world. Inventories can only hold items. That is why ItemBlock exists.

Im using (as i always have) Item.getItemFromBlock(BLOCK) for the tab 

 

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/journey/JourneyTabs.java