[1.12.2] Replace world renderer

[Cadiboo]

On 9/22/2018 at 1:23 AM, Animefan8888 said:

world renderers(BufferBuilder instances) are stored in an instance of RegionRenderCacheBuilder

Do you know anywhere that has concepts or code that I need to draw with DefaultVertexFormats.BLOCK with the BufferBuilder? Because I simply cannot find anywhere in vanilla code (Stepped through it with the debugger - everything seems to get handed to Forge's pipeline which appears to somehow not use the BufferBuilder).

Edit - Forge's pipeline appears to add the vertexes to BufferBuilder directly with addVertexData and putPosition, rather than with BufferBuilder#pos()#color()#tex()#endVertex(); which is how I'd like (and only know how to) do it.

Edited September 26, 2018 by Cadiboo

[Draco18s]

7 hours ago, Cadiboo said:

They didn't. You said "Start a new project". Someone made their own game with their own renderer.

That answers the "how was that relevant" question.

Cool.

It still doesn't help you do what you want though. :P

[Cadiboo]

Heres my PR if anyone's interested https://github.com/MinecraftForge/MinecraftForge/pull/5166

And here's my repository where I will be implementing MarchingCubes https://github.com/Cadiboo/MinecraftForge/tree/RenderHooksMarchingCubes

 

Here are a couple screenshots of whats possible with my hooks (there are more on the PR)

[Cadiboo]

I've got everything working perfectly except for the lightmap, I don't know how to get those variables or do smooth/flat rendering with them. Any suggestions would be appreciated!

As you can see in both images the lighting is the same for every block.

[Cadiboo]

1 hour ago, Cadiboo said:

've got everything working perfectly except for the lightmap, I don't know how to get those variables or do smooth/flat rendering with them. Any suggestions would be appreciated!

I was putting my variables in in the wrong order... The correct order is lightmap(skyLight, blockLight). I still don't know how to get the proper variables though, currently I'm doing this which is very inefficient

Spoiler

int lightmapSkyLight = 0;
int lightmapBlockLight = 0;

int lightmapSkyLightUsed = 0;
int lightmapBlockLightUsed = 0;

for (int offset = 0; offset <= 5; ++offset)
{
  for (final EnumFacing facing : EnumFacing.VALUES)
  {
    final int skyLight = cache.getLightFor(EnumSkyBlock.SKY, statePos.offset(facing, offset));
    if (skyLight > 0)
    {
      lightmapSkyLight += skyLight;
      lightmapSkyLightUsed++;
    }
    final int blockLight = cache.getLightFor(EnumSkyBlock.BLOCK, statePos.offset(facing, offset));
    if (blockLight > 0)
    {
      lightmapBlockLight += blockLight;
      lightmapBlockLightUsed++;
    }
  }
}
if (lightmapSkyLightUsed > 0)
{
  lightmapSkyLight = (lightmapSkyLight << 4) / lightmapSkyLightUsed;
}
if (lightmapBlockLightUsed > 0)
{
  lightmapBlockLight = (lightmapBlockLight << 4) / lightmapBlockLightUsed;
}

Heres my final code. https://github.com/Cadiboo/MinecraftForge/blob/4d26e2a8b4edb41d572504b40b411f1ff6b7591f/src/test/java/net/minecraftforge/debug/client/rendering/RebuildChunkBlocksEventTest.java

I'm going to work on understanding & optimising it now because I basically just copy-pasted the old code & only changed what I had to to make it work.

Screenshots:

[Cadiboo]

Finished NoCubes (for the moment)

https://github.com/Cadiboo/NoCubes

Screenshots:

Edited May 8, 2019 by Cadiboo