[SOLVED] NBT Data not syncing/saving

[hiotewdew]

I'm aware at least 50000 threads exist with this exact topic. And trust me, I have read them. But my tile entity just refuses to save/sync data.

Here's my code.

package its_meow.betteranimalsplus.block;

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.play.server.SPacketUpdateTileEntity;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class TileEntityHandOfFate extends TileEntity {
	
	private boolean onFire = false;
	
	
	public TileEntityHandOfFate() {
	}
	
	
	public void setOnFire(boolean b) {
		this.onFire = b;
		this.markDirty();
	}
	
	public boolean isOnFire() {
		return onFire;
	}
	
	
	@Override
	public void readFromNBT(NBTTagCompound compound) {
		super.readFromNBT(compound);
		this.onFire = compound.getBoolean("OnFire");
	}



	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		super.writeToNBT(compound);
		compound.setBoolean("OnFire", this.onFire);
		return compound;
	}

	@Override
	public SPacketUpdateTileEntity getUpdatePacket() {
		NBTTagCompound tag = new NBTTagCompound();
		this.writeToNBT(tag);
		return new SPacketUpdateTileEntity(pos, 1, tag);
	}


	@Override
	public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity packet) {
		readFromNBT(packet.getNbtCompound());
		world.scheduleUpdate(this.pos, this.blockType, 100);
	}
	
	
	
	
	
	@Override
	@SideOnly(Side.CLIENT)
	public AxisAlignedBB getRenderBoundingBox() {
		return new AxisAlignedBB(getPos().add(-2, -4, -2), getPos().add(2, 4, 2));
	}
	
}

 

Yes, the tile entity is registered and exists. It has a TESR that renders fire (the render method uses the isOnFire() method and creates fire particles).

When I exit the world and reload it (not even leave game) the fire disappears.

Nothing external to this touches the NBT.

Edited January 6, 2019 by hiotewdew

[Cadiboo]

try using a constant for the tag name, first checking if the tag exists before setting your variable and please post your code as a github repository

[hiotewdew]

11 hours ago, Cadiboo said:

try using a constant for the tag name, first checking if the tag exists before setting your variable and please post your code as a github repository

https://github.com/itsmeow/betteranimalsplus/blob/master/src/main/java/its_meow/betteranimalsplus/block/TileEntityHandOfFate.java

 

After doing all the suggested the problem still persists.

[Animefan8888]

28 minutes ago, hiotewdew said:

After doing all the suggested the problem still persists.

You also need to override TileEntity#getUpdateTag and TileEntity#handleUpdateTag

[hiotewdew]

10 minutes ago, Animefan8888 said:

You also need to override TileEntity#getUpdateTag and TileEntity#handleUpdateTag

Yeah, I just figured out it was the syncing that was the issue.

That seems to have fixed it. Thanks! I read somewhere that those two were only nessecary for stuff related to capabilities.