Custom Block Drops 1.12.2

[DiamondMiner88]

How do i get custom block drops? This is what i have so far:

package com.diamondminer88.mod.character.blocks.A.Glass;

import com.diamondminer88.mod.character.blocks.blockbases.BlockBaseGlassA;
import com.diamondminer88.mod.character.init.ModBlocks;
import com.diamondminer88.mod.character.init.ModItems;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

import java.util.Random;

public class AGlassBlack extends BlockBaseGlassA {

    public EntityPlayer entityPlayer;
    public AGlassBlack(String name, Material material) {
        super(name, material);

        setSoundType(SoundType.GLASS);
    }
    @Override
    public Item getItemDropped(IBlockState state, Random rand, int fortune) {
        if (harvesters.get() != null) {
            entityPlayer = harvesters.get();
            if (entityPlayer.getHeldItemMainhand() != null) {
                ItemStack MainHandItemStack = entityPlayer.getHeldItemMainhand();
                if (MainHandItemStack == new ItemStack(ModItems.TOOL_DIAMOND_GLASS_CUTTER) || MainHandItemStack == new ItemStack(ModItems.TOOL_IRON_GLASS_CUTTER)) {
                    return Item.getItemFromBlock(ModBlocks.A_GLASS_BLACK);
                }
                else {
                    return ModItems.GLASS_SHARD_BLACK;
                }
            }
        }
    }

    @Override
    public boolean canSilkHarvest(World world, BlockPos pos, IBlockState state, EntityPlayer player) {
        return true;
    }

    @Override
    protected ItemStack getSilkTouchDrop(IBlockState state) {
        return new ItemStack(ModBlocks.A_GLASS_BLACK);
    }

}

 

[Animefan8888]

8 minutes ago, DiamondMiner88 said:

if (MainHandItemStack == new ItemStack(ModItems.TOOL_DIAMOND_GLASS_CUTTER) || MainHandItemStack == new ItemStack(ModItems.TOOL_IRON_GLASS_CUTTER)) {

These if statements will never be true. Please learn how "==" works. You should be comparing the Items within the stacks instead of the ItemStacks.

[DiamondMiner88]

Ok i searched it up and i get it. The only problem is now I don't know how to compare the Item not ItemStack. How do i get the Item from an ItemStack?

Edited September 24, 2018 by DiamondMiner88

[Animefan8888]

35 minutes ago, DiamondMiner88 said:

Ok i searched it up and i get it. The only problem is now I don't know how to compare the Item not ItemStack. How do i get the Item from an ItemStack?

Try looking in the ItemStack class for a method or looking around in the minecraft or forge source code that has to deal with ItemStacks like the Container classes or ItemStackHandler class.

[jabelar]

You can use Eclipse to give you a list of all the methods in the ItemStack class by right-clicking on ItemStack and choosing "Type Hierarchy". You can then scroll through and see all the available methods (and fields) and it is good to get familiar with them anyway but you should see some related to getting the item, as well as other methods for comparing ItemStacks.

[DiamondMiner88]

First of all im using Idea, and i already found a method so im testing with it.

[Big_Bad_E]

1 hour ago, DiamondMiner88 said:

First of all im using Idea, and i already found a method so im testing with it.

Idea still shows you all the methods, and maybe try the method named getItem().

[DiamondMiner88]

Ok i found a way to do that this is what i did and it worked! Thanks Guys!

@Override
    public Item getItemDropped(IBlockState state, Random rand, int fortune) {
        if (harvesters.get() != null) {
            entityPlayer = harvesters.get();
            Item MainHandHeldItem = entityPlayer.getHeldItemMainhand().getItem();
            if (MainHandHeldItem.equals(ModItems.TOOL_DIAMOND_GLASS_CUTTER) || MainHandHeldItem.equals(ModItems.TOOL_IRON_GLASS_CUTTER)) {
                this.item = Item.getItemFromBlock(ModBlocks.A_GLASS_BLACK);
            }
            else {
                this.item = ModItems.GLASS_SHARD_BLACK;
            }
        }
        return this.item;
    }
@Override
    public int quantityDropped(IBlockState state, int fortune, Random random) {
        if (harvesters.get() != null) {
            entityPlayer = harvesters.get();
            Item MainHandHeldItem = entityPlayer.getHeldItemMainhand().getItem();
            if (MainHandHeldItem.equals(ModItems.TOOL_DIAMOND_GLASS_CUTTER) || MainHandHeldItem.equals(ModItems.TOOL_IRON_GLASS_CUTTER)) {
                this.quantity = 1;
            }
            else {
                this.quantity = Main.randomNumber(1, 10);
            }
        }
        return this.quantity;
    }

 

[jabelar]

23 hours ago, Big_Bad_E said:

Idea still shows you all the methods, and maybe try the method named getItem().

Yes. I think they call it "Structure" view.

 

In any case, all modders should literally just scroll through the list of methods for all the major classes to get a good sense of what is available. You can even get new modding ideas by doing this.