[1.12.2] dynamic item textures

[Merthew]

How would i change the texture used for an item in the model file based on nbt data?

[V0idWa1k3r]

You can use property overrides.

[Merthew]

Not sure what i did wrong here. If anyone can help that would be nice, by the way thank you V0idWa1k3r.

 

Code: https://github.com/Merthew/Empire-Of-Blood

Working on the syringe item.

[V0idWa1k3r]

38 minutes ago, Merthew said:

Not sure what i did wrong here.

You didn't... do anything? I see no mentions of property overrides in your ItemSyringe.

ModItem, ItemBase, etc is an anti-pattern. Don't use it.

Oh also anything like IHasModel is stupid. All items need models and there is nothing about model registration that requires access to something private/protected in the item. And yes, your ModItem is basically a fancy IHasModel. Don't use it. Register your models in the ModelRegistryEvent.

 

Quote

ItemInit.ITEMS.add(this);

Instantinate your items directly in the RegistryEvent. Not anywhere else. Not in pre init. If you need a reference to the item later use ObjectHolders.

 

Quote

private int blood = 0;

There is no reason for this to exist.

 

if(blood == cap || blood == cap - 1 || blood == cap - 2) {
	blood = cap;
}
else {
	blood += 3;
}

=>

blood = Math.min(this.cap, blood + 3);

 

Quote

nbt.setInteger("cap", cap);

Any reason you are storing the cap in the NBT? You are only referencing the one declared by your Item instance.

 

[Merthew]

sorry i forgot to push the code to github. clearly i have very little idea what i am doing.

[V0idWa1k3r]

Quote

stack.getTagCompound().getInteger("blood")/stack.getTagCompound().getInteger("cap")

What is 10 divided by 100? It's 0. 99 / 100 is also 0. Only 100 / 100 is 1. Dividing anything that doesn't have decimal points will just discard anything beyond them. You need to cast one of these to something that has a decimal point, like a float.

 

 

[Merthew]

How would i register the items/blocks in the registry event? would i create them in the registryhandler class?

[Animefan8888]

29 minutes ago, Merthew said:

How would i register the items/blocks in the registry event? would i create them in the registryhandler class?

You can store a static field in a class and initialize it in the registry event and then register them.

[Draco18s]

No one thought about CustomMeshDefinitions? Property overrides only work for number values.

 

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/industry/item/ItemCastingMold.java#L80

[Merthew]

Did i do it right? Also looking at the model registry. I have no idea if this was the "right" way. Thanks for your help by the way.

 

Code: https://github.com/Merthew/Empire-Of-Blood

[Merthew]

Well right now, github doesn't seem to be working. it may not have updated.