Hello, so I'm trying to make a new material with tools that get random bonus attributes when crafted. I'm starting with the sword, which can get a bonus 1-3 damage when crafted. My problem is that, whenever I craft them, the damage of all the previous swords changes too. This is my code:

 

public class ToolSword extends ItemSword implements IHasModel{
	
	private Random rand;
	private int bonusDamage;

	public ToolSword(String name, ToolMaterial material){
		super(material);
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(CreativeTabs.COMBAT);
		rand = new Random();
		bonusDamage = 0;
		
		ModItems.ITEMS.add(this);
	}
	
	@Override
	public void registerModels() {
		
		Main.proxy.registerItemRenderer(this, 0, "inventory");
		
	}
	
	@Override
	public void onCreated(ItemStack stack, World worldIn, EntityPlayer playerIn){
		bonusDamage = rand.nextInt(3) + 1;
    }
	
	@Override
	public Multimap<String, AttributeModifier> getAttributeModifiers(EntityEquipmentSlot slot, ItemStack stack) {
		final Multimap<String, AttributeModifier> modifiers = super.getAttributeModifiers(slot, stack);

		if (slot == EntityEquipmentSlot.MAINHAND) {
			replaceModifier(modifiers, SharedMonsterAttributes.ATTACK_DAMAGE, ATTACK_DAMAGE_MODIFIER, bonusDamage);
		}

		return modifiers;
	}
	
	private void replaceModifier(Multimap<String, AttributeModifier> modifierMultimap, IAttribute attribute, UUID id, double amount) {
		// Get the modifiers for the specified attribute
		final Collection<AttributeModifier> modifiers = modifierMultimap.get(attribute.getName());

		// Find the modifier with the specified ID, if any
		final Optional<AttributeModifier> modifierOptional = modifiers.stream().filter(attributeModifier -> attributeModifier.getID().equals(id)).findFirst();

		if (modifierOptional.isPresent()) { // If it exists,
			final AttributeModifier modifier = modifierOptional.get();
			modifiers.remove(modifier); // Remove it
			modifiers.add(new AttributeModifier(modifier.getID(), modifier.getName(), modifier.getAmount() + amount, modifier.getOperation())); // Add the new modifier
		}
	}
	
}

 

I did try using 

stack.addAttributeModifier

which kept each item with its unique value. However, it completely replaces the old damage and attack speed values and the Sharpness enchantment no longer has effect on it, so I don't like using this command because I still want Sharpness to increase its damage even more.

 

Any help?

Items are singletons (there is only 1 of the ever) if you want damage etc. you have to apply that stuff to the ItemStacks

6 minutes ago, Cadiboo said:

Items are singletons (there is only 1 of the ever) if you want damage etc. you have to apply that stuff to the ItemStacks

I also tried that, but the original attributes all get removed, but I just want to add additional damage, while keeping the original one and the original attack speed.

 

This is what I tried:

 

@Override
	public void onCreated(ItemStack stack, World worldIn, EntityPlayer playerIn){
		bonusDamage = rand.nextInt(3) + 9;
		stack.addAttributeModifier(SharedMonsterAttributes.ATTACK_DAMAGE.getName(), new AttributeModifier("Weapon modifier", bonusDamage, 0), EntityEquipmentSlot.MAINHAND);
	}

 

It says "add" but it doesn't really add, it replaces the old ones, which I don't want.

there is a ItemStack sensitive variant of addAttributeModifier. not sure if this fixes that but at least it's what I used for something similar

You should probably be using a capability on the ItemStack and subscribe to an attack entity event, and add extra damage based on that capability

You need to store the additional value to your ItemStack's NBT data or a capability, then override Item#getAttributeModifiers and make the damage attribute add the itemDamage + yourDamage as the modifier. See how ItemSword does that.

 

Edit: Thanks for @Animefan8888 for correcting my mistake, whoops, had ItemStack written as the base class instead of Item.

Edited October 23, 20186 yr by V0idWa1k3r

1 hour ago, V0idWa1k3r said:

Edit: Thanks for @Animefan8888 for correcting my mistake, whoops

No problem.?

Edited October 23, 20186 yr by Animefan8888