Jump to content

Recommended Posts

Posted

So if I have, lets say, a stack of 10 bottles, when I right click to milk a cow, it deletes the whole stack and replaces it with a filled bottle, whereas it needs to just add a filled bottle to the inventory and not delete the stack. I looked through EntityCow code in the milking event, but it's not working. Not sure what concept I'd have to add to the code below.

  Reveal hidden contents

 

Posted
  On 11/20/2018 at 3:01 AM, Siqhter said:

event.getEntityPlayer()

Expand  

First off this is a little repetitive you created a variable for this.

  On 11/20/2018 at 3:01 AM, Siqhter said:

setInventorySlotContents

Expand  

This method sets the slots contents whereas you just want to decrease the stack size. Use ItemStack#setCount to set the count. Then call InventoryPlayer#addItemStackToInventory or similar

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted
  On 11/20/2018 at 5:54 PM, Siqhter said:

but I'm just not clear on the set count.

Expand  

An ItemStack has a count of how many "items" are in it. So if you fill one you need to set the count to the count - 1.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted
  On 11/20/2018 at 6:03 PM, Siqhter said:

Ok, that makes sense, but for some reason I'm crashing when I initialize the variable player that I defined at the top of my class.

Expand  

Post the whole class file.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted
public class MainEvents {

    
    @SubscribeEvent
    public void inventoryif isRemoteif instanceof if EMPTY_BOTTLE capabilitiesisCreativeModeinventorynew BOTTLED_MILKENTITY_COW_MILK1.0F1.0F
Posted (edited)
  Reveal hidden contents

If I define player locally it works, but I'm not sure why. Also I posted what I originally had, I know the .setCount isn't correct.

Edited by Siqhter
Posted
  On 11/20/2018 at 6:27 PM, Siqhter said:
public class MainEvents {

    
    @SubscribeEvent
    public void inventoryif isRemoteif instanceof if EMPTY_BOTTLE capabilitiesisCreativeModeinventorynew BOTTLED_MILKENTITY_COW_MILK1.0F1.0F
Expand  

That doesnt even compile.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted
  On 11/20/2018 at 6:29 PM, Siqhter said:

itemstack.setCount(-1)

Expand  

This sets the count of how many items are in the stack. So when this is called you know have -1 bottles. Use ItemStack#getCount

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted (edited)

Ah, I see. I debugged my code and can confirm it is running twice. e.g. Instead of subtracting 1 bottle from the stack, it takes 2. Aside from that it it working. Here is the correct class.

  Reveal hidden contents

I added this so it would add the final bottled item to the players current hand when the stack of empty bottles is depleted.

  Reveal hidden contents

 

Edited by Siqhter
Posted

Well, I realized if I return true then it doesn't allow both hands (from EnumHand) to be fired. But it still runs the addItemStackToInventory code twice.

  Reveal hidden contents

 

Posted

Try checking if the hand from the event is the hand holding the ItemStack. You can also use ItemStack#shrink()

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted
  On 11/21/2018 at 7:07 AM, Cadiboo said:

Try checking if the hand from the event is the hand holding the ItemStack.

Expand  

Well I tried making a conditional like this, but I'm not sure if I'm following you. I understand the idea.

  Reveal hidden contents

 

Posted

If event.getHand == player.getActiveHand

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.