[1.12.2] TE's Inventory Does Not Save

[unassigned]

Hello,

 

Recently I've been developing a framework for my mod to be built around, however, when added a 'test' tile entity with an inventory, I get an issue with the item in the slot not saving when leaving and rejoining.

Here are the snippets of code of the TE's NBT:

  Reveal hidden contents

    public static void saveSlotsToNBT(IItemHandler slots, NBTTagCompound compound) {
        if (slots != null && slots.getSlots() > 0) {
            NBTTagList tagList = new NBTTagList();
            for (int i = 0; i < slots.getSlots(); i++) {
                ItemStack slot = slots.getStackInSlot(i);
                NBTTagCompound tagCompound = new NBTTagCompound();
                if (ItemUtil.isValid(slot)) {
                    slot.writeToNBT(tagCompound);
                }
                tagList.appendTag(tagCompound);
            }
            compound.setTag("Items", tagList);
        }
    }

    public static void loadSlotsFromNBT(IItemHandlerModifiable slots, NBTTagCompound compound) {
        if (slots != null && slots.getSlots() > 0) {
            NBTTagList tagList = compound.getTagList("Items", 10);
            for (int i = 0; i < slots.getSlots(); i++) {
                NBTTagCompound tagCompound = tagList.getCompoundTagAt(i);
                slots.setStackInSlot(i, tagCompound != null && tagCompound.hasKey("id") ? new ItemStack(tagCompound) : ItemUtil.getEmpty());
            }
        }
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        super.writeToNBT(compound);
        saveSlotsToNBT(this.inv, compound);

        return compound;
    }

    @Override
    public void readFromNBT(NBTTagCompound compound) {
        super.readFromNBT(compound);
        loadSlotsFromNBT(this.inv, compound);
    }

 

 

 

If you'd like to view the whole class or other classes, you can find it on my github: https://github.com/unassignedxd/plentifulutils

 

Thanks.

[D4RSORC]

I believe you need to add this to your class:

public NBTTagCompound getUpdateTag()
{
  return writeToNBT(super.getUpdateTag());
}

@Nullable
@Override
public SPacketUpdateTileEntity getUpdatePacket() {
	return new SPacketUpdateTileEntity(getPos(), getBlockMetadata(), writeToNBT(new NBTTagCompound()));
}

@Override
public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) {
	readFromNBT(pkt.getNbtCompound());
}

 

[Animefan8888]

  On 11/21/2018 at 6:39 PM, unassigned said:

I get an issue with the item in the slot not saving when leaving and rejoining.

Expand  

How do you know that it isnt saving, this could be a desync issue.

[unassigned]

  On 11/21/2018 at 7:15 PM, D4RSORC said:

I believe you need to add this to your class:

public NBTTagCompound getUpdateTag()
{
  return writeToNBT(super.getUpdateTag());
}

@Nullable
@Override
public SPacketUpdateTileEntity getUpdatePacket() {
	return new SPacketUpdateTileEntity(getPos(), getBlockMetadata(), writeToNBT(new NBTTagCompound()));
}

@Override
public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) {
	readFromNBT(pkt.getNbtCompound());
}

 

Expand  

I do have this in the TileEntityBase that I'm extending.

 

  On 11/21/2018 at 7:34 PM, Animefan8888 said:

 How do you know that it isnt saving, this could be a desync issue.

Expand  

I believe it is not a desync issue as, in the tile that has the inventory, I have:

  Reveal hidden contents

@Override
public void update() {
    if(this.inv.getStackInSlot(0) != ItemUtil.getEmpty())
    {
        System.out.println("client? " + world.isRemote + " - item: " + this.inv.getStackInSlot(0).getItem().getUnlocalizedName());
    }
}

 

which prints the item properly - and displays correctly when opened and closed, however, once restarted, the client prints: 

[14:59:46] [main/INFO] [STDOUT]: [unassigned.plentifulutilities.tile.TileEntityVoidAccumulator:update:25]: client? true - item: tile.air

while the server does not print anything; probably because the itemstack is considered empty.

 

Here is all of the TileEntityBase code for sending packets and saving other NBT data:

  Reveal hidden contents

@Override
public NBTTagCompound writeToNBT(NBTTagCompound compound) {
    compound.setBoolean("DropInv", this.dropInv);
    compound.setInteger("TicksAlive", this.ticksAlive);

    return compound;
}

@Override
public void readFromNBT(NBTTagCompound compound) {
    this.dropInv = compound.getBoolean("DropInv");
    this.ticksAlive = compound.getInteger("TicksAlive");
}

@Override
public SPacketUpdateTileEntity getUpdatePacket() {
    NBTTagCompound compound = new NBTTagCompound();
    this.writeToNBT(compound);
    return new SPacketUpdateTileEntity(this.getPos(), -1, compound);
}

@Override
public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) {
    this.readFromNBT(pkt.getNbtCompound());
}

@Override
public NBTTagCompound getUpdateTag() {
    NBTTagCompound compound = new NBTTagCompound();
    this.writeToNBT(compound);
    return compound;
}

@Override
public void handleUpdateTag(NBTTagCompound tag) {
    this.readFromNBT(tag);
}

@Override
public boolean shouldRefresh(World world, BlockPos pos, IBlockState oldState, IBlockState newState) {
    return !oldState.getBlock().isAssociatedBlock(newState.getBlock());
}

 

 

Thanks.

Edited November 21, 2018 by unassigned

[Cadiboo]

This may not be related, but I’ve noticed your not calling super in a lot of methods, your not implementing has/getCapability and your manually implementing the saving functionality of ItemStackHander (it has a public method to write its contents to NBT).

You should also be using @ObjectHolder for your items and blocks (what if another mod overrides one of your items? currently your references will still point to an item that doesn’t exist anymore and will crash the game if used)

[unassigned]

  On 11/21/2018 at 10:33 PM, Cadiboo said:

This may not be related, but I’ve noticed your not calling super in a lot of methods, your not implementing has/getCapability

Expand  

2

Okay, I've added supers to methods that need it, and I do believe that I am implementing the capabilites via TileEntityBase class:

  Reveal hidden contents

  @Override
    public boolean hasCapability(Capability<?> capability, @Nullable EnumFacing facing) {
        return this.getCapability(capability, facing) != null;
    }

    @Nullable
    @Override
    public <T> T getCapability(Capability<T> capability, @Nullable EnumFacing facing) {
        if(capability == CapabilityEnergy.ENERGY)
        {
            IEnergyStorage storage = this.getEnergyStorage(facing);
            if(storage == null)
            {
                return (T)storage;
            }
        }
        else if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
        {
            IItemHandler iHandler = this.getItemHandler(facing);
            if(iHandler == null)
            {
                return (T)iHandler;
            }
        }
        return super.getCapability(capability, facing);
    }

    public IEnergyStorage getEnergyStorage(EnumFacing facing){ return null; }
    public IItemHandler getItemHandler(EnumFacing facing){ return null; }

 

 

If a TE needs an energy/item capability, you just set the getEnergyStorage/getItemHandler within the class, which reduces the amount of code per TE - which I do within the TE I'm testing (TileEntityVoidAccumulator)

 

  On 11/21/2018 at 10:33 PM, Cadiboo said:

and your manually implementing the saving functionality of ItemStackHander (it has a public method to write its contents to NBT).

Expand  

I was not aware of the existence of this, so I'd just throw 

this.inv.deserializeNBT(compound);

within the writeNBT; and would I use the serialize method to read or would I need to keep the functionality I have currently.

 

  On 11/21/2018 at 10:33 PM, Cadiboo said:

You should also be using @ObjectHolder for your items and blocks (what if another mod overrides one of your items? currently your references will still point to an item that doesn’t exist anymore and will crash the game if used)

Expand  

This must somewhat new, as I was not aware of this annotation (most of my modding knowledge is from 1.7.10/1.11). Would this just lead a class, or would this go where it is initialized?

 

Thanks.

 

[Cadiboo]

  On 11/21/2018 at 10:49 PM, unassigned said:

This must somewhat new, as I was not aware of this annotation (most of my modding knowledge is from 1.7.10/1.11). Would this just lead a class, or would this go where it is initialized?

Expand  

Im not sure when it was added. It allows mods to override other mods items and puts in place base functionality to allow forge (in the future) to dynamically load and unload mods ingame.

You can see examples of it here

https://github.com/Cadiboo/Example-Mod/blob/master/src/main/java/cadiboo/examplemod/init/ModBlocks.java (References)

and here

https://github.com/Cadiboo/Example-Mod/blob/6a1ba1042d63b80fb6e6676a0d04018e0bc1f3ae/src/main/java/cadiboo/examplemod/EventSubscriber.java#L28-L43 (initialisation and registry)

[unassigned]

  On 11/21/2018 at 11:22 PM, Cadiboo said:

 Im not sure when it was added. It allows mods to override other mods items and puts in place base functionality to allow forge (in the future) to dynamically load and unload mods ingame.

You can see examples of it here

https://github.com/Cadiboo/Example-Mod/blob/master/src/main/java/cadiboo/examplemod/init/ModBlocks.java (References)

and here

 https://github.com/Cadiboo/Example-Mod/blob/6a1ba1042d63b80fb6e6676a0d04018e0bc1f3ae/src/main/java/cadiboo/examplemod/EventSubscriber.java#L28-L43 (initialisation and registry)

Expand  

Alright, I have added that to my holders, thanks!

[unassigned]

Interestingly, I have added these supers to the methods that need it, and now the item does not stay in the slot; once I put in the item, and close the GUI, it just pops out. The code on github is updated, use these classes:

TileEntityBase

TileEntityInventoryBase

TileEntityVoidAccumualtor

ContainerVoidAccumulator

 

Thanks.