A Question About IHasModel

[Siqhter]

I think I was just phrasing this badly. Yes, by instantiating I did mean creating the new block using the "new" keyword. And then I register it in the correct register event in my registryhandler class.

[Cadiboo]

You can do it however you want, as long as you

- instantiate your objects in the registry events

- reference your objects in a way that allows overrides

 

[Animefan8888]

1 hour ago, Cadiboo said:

- reference your objects in a way that allows overrides

This is not required.

[Cadiboo]

16 minutes ago, Animefan8888 said:

This is not required.

Why not?

[Animefan8888]

Just now, Cadiboo said:

Why not?

I'm just saying that the @ObjectHolder annotation is not required for that, I didn't clarify. All Items and Blocks can be overridden without it. Via the same methods, reflection. The only bonus @ObjectHolder would add is not being required to have the mod in which you are overriding, but then overriding that block/item wouldn't make sense. Plus you would have to depend on the mod in the first place because your Block/Item should extend the same parents to allow for the inheritance to stay the same for compatibility. And if you didn't want to depend on the mod you could just use a system similar to the @SidedProxy which you would have to anyways due to the inheritance thing.

[Cadiboo]

I very specifically didn’t say anything about @ObjectHolder, you can do your object syncing yourself if you want.

I was thinking preventing something along the lines of trying to use a an old object that’s been overriden

[Animefan8888]

2 minutes ago, Cadiboo said:

I was thinking preventing something along the lines of trying to use a an old object that’s been overriden 

I personally think that this is the job of the person who has overriden the object.

[Cadiboo]

1 minute ago, Animefan8888 said:

I personally think that this is the job of the person who has overriden the object.

Consider this

Mod 1 caches a Block

Mod 2 overrides it

Mod 1 tried to use the cached value

-> crash

Properly syncing/referencing the value would solve the problem. I don’t think that Mod 2 is at fault in this scenario

[Animefan8888]

Just now, Cadiboo said:

Properly syncing/referencing the value would solve the problem. I don’t think that Mod 2 is at fault in this scenario

True Mod 1 shouldn't cache a value till they are in the init event.