1.12.2-14.23.0.2532 broke Durability crafting (OreDictionary)

[Kaltinril]

After item loses durability, crafting no longer works.

 

I've read through some of the bugs, pull requests, and responses here, but the official documentation doesn't say anything about this, and I"m a bit lost on what the official response from LexManos is.

 

If I create a tool that will lose durability during crafting, is there no way now to use the OreDictionary and the forge shapeless crafting JSON?

 

 

This works below 1.12.2-14.23.0.2532 but not after.  Cutter is a tool that loses durability.  Vanilla crafting shapeless works just fine with "Data": 32767 for this tool.

 

What is the recommendation for adding custom tools to OreDictionary that need to be used in a crafting recipe?  Or is this a bug that needs to be fixed still?

 

{
  "type": "forge:ore_shapeless",
  "ingredients": [
    {
      "item": "minecraft:gold_block"
    },
    {
      "type": "forge:ore_dict",
      "ore": "cutter"
    }
  ],
  "result": {
    "item": "minecraft:diamond",
    "count": 5
  }
}

 

Tested all these versions to find the issue (no = doesn't work, yes = works):

• 1.12.2-14.23.5.2784 - no
• 1.12.2-14.23.4.2750 - no
• 1.12.2-14.23.3.2677 - no
• 1.12.2-14.23.1.2575 - no
• 1.12.2-14.23.0.2549 - no
• 1.12.2-14.23.0.2538 - no
• 1.12.2-14.23.0.2532 - no
• 1.12.2-14.23.0.2531 - yes
• 1.12.2-14.23.0.2528 - yes
• 1.12.2-14.23.0.2486 - yes
• 1.12.1-14.22.1.2485 - Yes
• 1.12.1-14.22.1.2484 - Yes
• 1.12-14.21.1.2442 - yes

 

References:

• https://github.com/MinecraftForge/MinecraftForge/pull/4472
• https://github.com/MinecraftForge/MinecraftForge/issues/4516
• https://github.com/MinecraftForge/MinecraftForge/pull/4449#issuecomment-342743511
• https://github.com/MinecraftForge/MinecraftForge/commit/c8efe29d61f849d7adbd58d8236a5c563e6562ef#diff-7353e6eb929f963ebd9596c9dd9cc920
• http://www.minecraftforge.net/forum/topic/66649-1122-using-oredictionary-and-ignoring-damage/?tab=comments#comment-319911

 

 

[LexManos]

Damageable Tools were never intended to be part of the dictionary. People just used it because it worked. So we supported it until we couldn't anymore. The changes done were done to comply with vanilla, which no longer has a wildcard value, standards and features. If you need a damageable tool, use a custom ingredient.

[Kaltinril]

@LexManos thank you for the quick reply. 

 

I was following a tutorial, no where does it say that I can see in documentation not to use or with tools, or I wouldn't have asked. 

 

Is a custom ingredient what these factory JSON files are?  Can you provide a link to documentation so I can do that? 

 

https://mcforge.readthedocs.io/en/latest/utilities/recipes/#factories