[SOLVED] [1.12.2] Overriding BlockSkull makes my item drop 3x in survival but normally in creative

[hiotewdew]

I've got a class that overrides BlockSkull and I want it to drop the right item when it's broken, and I've overriden onBlockHarvested,  getItemDropped, and getDrops, and in creative mode it works as expected (no drop unless broken by water/other sources) but in survival it drops 3x unless broken by water/other sources. Here's my class:

package its_meow.betteranimalsplus.common.block;
 
import java.util.Random;
 
import its_meow.betteranimalsplus.BetterAnimalsPlusMod;
import net.minecraft.block.BlockSkull;
import net.minecraft.block.ITileEntityProvider;
import net.minecraft.block.SoundType;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumBlockRenderType;
import net.minecraft.util.NonNullList;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
 
public class BlockAnimalSkull extends BlockSkull implements ITileEntityProvider {
 
    public BlockAnimalSkull() {
        this.setHardness(1.0F);
        this.setSoundType(SoundType.STONE);
        this.translucent = true;
        this.fullBlock = false;
        this.setCreativeTab(BetterAnimalsPlusMod.tab);
    }
   
    /**
     * Called before the Block is set to air in the world. Called regardless of if the player's tool can actually
     * collect this block
     */
    @Override
    public void onBlockHarvested(World worldIn, BlockPos pos, IBlockState state, EntityPlayer player)
    {
        if (player.capabilities.isCreativeMode)
        {
            state = state.withProperty(NODROP, Boolean.valueOf(true));
            worldIn.setBlockState(pos, state, 4);
        }
        this.dropBlockAsItem(worldIn, pos, state, 0);
        super.onBlockHarvested(worldIn, pos, state, player);
    }
 
    @Override
    public boolean hasTileEntity() {
        return true;
    }
 
    @Override
    public boolean isOpaqueCube(IBlockState state) {
        return false;
    }
 
    @Override
    public boolean isFullCube(IBlockState state) {
        return false;
    }
 
    @Override
    public boolean isTopSolid(IBlockState state) {
        return false;
    }
 
    @Override
    public boolean canDispenserPlace(World world, BlockPos pos, ItemStack stack) {
        return false;
    }
 
    @Override
    public EnumBlockRenderType getRenderType(IBlockState state)
    {
        return EnumBlockRenderType.INVISIBLE;
    }
 
 
 
    @Override
    public ItemStack getPickBlock(IBlockState state, RayTraceResult target, World world, BlockPos pos,
            EntityPlayer player) {
        return new ItemStack(this.getItemBlock(), 1);
    }
 
    @Override
    public ItemStack getItem(World worldIn, BlockPos pos, IBlockState state) {
        return new ItemStack(this.getItemBlock(), 1);
    }
   
    @Override
    public void getDrops(NonNullList<ItemStack> drops, IBlockAccess world, BlockPos pos, IBlockState state, int fortune)
    {
        if (!((Boolean)state.getValue(NODROP)).booleanValue())
        {
            Random rand = world instanceof World ? ((World)world).rand : RANDOM;
 
            Item item = this.getItemDropped(state, rand, fortune);
            if (item != Items.AIR)
            {
                drops.add(new ItemStack(item, 1));
            }
        }
    }
 
    /**
     * Get the Item that this Block should drop when harvested.
     */
    @Override
    public Item getItemDropped(IBlockState state, Random rand, int fortune)
    {
        return this.getItemBlock();
    }
 
 
    public ItemBlock getItemBlock() {
        return null;
    }
}

Don't worry, my actual implementations override getItemBlock(), so it doesn't pass null. This is a generic class.

Edited January 6, 2019 by hiotewdew

[Discult]

so wait let me get this right you want it to break only if in contact with water and this works in creative but when in survival you can break it and it drops 3x or when broke with water it drops 3x?

[hiotewdew]

5 hours ago, Discult said:

so wait let me get this right you want it to break only if in contact with water and this works in creative but when in survival you can break it and it drops 3x or when broke with water it drops 3x?

No, I want it to break normally. But in creative, it gives item drops (none) as normal, unless water runs it over (like a torch). In survival, it drops 3x. If it's water, it drops 1x.

[hiotewdew]

If someone could explain how/when each of these methods (onBlockHarvested,  getItemDropped, and getDrops) and such are called, that could help too.

[V0idWa1k3r]

onBlockHarvested is called when the block is harvested by the player. The default implementation invokes getDrops.

getDrops populates a list with drops from the block. The default implementation invokes getItemDropped.

getItemDropped simply returns the Item to drop. It may or may not be called in a custom implementation of getDrops.

[hiotewdew]

Figured it out. The first issue was in the onBlockHarvested method, I did a super call to BlockSkull.onBlockHarvested, causing 1/2 of the extra drops. The second issue was from the Block.harvestBlock method, which also calls a drop of the item as well as some stat collection. I override harvestBlock and removed the dropping code but kept the stats/hunger part. Also, since my onBlockHarvested was identical to BlockSkull's, I removed the override and let BlockSkull handle it. Now it drops as expected.