Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

I am trying to create an item that has a different effect based on its NBT tag. However, instead of picking a single effect, the item does every effect at once. Here is my return code:

 

    protected void onFoodEaten(ItemStack stack, World worldIn, EntityPlayer player) { //Only supposed to add one effect.
        if (!worldIn.isRemote) {
            String tag = (stack.getTagCompound().getString("effect"));
            switch(tag) {
                case "REGEN": player.addPotionEffect(new PotionEffect(MobEffects.REGENERATION, 140, 1));
                case "JUMP": player.addPotionEffect(new PotionEffect(MobEffects.JUMP_BOOST, 100, 1));
                case "POISON": player.addPotionEffect(new PotionEffect(MobEffects.POISON, 220, 1));
                case "WITHER": player.addPotionEffect(new PotionEffect(MobEffects.WITHER, 140, 1));
                case "WEAKNESS":player.addPotionEffect(new PotionEffect(MobEffects.WEAKNESS, 160, 1));
                case "BLINDNESS":player.addPotionEffect(new PotionEffect(MobEffects.BLINDNESS, 140, 1));
                case "FIRE_RESISTANCE":player.addPotionEffect(new PotionEffect(MobEffects.FIRE_RESISTANCE, 60, 1));
                case "SATURATION":player.addPotionEffect(new PotionEffect(MobEffects.SATURATION, 100, 1));
                case "SPEED":player.addPotionEffect(new PotionEffect(MobEffects.SPEED, 100, 1));
            }
        }
    }

 

...and here is the code for my tag. The tag works properly, so I doubt it is an error here:

 

    public void onUpdate(ItemStack stack, World world, Entity entity, int metadata, boolean bool) {
        NBTTagCompound nbt = stack.getTagCompound();
        if(nbt == null) {stack.setTagCompound(new NBTTagCompound());}
        if(nbt.hasNoTags()) {
            nbt.setString("effect", "NULL");
        }
    }

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

11 hours ago, thedarkcolour said:

Thanks! Adding break; fixed it

I'd also question why you're running code every single tick just to add a marker to your item's NBT.  Why not just check stack.hasTagCompound() in your onFoodEaten() method?

 

(I appreciate the code you're running isn't terribly expensive in CPU terms, but it's good practice not to run unnecessary tick-based code).

  • Author
6 hours ago, desht said:

I'd also question why you're running code every single tick just to add a marker to your item's NBT.  Why not just check stack.hasTagCompound() in your onFoodEaten() method?

 

(I appreciate the code you're running isn't terribly expensive in CPU terms, but it's good practice not to run unnecessary tick-based code).

NEVERMIND: I got the stack.hasTagCompound to work, thanks

Edited by thedarkcolour

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.