Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Using Minecraft#player to get Player NBT Data Not Working

teh_black_d00m

By teh_black_d00m
in Modder Support

 Share

Recommended Posts

teh_black_d00m Tree Puncher

teh_black_d00m

Posted
Posted (edited)

I have used a Capability to store a lot of data on to the player and usually Im able to access the data just fine and get the correct values by using  the capability's interface  (called IStats) . here is an example of using the Capability to get the necessary values that works fine
 

  Reveal hidden contents

But when I try to do this
  

Minecraft.getMinecraft().displayGuiScreen(new CharacterSheetGUI(Minecraft.getMinecraft().player));

once the GUI is displayed its giving me incorrect numbers. Here is the GUI code if it helps

  Reveal hidden contents


For example this line
  

fontRenderer.drawString("Long Blade " + playerSkills.getStat(StatConstants.LONG_BLADE), centerX+40, centerY+90, 0x000000);

will display Long Blade 0 (which is the value it is initialized to in the default implementation of IStats) instead of the actual value that's supposed to be there. How can I make make sure I am getting the correct data from the player? The mod is only meant to be single player if that changes anything

Edited by teh_black_d00m
De Joker Tree Puncher

De Joker

Posted
Posted
  On 1/20/2019 at 7:30 AM, teh_black_d00m said:

  

fontRenderer.drawString("Long Blade " + playerSkills.getStat(StatConstants.LONG_BLADE), centerX+40, centerY+90, 0x000000);

 

Expand  

Where are you setting those StatConstants.LONG_BLADE?   maybe you are calling the drawString before the actual setting.

Cadiboo Reality Controller

Cadiboo

Posted
Posted

Are you syncing the values to the client? By default capability data is not synchronised between the server and client. 

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

teh_black_d00m Tree Puncher

teh_black_d00m

Posted
  • Author
Posted (edited)
  On 1/20/2019 at 8:45 AM, Cadiboo said:

Are you syncing the values to the client? By default capability data is not synchronised between the server and client. 

Expand  

Probably not because I don't know how to do that haha. For each field in the default implementation of IStats I've done this 

public class FatigueStorage implements IStorage<IStats>
{
	
	@Override
	public NBTBase writeNBT(Capability<IStats> capability, IStats instance, EnumFacing side)
	{
		final NBTTagCompound tag = new NBTTagCompound();
		
		tag.setFloat("fatigue", instance.getFatigue());
		
		return tag;
	}
	

	@Override
	public void readNBT(Capability<IStats> capability, IStats instance, EnumFacing side, NBTBase nbt)
	{
		
		final NBTTagCompound tag = (NBTTagCompound) nbt;

		instance.setFatigue(tag.getFloat("fatigue")); 
		
	}
	
	
}

Is that not enough? Does the data still need to be synced even if the mod is only multiplayer?

 

EDIT: I mean the EXACT OPPOSITE. its singleplayer only

Edited by teh_black_d00m
typo
teh_black_d00m Tree Puncher

teh_black_d00m

Posted
  • Author
Posted
  On 1/20/2019 at 8:19 AM, De Joker said:

Where are you setting those StatConstants.LONG_BLADE?   maybe you are calling the drawString before the actual setting.

Expand  

Those are all static final variables that are set in the StatConstants class. They are just used as indexes for the arrays holding the actual data

Cadiboo Reality Controller

Cadiboo

Posted
Posted

You need to make a packet to sync your capability data, I would give an example, but all my implementations are horrible, a quick forum search should yield some good results. The basics of it are

- have a (logical sever side) packet that implements IMessage and IMessageHandler

- register that packet for the logical server in your network manager

- send the packet when you need to sync data

An example of a network manager can be found here, and it is instantiated here

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

teh_black_d00m Tree Puncher

teh_black_d00m

Posted
  • Author
Posted

Okay I watched this tutorial

  Reveal hidden contents

and i think I i mostly understand how to send packets but I'm still not really sure when I'm supposed to send one. I also dont know why when I try to display my custom NBT data using a Gui its not synced. Here is a class that draws some bars displaying the player's health and fatigue(capability I made)
 

  Reveal hidden contents

Here is code that restores the player's fatigue

  Reveal hidden contents

I put that code in a packet and I know that its working like its supposed to (restoring the fatigue) but for some reason the fatigue bar is not being draw correctly to show that its working. It actually was working before when I wasn't using a packet. Any idea why this is happening?

teh_black_d00m Tree Puncher

teh_black_d00m

Posted
  • Author
Posted
  On 1/20/2019 at 3:06 PM, diesieben07 said:

I have no idea what you mean by "putting that code in a packet". You can't put "code in a packet".

Expand  

I mean to say that I moved that code I posted earlier so that its here now
 

  Reveal hidden contents

And then I did this
 

  Reveal hidden contents

I know it worked because it kept printing "Fatigue is being restored".

 

 

  On 1/20/2019 at 3:06 PM, diesieben07 said:

For capability data that is always needed on the client (like in your case for the HUD [not GUI!]), you need to send the packet in the following cases:

  • PlayerLoggedInEvent
  • PlayerRespawnEvent
  • PlayerChangedDimensionEvent
  • Whenever the data changes. 

 

Expand  

So am I correct in assuming that I need to send a packet in the above example (because I am changing the amount of fatigue the player has)? And if I send the packets correctly in the cases you mentioned my HUD will display the correct data right?

teh_black_d00m Tree Puncher

teh_black_d00m

Posted
  • Author
Posted
  On 1/20/2019 at 3:45 PM, diesieben07 said:

Why did you do this?

Expand  

I did that because I thought that's what you're supposed to do to send a packet (put the code into a class that implements IMessage and IMessageHandler) but maybe I'm still not quite understanding packets correctly. So for the example of restoring the player's fatigue I need to use that MessageRestoreFatigue class to send a packet right? I'm not sure of the correctly terminology here but I think I'm supposed to be sending data between the client and server so they are synced. Should I be using the toBytes and fromBytes methods to just send the data instead of doing what I did in the example (moving all the code into MessageRestoreFatigue)?

Draco18s Reality Controller

Draco18s

Posted
Posted (edited)

"Packets" are a conversion between runtime data and a binary serialization format. That's all.

 

Look at this example:

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/ores/networking/ToClientMessageOreParticles.java

 

The only "code" that is there is writing to, and reading from, a ByteBuffer. Your MessageRestoreFatigue does fuckall: it writes no data and it reads no data and instead...gets the capability on the client and directly modifies the values there. What you should be doing, is sending a packet from the server to the client containing the fatigue value.

 

Your packet also does that on the networking thread, which is a major no-no.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept