Jump to content

Recommended Posts

  • Replies 62
  • Created
  • Last Reply

Top Posters In This Topic

Posted

I recommend using a git client. I recommended GitHub Desktop because it’s easy to use, eclipse and IntelliJ also have integrated clients. Other good clients are git kracken and source tree

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted

1. 

git remote add origin https://github.com/Drachenbauer/AngryBirdsMod.git

 

2. Read: https://product.hubspot.com/blog/git-and-github-tutorial-for-beginners

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Posted (edited)
Spoiler

[18:15:45.242] [Client thread/WARN] [minecraft/EntityType]: No data fixer registered for entity angrybirdsmod.red
[18:15:45.251] [Client thread/WARN] [minecraft/EntityType]: No data fixer registered for entity angrybirdsmod.chuck
[18:15:45.260] [Client thread/WARN] [minecraft/EntityType]: No data fixer registered for entity angrybirdsmod.blues
[18:15:45.270] [Client thread/WARN] [minecraft/EntityType]: No data fixer registered for entity angrybirdsmod.bomb
[18:15:45.280] [Client thread/WARN] [minecraft/EntityType]: No data fixer registered for entity angrybirdsmod.mathilda

What does this mean?

what is a data fixer

Edited by Drachenbauer
Posted

LTNightshade posted this in another topic:

@ObjectHolder(nimox.ModId)
public class ModBlocks {

    public static NonNullList<BlockBase> BLOCKS = NonNullList.create();

    @ObjectHolder("test")
    public static final BlockTest BLOCK_TEST = null;

    public static void register(RegistryEvent.Register<Block> blockRegistryEvent){
        // Create Instances and add to BLOCKS List.
        BLOCKS.add(new BlockTest());

        // Registering all
        for(Block b : BLOCKS) {
            blockRegistryEvent.getRegistry().register(b);
        }
    }
}

  

 

it includes a

@ObjectHolder

at this place, too

Posted (edited)

i just dit not realize, that you mean that gerRegistryName with that.

 

so they are in the BlockInit, too, in the lines, where i added the properties to my blocks.

 

i placed theese names in the ObjectHolders now

Edited by Drachenbauer
Posted

for me it looks like since any time ago my compiler soes not notice modifications in my projekt any more, no matter wot i do:

-modify java-files

-modify resources

-do refreshes and ctensups and use the debug-button instead of just run it

Posted (edited)

as i used my RunClient.bat to run it instead of the button in the Eclipse-window, now i got the sparn-eggs look right, but they still spawn chickens. instead of my custom Angry Birds...

 

and i still get theese in the log:

Quote

[28Feb2019 19:02:02.667] [Client thread/WARN] [net.minecraft.entity.EntityType/]: No data fixer registered for entity angrybirdsmod.red
[28Feb2019 19:02:02.695] [Client thread/WARN] [net.minecraft.entity.EntityType/]: No data fixer registered for entity angrybirdsmod.chuck
[28Feb2019 19:02:02.718] [Client thread/WARN] [net.minecraft.entity.EntityType/]: No data fixer registered for entity angrybirdsmod.blues
[28Feb2019 19:02:02.749] [Client thread/WARN] [net.minecraft.entity.EntityType/]: No data fixer registered for entity angrybirdsmod.bomb
[28Feb2019 19:02:02.774] [Client thread/WARN] [net.minecraft.entity.EntityType/]: No data fixer registered for entity angrybirdsmod.mathilda

 

Edited by Drachenbauer
Posted

Have you considered using IntelliJ? Try setting up your workspace from scratch again. If you really can’t see them for some reason, you can always find everything about Forge at https://github.com/MinecraftForge/MinecraftForge

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted

i remembered now, that i had it under preInitRegistry in my old version and that this is replaced with

private void setup(final FMLCommonSetupEvent event)

in my new one.

so i moved there now.

A new test will show me, if it´s right now

Posted (edited)

the contents of the minecraft forge-link tell me, that i have to call it here:

 

private void clientRegistries(final FMLClientSetupEvent event)
    {
        RenderHandler.regigisterEntityRenders();
    }

 

but my entitys still look like chickens...

Edited by Drachenbauer
Posted
2 hours ago, diesieben07 said:

Please, for the love of god, learn to use the debugger.

You are not spawning chickens. You are spawning your entities, but they all extend EntityChicken. Since you register your entity renderers in the wrong place, they are ignored and the default (chicken) takes over.

Please also read the JavaDocs for the methods you use. RenderingRegistry.registerEntityRenderingHandler clearly explains when it must be called. You are not following these instructions.

There’s a dedicated registry event for registering renders. Use it

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted

The Proxies in your mod are unnecessary, useless and unused. You should use object holder on your entity entries. I don't think that the FMLClientSetupEvent is the right place to register your renders. Other than pretty much everything else, I can't see anything wrong with your mod.

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted (edited)

In the linked page it says this:

 

Call this during {@link net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent}.

 

Why you say it´s wrong?

 

And where must i call it instead?

 

And i don´t know, what´s wrong, because i´ve never seen the java-files-structure of a finished 1.13.2 mod with items, entities and blocks, that fully works right.

 

If i try to use objectholders, the log says:

Quote

[03Mär2019 15:05:26.188] [Client thread/WARN] [net.minecraftforge.registries.ObjectHolderRegistry/REGISTRIES]: Found an unqualified ObjectHolder annotation (mathilda) without a modid context at Lcom/drachenbauer32/angrybirdsmod/Main$RegistryEvents;.EggMathilda, ignoring

and it crashes.

 

I wonder, why only at the fifth entity, but not at the other four...

Edited by Drachenbauer

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements




  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
    • Hi here is an update. I was able to fix the code so my mod does not crash Minecraft. Please understand that I am new to modding but I honestly am having a hard time understanding how anyone can get this to work without having extensive programming and debugging experience as well as searching across the Internet, multiple gen AI bots (claude, grok, openai), and examining source code hidden in the gradle directory and in various github repositories. I guess I am wrong because clearly there are thousands of mods so maybe I am just a newbie. Ok, rant over, here is a step by step summary so others can save the 3 days it took me to figure this out.   1. First, I am using forge 54.1.0 and Minecraft 1.21.4 2. I am creating a mod to add a shotgun to Minecraft 3. After creating the mod and compiling it, I installed the .jar file to the proper directory in Minecraft and used 1.21.4-forge-54.1.0 4. The mod immediately crashed with the error: Caused by: java.lang.NullPointerException: Item id not set 5. Using the stack trace, I determined that the Exception was being thrown from the net.minecraft.world.item.Item.Properties class 6. It seems that there are no javadocs for this class, so I used IntelliJ which was able to provide a decompiled version of the class, which I then examined to see the source of the error. Side question: Are there javadocs? 7. This method, specifically, was the culprit: protected String effectiveDescriptionId() {      return this.descriptionId.get(Objects.requireNonNull(this.id, "Item id not set"));  } 8. Now my quest was to determine how to set this.id. Looking at the same source file, I determined there was another method:  public Item.Properties setId(ResourceKey<Item> pId) {             this.id = pId;             return this;   } 9. So now, I need to figure out how to call setId(). This required working backwards a bit. Starting from the constructor, I stubbed out the variable p which is of type Item.Properties public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); Rather than putting this all on one line, I split it up for readability like this: private static final Item.Properties p = new Item.Properties().useItemDescriptionPrefix().setId(rk); Here is was the missing function, setId(), which takes a type of ResourceKey<Item>. My next problem is that due to the apparent lack of documentation (I tried searching the docs on this site) I could not determine the full import path to ResourceKey. I did some random searching on the Internet and stumbled across a Github repository which gave two clues: import net.minecraft.resources.ResourceKey; import net.minecraft.resources.ResourceLocation; Then I created the rk variable like this: private static ResourceKey<Item> rk = ResourceKey.create(Registries.ITEM, ResourceLocation.parse("modid:shotgunmod")); And now putting it all together in order: private static ResourceKey<Item> rk = ResourceKey.create(Registries.ITEM, ResourceLocation.parse("modid:shotgunmod")); private static final Item.Properties p = new Item.Properties().useItemDescriptionPrefix().setId(rk); public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); This compiled and the mod no longer crashes. I still have more to do on it, but hopefully this will save someone hours. I welcome any feedback and if I missed some obvious modding resource or tutorial that has this information. If not, I might suggest we add it somewhere for people trying to write a mod that doesn't crash. Thank you !!!  
    • I will keep adding to this thread with more information in case anyone can help, or at the very least I can keep my troubleshooting organized. I decided to downgrade to 54.1.0 in the hopes that this would fix the issue but it didn't. At least now I am on a "recommended" version. The crash report did confirm my earlier post that the Exception is coming from effectiveDescriptionId(). I'll continue to see if I can find a way to set the ID manually.   Caused by: java.lang.NullPointerException: Item id not set         at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item$Properties.effectiveDescriptionId(Item.java:465) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item.<init>(Item.java:111) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ShotgunItem.<init>(ShotgunItem.java:19) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ModItems.lambda$static$0(ModItems.java:15) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/net.minecraftforge.registries.DeferredRegister$EventDispatcher.lambda$handleEvent      
    • It just randomly stop working after a rebooted my dedicated server PLEASE HELP!   com.google.gson   Failed to start the minecraft server com.google.gson.JsonSyntaxException: Expected a com.google.gson.JsonObject but was com.google.gson.JsonPrimitive; at path $  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.