Jump to content

[SOLVED] [1.12.2] Help using WorldSavedData


Angercraft

Recommended Posts

I cannot for the life of me, get the following code to enter the writeToNBT and readFromNBT...

I used the info from https://mcforge.readthedocs.io/en/latest/datastorage/worldsaveddata/ but I don't think it's very clear what exactly to do...

 

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapStorage;
import net.minecraft.world.storage.WorldSavedData;

public class DataTest extends WorldSavedData {

    private static final String DATA_NAME = "ModID_Test";
    private static DataTest instance;
    private int testInt;

    public DataTest() {
        super(DATA_NAME);
    }

    public static DataTest get(World world) {
        MapStorage storage = world.getMapStorage();
        instance = (DataTest) storage.getOrLoadData(DataTest.class, DATA_NAME);

        if (instance == null) {
            instance = new DataTest();
            storage.setData(DATA_NAME, instance);
        }
        return instance;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
        int temp = nbt.getCompoundTag("testData").getInteger("testInt");
        testInt = temp;
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        compound.setInteger("testInt", testInt);
        compound.setTag("testData", compound);
        return compound;
    }

    public void setCharData(int testInt) {
        this.testInt = testInt;
        markDirty();
    }

    public int getTestInt() {
        return testInt;
    }
}

 

Edited by Angercraft
Link to comment
Share on other sites

21 minutes ago, Angercraft said:

compound.setInteger("testInt", testInt); compound.setTag("testData", compound);

Why are you trying to set a tag of the compound to itself?

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Okay, i tried adding a public constructor with string parameter, and removed the tag on the compound. But sadly it still doesn't work.

 

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapStorage;
import net.minecraft.world.storage.WorldSavedData;

public class DataTest extends WorldSavedData {

    private static final String DATA_NAME = "ModID_Test";
    private static DataTest instance;
    private int testInt;

    public DataTest() {
        super(DATA_NAME);
    }

    public DataTest(String name) {
        super(name);
    }

    public static DataTest get(World world) {
        MapStorage storage = world.getMapStorage();
        instance = (DataTest) storage.getOrLoadData(DataTest.class, DATA_NAME);

        if (instance == null) {
            instance = new DataTest();
            storage.setData(DATA_NAME, instance);
        }
        return instance;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
        int temp = nbt.getInteger("testInt");
        testInt = temp;
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        compound.setInteger("testInt", testInt);
        return compound;
    }

    public void setCharData(int testInt) {
        this.testInt = testInt;
        markDirty();
    }

    public int getTestInt() {
        return testInt;
    }
}

 

Link to comment
Share on other sites

Oh sorry mate, should have mentioned that. Right now I just use a BreakEvent to trigger it.

 

@SubscribeEvent
    public static void brokeBlock(BlockEvent.BreakEvent event) {
        System.out.println("Block broken: "+event.getState().getBlock().getUnlocalizedName()+" by: "+event.getPlayer().getName());
        World world = Minecraft.getMinecraft().world;
        DataTest data = DataTest.get(world);
        if(data != null) {
            data.setCharData(1);
        }
    }

 

Link to comment
Share on other sites

I'm not sure if I am getting this correctly, but does this mean I have to get a serverside world somehow?

I figured it out! Though I don't know if this is how it is meant to be done.

@SubscribeEvent
    public static void brokeBlock(BlockEvent.BreakEvent event) {
        DataTest data = DataTest.get(event.getWorld());
        if(data != null) {
            data.setCharData(1);
        }
    }

 

Edited by Angercraft
Link to comment
Share on other sites

In case any other people are going to look at this in the future.

Final WorldSavedData object:

import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraft.world.storage.MapStorage;
import net.minecraft.world.storage.WorldSavedData;

public class DataTest extends WorldSavedData {

    private static final String DATA_NAME = "ModID_Test";
    private static DataTest instance;
    private int testInt;

    public DataTest() {
        super(DATA_NAME);
    }

    public DataTest(String name) {
        super(name);
    }

    public static DataTest get(World world) {
        MapStorage storage = world.getMapStorage();
        instance = (DataTest) storage.getOrLoadData(DataTest.class, DATA_NAME);

        if (instance == null) {
            instance = new DataTest();
            storage.setData(DATA_NAME, instance);
        }
        return instance;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
        testInt = nbt.getInteger("testInt");
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        compound.setInteger("testInt", testInt);
        return compound;
    }

    public void setCharData(int testInt) {
        this.testInt = testInt;
        markDirty();
    }

    public int getTestInt() {
        return testInt;
    }
}

 

 

Using the WorldSavedData object from a PlayerEvent type: (Only example, you can get it from other ways, just keep in mind we have to use the Logical Server Side world)

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.EventPriority;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.PlayerEvent;

@Mod.EventBusSubscriber(modid = Reference.MOD_ID)
public class ServerListener {

    @SubscribeEvent(priority = EventPriority.NORMAL)
    public static void playerConnected(PlayerEvent.PlayerLoggedInEvent event) {
        DataTest data = DataTest.get(event.player.world);
        if(data != null) {
            int testInt = data.getCharData();
            System.out.println("Value: "+testInt);
        }
    }

    @SubscribeEvent(priority = EventPriority.NORMAL)
    public static void playerDisconnected(PlayerEvent.PlayerLoggedOutEvent event) {
        DataTest data = DataTest.get(event.player.world);
        if(data != null) {
            data.setCharData(1);
            System.out.println("Value: "+testInt);
        }
    }
}

 

  • Like 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.